dash/src
MarcoFalke 2aa30a70e8
Merge #12764: doc: Remove field in getblocktemplate help that has never been used.
ac8a1d092e [RPC] Remove field in getblocktemplate help that has never been used (Conor Scott)

Pull request description:

  [BIP 22 - getblocktemplate](https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki#Transactions%20Object%20Format) specifies an optional flag, `required` if the transaction must be in the block.

  Luke's implementation #936 did not include this flag, and it was later added to the help description in #3246 (more than a year later) but the field was still never actually implemented. As far as I can tell, bitcoin core would have never actually included this in a `getblocktemplate` call, so it seems logical to remove it from the help description.

  If I am missing something or this is considered harmless - I can close the PR.

Tree-SHA512: f25dda51cc4e1512aff69309be04e3053bdccc1cf03c8d58e8866aa1fdf9d86cc57df872e85528351fc8a8d6d64a8f46a36c513680834762d854f368fbeb0f44
2020-07-17 15:45:43 -05:00
..
bench Merge #13598: bench: fix incorrect behaviour in prevector.cpp 2020-07-08 20:03:36 -05:00
bls remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
compat Merge #12998: Default to defining endian-conversion DECLs in compat w/o config 2020-04-03 04:10:53 -05:00
config
consensus Implement new way of concentrated signature recovery 2020-03-31 19:58:07 +02:00
crypto Merge #12573: Fix compilation when compiler do not support __builtin_clz* 2020-04-16 10:24:22 -05:00
evo evo: Avoid some unnecessary copying in BuildNewListFromBlock (#3594) 2020-07-10 04:25:41 +03:00
governance remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
immer
leveldb Merge #12518: [0.16] Bump leveldb subtree 2020-03-24 11:43:10 -05:00
llmq llmq: Fix thread handling in CDKGSessionManager and CDKGSessionHandler (#3601) 2020-07-16 23:30:59 +03:00
masternode remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
obj
obj-test
policy scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
primitives Merge #12731: Support serialization as another type without casting 2020-06-11 23:20:48 -05:00
privatesend privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
qt qt: General CSS related redesigns (#3563) 2020-07-16 23:30:36 +03:00
rpc Merge #12764: doc: Remove field in getblocktemplate help that has never been used. 2020-07-17 15:45:43 -05:00
script scripted-diff: Avoid temporary copies when looping over std::map (Merge #13241) 2020-07-07 11:46:21 -05:00
secp256k1 Merge #15703: Update secp256k1 subtree to latest upstream 2020-03-14 11:01:03 -05:00
support Merge #11878: Add Travis check for duplicate includes 2020-07-01 20:12:03 -05:00
test Merge #13565: test: Fix AreInputsStandard test to reference the proper scriptPubKey 2020-07-08 20:03:38 -05:00
univalue Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (#3532) 2020-06-18 12:17:23 +03:00
wallet Merge #13568: Trivial: Remove double semicolon from wallet.cpp and misc.cpp 2020-07-08 18:32:05 -05:00
zmq Merge #10493: Use range-based for loops (C++11) when looping over map elements 2020-04-01 12:43:18 -05:00
.clang-format Merge #12982: Fix inconsistent namespace formatting guidelines 2020-06-27 10:43:32 -05:00
addrdb.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2020-04-01 12:43:18 -05:00
addrdb.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
addressindex.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
addrman.cpp Merge #12622: net: Correct addrman logging 2020-06-13 14:50:11 -05:00
addrman.h Merge #9037: net: Add test-before-evict discipline to addrman 2020-06-13 14:50:11 -05:00
amount.h
arith_uint256.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
arith_uint256.h Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator 2020-06-13 14:50:11 -05:00
base58.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
base58.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
batchedlogger.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
batchedlogger.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
bip39_english.h
bip39.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
bip39.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
blockencodings.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
blockencodings.h Merge #14685: fix a deserialization overflow edge case 2020-06-08 20:27:14 -05:00
blockfilter.cpp Merge #14073: blockfilter: Avoid out-of-bounds script access. 2020-06-13 14:08:18 -05:00
blockfilter.h Rename BlockFilterType::BASIC to BASIC_FILTER 2020-06-13 14:08:18 -05:00
bloom.cpp fix lint failure 2020-06-12 01:17:37 -05:00
bloom.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
cachemap.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
cachemultimap.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
chain.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
chain.h Merge #13234: Break circular dependency: chain -> pow -> chain 2020-07-01 14:08:47 -05:00
chainparams.cpp privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
chainparams.h privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
chainparamsbase.cpp Merge #11878: Add Travis check for duplicate includes 2020-07-01 20:12:03 -05:00
chainparamsbase.h Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections 2020-05-09 17:35:59 -05:00
chainparamsseeds.h Merge #12393: Fix a-vs-an typos 2020-06-17 14:29:55 -05:00
checkpoints.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2020-04-01 12:43:18 -05:00
checkpoints.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
checkqueue.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
clientversion.cpp Merge #11966: clientversion: Use full commit hash for commit-based version descriptions 2020-06-11 23:20:48 -05:00
clientversion.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
coins.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2020-04-01 12:43:18 -05:00
coins.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
compat.h Merge pull request #3445 from codablock/pr_epoll 2020-04-22 17:10:33 +02:00
compressor.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
compressor.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
core_io.h Merge #13422: Drop ParseHashUV in favor of calling ParseHashStr 2020-07-07 11:39:35 -05:00
core_memusage.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
core_read.cpp Merge #13422: Drop ParseHashUV in favor of calling ParseHashStr 2020-07-07 11:39:35 -05:00
core_write.cpp Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (#3532) 2020-06-18 12:17:23 +03:00
ctpl.h
cuckoocache.h Merge #12716: Fix typos and cleanup in various files 2020-06-11 23:20:48 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running 2020-06-13 14:50:11 -05:00
dash-tx-res.rc
dash-tx.cpp Merge #13422: Drop ParseHashUV in favor of calling ParseHashStr 2020-07-07 11:39:35 -05:00
dashd-res.rc
dashd.cpp scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
dbwrapper.cpp Merge #12659: Improve Fatal LevelDB Log Messages 2020-06-18 11:41:53 -05:00
dbwrapper.h Merge #12604: Add DynamicMemoryUsage() to CDBWrapper to estimate LevelDB memory use 2020-06-14 11:41:07 -05:00
dsnotificationinterface.cpp Change litemode to disablegovernance (#3577) 2020-06-29 00:00:00 +03:00
dsnotificationinterface.h Fix issues introduced with asynchronous signal handling (#3369) 2020-03-20 19:11:54 +03:00
flat-database.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
fs.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
fs.h
hash.cpp Merge #11884: Remove unused include in hash.cpp 2020-03-24 11:43:10 -05:00
hash.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
hdchain.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
hdchain.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
httprpc.cpp Merge #13118: RPCAuth Detection in Logs 2020-07-08 20:03:37 -05:00
httprpc.h
httpserver.cpp Merge pull request #3518 from PastaPastaPasta/backports-0.17-pr1 2020-06-11 20:51:58 +03:00
httpserver.h
indirectmap.h
init.cpp Merge #13614: doc: Update command line help for -printtoconsole and -debuglogfile (satwo) 2020-07-17 15:45:43 -05:00
init.h scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
keepass.cpp Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (#3532) 2020-06-18 12:17:23 +03:00
keepass.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
key.cpp Merge #9598: Improve readability by removing redundant casts to same type (on all platforms) 2020-06-18 11:41:53 -05:00
key.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
keystore.cpp Merge #11667: Add scripts to dumpwallet RPC 2020-04-01 12:43:18 -05:00
keystore.h Merge #11667: Add scripts to dumpwallet RPC 2020-04-01 12:43:18 -05:00
limitedmap.h Add cache for CBlockTreeDB::HasTxIndex (#3402) 2020-04-08 22:18:33 +02:00
Makefile.am Merge #12788: [build] Tune wildcards for LIBSECP256K1 target 2020-07-08 20:03:36 -05:00
Makefile.bench.include Merge #13312: docs: Add a note about the source code filename naming convention 2020-07-07 11:17:45 -05:00
Makefile.leveldb.include
Makefile.qt.include qt: Add -custom-css-dir commmand line parameter (#3557) 2020-07-12 22:32:04 +03:00
Makefile.qttest.include
Makefile.test.include continued 13312 2020-07-07 11:27:55 -05:00
memusage.h Bugfix: Include <memory> for std::unique_ptr 2020-04-08 11:46:27 -05:00
merkleblock.cpp Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage 2020-04-08 11:46:27 -05:00
merkleblock.h Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage 2020-04-08 11:46:27 -05:00
messagesigner.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
messagesigner.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
miner.cpp Merge #13480: Avoid copies in range-for loops and add a warning to detect them 2020-07-08 18:32:04 -05:00
miner.h Merge #11689: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…) 2020-07-01 14:08:47 -05:00
net_processing.cpp Merge #13615: net: Remove unused interrupt from SendMessages 2020-07-08 20:03:37 -05:00
net_processing.h Merge #13615: net: Remove unused interrupt from SendMessages 2020-07-08 20:03:37 -05:00
net.cpp Merge #13615: net: Remove unused interrupt from SendMessages 2020-07-08 20:03:37 -05:00
net.h Merge #13615: net: Remove unused interrupt from SendMessages 2020-07-08 20:03:37 -05:00
netaddress.cpp Merge pull request #3518 from PastaPastaPasta/backports-0.17-pr1 2020-06-11 20:51:58 +03:00
netaddress.h Merge #14728: fix uninitialized read when stringifying an addrLocal 2020-06-09 19:06:54 -05:00
netbase.cpp Merge pull request #3518 from PastaPastaPasta/backports-0.17-pr1 2020-06-11 20:51:58 +03:00
netbase.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
netfulfilledman.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
netfulfilledman.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
netmessagemaker.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
noui.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
noui.h
pow.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
pow.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
prevector.h
protocol.cpp Merge bitcoin#10387: Eventually connect to NODE_NETWORK_LIMITED peers (#3417) 2020-04-19 16:21:47 +03:00
protocol.h Merge #12731: Support serialization as another type without casting 2020-06-11 23:20:48 -05:00
pubkey.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
pubkey.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
random.cpp Merge #11878: Add Travis check for duplicate includes 2020-07-01 20:12:03 -05:00
random.h Merge #12716: Fix typos and cleanup in various files 2020-06-11 23:20:48 -05:00
rest.cpp Merge #13259: refactoring: add a method for determining if a block is pruned or not 2020-07-01 20:12:03 -05:00
reverse_iterator.h
reverselock.h
saltedhasher.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
saltedhasher.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
scheduler.cpp Merge #11824: Block ActivateBestChain to empty validationinterface queue 2020-03-24 17:21:59 +03:00
scheduler.h Merge #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending 2020-07-01 14:08:47 -05:00
serialize.h Merge #13580: build: Detect if char equals int8_t 2020-07-08 18:32:05 -05:00
spentindex.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
spork.cpp privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
spork.h privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
stacktraces.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
stacktraces.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
streams.h Merge #12254: BIP 158: Compact Block Filters for Light Clients 2020-06-13 14:08:18 -05:00
sync.cpp Merge #13300: qa: Initialize lockstack to prevent null pointer deref 2020-07-01 14:08:47 -05:00
sync.h Merge #13423: [net] Thread safety annotations in net_processing 2020-06-08 20:27:14 -05:00
threadinterrupt.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
threadinterrupt.h
threadsafety.h Merge #13423: [net] Thread safety annotations in net_processing 2020-06-08 20:27:14 -05:00
timedata.cpp Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} 2020-06-28 19:28:57 -05:00
timedata.h
tinyformat.h Merge #12716: Fix typos and cleanup in various files 2020-06-11 23:20:48 -05:00
torcontrol.cpp Merge #13291: test: Don't include torcontrol.cpp into the test file 2020-07-01 14:08:47 -05:00
torcontrol.h Backport 12381 (#3528) 2020-06-13 21:21:30 +03:00
txdb.cpp Merge #12891: [logging] add lint-logs.sh to check for newline termination. 2020-06-11 23:20:48 -05:00
txdb.h Merge #12731: Support serialization as another type without casting 2020-06-11 23:20:48 -05:00
txmempool.cpp Merge #13480: Avoid copies in range-for loops and add a warning to detect them 2020-07-08 18:32:04 -05:00
txmempool.h Merge #13531: doc: Clarify that mempool txiter is const_iterator 2020-07-08 18:32:04 -05:00
ui_interface.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
ui_interface.h
uint256.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
uint256.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
undo.h Merge #12254: BIP 158: Compact Block Filters for Light Clients 2020-06-13 14:08:18 -05:00
unordered_lru_cache.h
util.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
util.h util: Change TraceThread's "name" type: "const char*" -> "const std::string" (#3609) 2020-07-15 00:15:05 +03:00
utilmoneystr.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
utilmoneystr.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
utilstrencodings.cpp Merge #12182: Remove useless string initializations 2020-06-10 18:32:43 -05:00
utilstrencodings.h
utiltime.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
utiltime.h Merge #16046: util: Add type safe GetTime 2020-04-08 14:50:07 +02:00
validation.cpp Fail GetTransaction when the block from txindex is not in mapBlockIndex (#3606) 2020-07-14 11:22:36 +02:00
validation.h Merge #13481: doc: Rewrite some validation docs as lock annotations 2020-07-08 20:03:37 -05:00
validationinterface.cpp Merge #11824: Block ActivateBestChain to empty validationinterface queue 2020-03-24 17:21:59 +03:00
validationinterface.h Merge #11824: Block ActivateBestChain to empty validationinterface queue 2020-03-24 17:21:59 +03:00
version.h Verify min proto version and open ports of LLMQ members and vote on bad ones 2020-03-31 07:07:52 +02:00
versionbits.cpp scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
versionbits.h scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
walletinitinterface.h Merge #12836: Make WalletInitInterface and DummyWalletInit private, fix nullptr deref (#3498) 2020-05-20 12:24:51 +03:00
warnings.cpp Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} 2020-06-28 19:28:57 -05:00
warnings.h Merge #13090: Remove Safe mode (achow101) 2020-06-27 10:43:32 -05:00