2be67c7605
86b47fa741408b061ab0bda784b8678bfd7dfa88 speed up Unserialize_impl for prevector (Akio Nakamura)
Pull request description:
The unserializer for prevector uses `resize()` for reserve the area, but it's prefer to use `reserve()` because `resize()` have overhead to call its constructor many times.
However, `reserve()` does not change the value of `_size` (a private member of prevector).
This PR make the logic of read from stream to callback function, and prevector handles initilizing new values with that call-back and ajust the value of `_size`.
The changes are as follows:
1. prevector.h
Add a public member function named 'append'.
This function has 2 params, number of elemenst to append and call-back function that initilizing new appended values.
2. serialize.h
In the following two function:
- `Unserialize_impl(Stream& is, prevector<N, T>& v, const unsigned char&)`
- `Unserialize_impl(Stream& is, prevector<N, T>& v, const V&)`
Make a callback function from each original logic of reading values from stream, and call prevector's `append()`.
3. test/prevector_tests.cpp
Add a test for `append()`.
## A benchmark result is following:
[Machine]
MacBook Pro (macOS 10.13.3/i7 2.2GHz/mem 16GB/SSD)
[result]
DeserializeAndCheckBlockTest => 22% faster
DeserializeBlockTest => 29% faster
[before PR]
# Benchmark, evals, iterations, total, min, max, median
DeserializeAndCheckBlockTest, 60, 160, 94.4901, 0.0094644, 0.0104715, 0.0098339
DeserializeBlockTest, 60, 130, 65.0964, 0.00800362, 0.00895134, 0.00824187
[After PR]
# Benchmark, evals, iterations, total, min, max, median
DeserializeAndCheckBlockTest, 60, 160, 77.1597, 0.00767013, 0.00858959, 0.00805757
DeserializeBlockTest, 60, 130, 49.9443, 0.00613926, 0.00691187, 0.00635527
ACKs for top commit:
laanwj:
utACK 86b47fa741408b061ab0bda784b8678bfd7dfa88
Tree-SHA512: 62ea121ccd45a306fefc67485a1b03a853435af762607dae2426a87b15a3033d802c8556e1923727ddd1023a1837d0e5f6720c2c77b38196907e750e15fbb902
|
||
|---|---|---|
| .. | ||
| data | ||
| addrman_tests.cpp | ||
| allocator_tests.cpp | ||
| amount_tests.cpp | ||
| arith_uint256_tests.cpp | ||
| base32_tests.cpp | ||
| base58_tests.cpp | ||
| base64_tests.cpp | ||
| bip32_tests.cpp | ||
| bip39_tests.cpp | ||
| blockencodings_tests.cpp | ||
| bloom_tests.cpp | ||
| bls_tests.cpp | ||
| bswap_tests.cpp | ||
| cachemap_tests.cpp | ||
| cachemultimap_tests.cpp | ||
| checkqueue_tests.cpp | ||
| coins_tests.cpp | ||
| compress_tests.cpp | ||
| crypto_tests.cpp | ||
| cuckoocache_tests.cpp | ||
| dbwrapper_tests.cpp | ||
| DoS_tests.cpp | ||
| evo_deterministicmns_tests.cpp | ||
| evo_simplifiedmns_tests.cpp | ||
| getarg_tests.cpp | ||
| governance_validators_tests.cpp | ||
| hash_tests.cpp | ||
| key_tests.cpp | ||
| limitedmap_tests.cpp | ||
| main_tests.cpp | ||
| Makefile | ||
| mempool_tests.cpp | ||
| merkle_tests.cpp | ||
| miner_tests.cpp | ||
| multisig_tests.cpp | ||
| net_tests.cpp | ||
| netbase_tests.cpp | ||
| pmt_tests.cpp | ||
| policyestimator_tests.cpp | ||
| pow_tests.cpp | ||
| prevector_tests.cpp | ||
| raii_event_tests.cpp | ||
| random_tests.cpp | ||
| ratecheck_tests.cpp | ||
| README.md | ||
| reverselock_tests.cpp | ||
| rpc_tests.cpp | ||
| sanity_tests.cpp | ||
| scheduler_tests.cpp | ||
| script_P2PK_tests.cpp | ||
| script_P2PKH_tests.cpp | ||
| script_P2SH_tests.cpp | ||
| script_standard_tests.cpp | ||
| script_tests.cpp | ||
| scriptnum10.h | ||
| scriptnum_tests.cpp | ||
| serialize_tests.cpp | ||
| sighash_tests.cpp | ||
| sigopcount_tests.cpp | ||
| skiplist_tests.cpp | ||
| streams_tests.cpp | ||
| subsidy_tests.cpp | ||
| test_dash_fuzzy.cpp | ||
| test_dash_main.cpp | ||
| test_dash.cpp | ||
| test_dash.h | ||
| timedata_tests.cpp | ||
| torcontrol_tests.cpp | ||
| transaction_tests.cpp | ||
| txvalidationcache_tests.cpp | ||
| uint256_tests.cpp | ||
| univalue_tests.cpp | ||
| util_tests.cpp | ||
| versionbits_tests.cpp | ||
Compiling/running unit tests
Unit tests will be automatically compiled if dependencies were met in ./configure
and tests weren't explicitly disabled.
After configuring, they can be run with make check.
To run the dashd tests manually, launch src/test/test_dash.
To add more dashd tests, add BOOST_AUTO_TEST_CASE functions to the existing
.cpp files in the test/ directory or add new .cpp files that
implement new BOOST_AUTO_TEST_SUITE sections.
To run the dash-qt tests manually, launch src/qt/test/test_dash-qt
To add more dash-qt tests, add them to the src/qt/test/ directory and
the src/qt/test/test_main.cpp file.
Running individual tests
test_dash has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:
test_dash --log_level=all --run_test=getarg_tests
... or to run just the doubledash test:
test_dash --run_test=getarg_tests/doubledash
Run test_dash --help for the full list.
Note on adding test cases
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Dash Core already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).
The build system is setup to compile an executable called test_dash
that runs all of the unit tests. The main source file is called
test_dash.cpp. To add a new unit test file to our test suite you need
to add the file to src/Makefile.test.include. The pattern is to create
one test file for each class or source file for which you want to create
unit tests. The file naming convention is <source_filename>_tests.cpp
and such files should wrap their tests in a test suite
called <source_filename>_tests. For an example of this pattern,
examine uint256_tests.cpp.
For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.