sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
2c1e51e6b7
dash/src
History
fanquake 0cb7934d88 Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache 
0a433fc876d82df1005f175c1254fff62f0f36f8 [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache (John Newbery)

Pull request description:

  CheckInputsFromMempoolAndCache() is only called in one place, and
  cacheSigStore is set to true in that call site. Remove the argument
  entirely.

  Also improve commenting.

ACKs for top commit:
  MarcoFalke:
    unsigned ACK 0a433fc876d82df1005f175c1254fff62f0f36f8 Comment looks good
  jamesob:
    ACK 0a433fc876
  laanwj:
    ACK 0a433fc876d82df1005f175c1254fff62f0f36f8
  fanquake:
    ACK 0a433fc876d82df1005f175c1254fff62f0f36f8. Checked that `CheckInputsFromMempoolAndCache` is only called once, in `MemPoolAccept::ConsensusScriptChecks`, and that `cacheSigStore` is true.

Tree-SHA512: e4b4d2550e35df55c8f8fa4c539174cc2d3728112ddb937cb2ff759d8630a01566b5ec42a70a82e33994e6586f5a457a75a59f64b15d27c65331c723cbb097af
2022-05-23 02:23:02 -04:00
..
bench partial bitcoin#19055: Add MuHash3072 implementation 2022-04-27 20:05:13 +05:30
bls refactor: fix numerous compilation warnings (#4682) 2022-02-11 19:15:26 +03:00
coinjoin refactor: implement irange::range and use it (#4788) 2022-04-26 02:40:41 +03:00
compat merge bitcoin#17270: Feed environment data into RNG initializers 2022-04-25 15:29:51 +05:30
config
consensus Merge #17080: consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it 2022-05-23 02:23:02 -04:00
crc32c Merge bitcoin/bitcoin#23133: Update crc32c subtree 2022-03-13 14:52:24 -05:00
crypto Merge bitcoin/bitcoin#23761: build: use __SIZEOF_INT128__ for checking __int128 availability 2022-04-28 10:59:05 -05:00
evo trivial/lint: tweak lint-spelling.sh and fix typos (#4802) 2022-04-25 22:13:24 +03:00
governance merge bitcoin#17997: Remove mempool global from net 2022-04-20 00:25:14 +05:30
index merge bitcoin#19295: Use AbortError in FatalError 2022-04-07 11:28:43 -05:00
interfaces Merge pull request #4731 from vijaydasmp/bp2001 2022-04-20 14:08:24 -05:00
leveldb build: enable experimental Cxx20 support (#4600) 2021-12-12 01:14:17 +03:00
llmq Correct returned variable (#4809) 2022-04-26 20:23:52 +03:00
logging
masternode merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
node merge bitcoin#19145: Add hash_type MUHASH for gettxoutsetinfo 2022-04-27 20:05:13 +05:30
policy partial bitcoin#15639: Drop libbitcoin_server.a dependency 2022-04-20 00:20:30 +05:30
primitives Compressed headers implementation. (#4497) 2022-03-11 22:39:12 +03:00
qt Merge pull request #4817 from UdjinM6/drop_0 2022-04-28 18:40:08 +03:00
rpc Merge #15492: [rpc] remove deprecated generate method 2022-05-01 20:52:10 +03:00
script Merge #9572: Skip witness sighash cache for non-segwit transactions (#4814) 2022-04-28 20:56:40 +03:00
secp256k1
support Merge #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7) 2022-03-04 23:38:33 -05:00
test Merge #17080: consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it 2022-05-23 02:23:02 -04:00
univalue merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
util trivial: bump immer to 9cb6a5a, fix irange to work on c++20 (#4827) 2022-05-09 09:49:33 -05:00
wallet Merge #15492: [rpc] remove deprecated generate method 2022-05-01 20:52:10 +03:00
zmq refactor: introduce CSigBase which becomes the base class for CRecoveredSig, CSigShare and CSigSesAnn (#4776) 2022-04-20 21:17:57 +03:00
.clang-format Merge #17134: doc: Add switch on enum example to developer notes 2022-04-02 09:19:20 +05:30
addrdb.cpp Merge #21222: log: Clarify log message when file does not exist 2021-09-18 21:41:47 -04:00
addrdb.h Merge #17297: refactor: Remove addrdb.h dependency from node.h 2022-03-07 09:36:17 -06:00
addressindex.h
addrman.cpp merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
addrman.h Merge bitcoin/bitcoin#22455: addrman: detect on-disk corrupted nNew and nTried during unserialization 2022-03-07 09:42:58 -06:00
amount.h
arith_uint256.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
arith_uint256.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
attributes.h
banman.cpp merge bitcoin#16362: Add bilingual_str type 2022-04-06 00:08:01 +05:30
banman.h merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
base58.cpp
base58.h
batchedlogger.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
batchedlogger.h
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp Implement PKCS5_PBKDF2_HMAC_SHA512 (#4665) 2022-01-24 17:21:38 +03:00
bip39.h
blockencodings.cpp
blockencodings.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
blockfilter.cpp Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter 2021-10-13 23:44:38 -05:00
blockfilter.h Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter 2021-10-13 23:44:38 -05:00
bloom.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
bloom.h
cachemap.h refactor: Fix warnings from cppcheck (#4625) 2021-12-29 00:54:50 +03:00
cachemultimap.h refactor: replace instances of typedef with using in dash code (#4488) 2021-10-06 00:26:29 +03:00
chain.cpp Merge #15670: refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight 2021-12-26 22:23:01 -05:00
chain.h Merge #15670: refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight 2021-12-26 22:23:01 -05:00
chainparams.cpp Merge pull request #4731 from vijaydasmp/bp2001 2022-04-20 14:08:24 -05:00
chainparams.h Merge #17285: doc: Bip70 removal follow-up 2022-04-27 21:08:36 +03:00
chainparamsbase.cpp feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
chainparamsbase.h Merge #17285: doc: Bip70 removal follow-up 2022-04-27 21:08:36 +03:00
chainparamsseeds.h
checkqueue.h Merge bitcoin/bitcoin#23397: Avoid excessive lock contention in CCheckQueue::Add 2022-04-11 09:41:11 -07:00
clientversion.cpp Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
clientversion.h Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
coins.cpp merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp 2021-10-22 08:15:38 +05:30
coins.h merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp 2021-10-22 08:15:38 +05:30
compat.h Merge #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7) 2022-03-04 23:38:33 -05:00
compressor.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
compressor.h Merge #17917: tests: Add amount compression/decompression fuzzing to existing fuzzing harness 2022-03-07 09:40:31 -06:00
core_io.h
core_memusage.h
core_read.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
core_write.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
ctpl_stl.h Fix get_future data race in ctpl (#4690) 2022-02-15 19:28:29 +03:00
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-cli.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
dash-tx-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-tx.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
dash-wallet-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-wallet.cpp merge bitcoin#16362: Add bilingual_str type 2022-04-06 00:08:01 +05:30
dashd-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dashd.cpp merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
dbwrapper.cpp
dbwrapper.h refactor: Fix warnings from cppcheck (#4625) 2021-12-29 00:54:50 +03:00
dsnotificationinterface.cpp Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
dsnotificationinterface.h Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
dummywallet.cpp merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
flat-database.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
flatfile.cpp
flatfile.h
fs.cpp Merge pull request #4735 from kittywhiskers/translation 2022-04-07 13:18:29 +03:00
fs.h
hash.cpp merge bitcoin#19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 2022-04-27 19:58:39 +05:30
hash.h merge bitcoin#19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 2022-04-27 19:58:39 +05:30
hdchain.cpp wallet: fix metadata updates on HD derivation (#4819) 2022-04-30 23:33:45 +03:00
hdchain.h Merge #14021: Import key origin data through descriptors in importmulti (+ changes from PRs partially merged earlier: 15368, 15749) 2022-02-18 03:42:05 +03:00
httprpc.cpp Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
httprpc.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
httpserver.cpp Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
httpserver.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
indirectmap.h merge bitcoin#17996: Add fuzzing harness for serialization/deserialization of floating-points and integrals 2022-03-25 00:58:20 +05:30
init.cpp merge bitcoin#19328: Add gettxoutsetinfo hash_type option 2022-04-27 19:23:36 +05:30
init.h merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
key_io.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
key_io.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
key.cpp Merge bitcoin/bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization 2022-03-13 14:52:53 -05:00
key.h Merge bitcoin/bitcoin#22995: doc: Remove stale comment for CPrivKey 2022-03-13 14:52:24 -05:00
keystore.cpp merge bitcoin#16753: extract PubKey from P2PK script with Solver 2021-12-22 19:43:18 +05:30
keystore.h
limitedmap.h
logging.cpp merge bitcoin#16540: Add ASSERT_DEBUG_LOG to unit test framework 2022-02-26 10:37:36 +05:30
logging.h merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
Makefile.am merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
Makefile.bench.include merge bitcoin#17265: Remove OpenSSL 2022-04-25 15:29:52 +05:30
Makefile.crc32c.include Merge #20603: build: Update crc32c subtree 2021-09-24 13:26:41 -04:00
Makefile.leveldb.include Merge bitcoin/bitcoin#23282: build: remove build stubs for external leveldb 2022-04-03 18:46:47 -05:00
Makefile.qt_locale.include Merge #16982: build: Factor out qt translations from build system 2021-12-22 20:13:18 -05:00
Makefile.qt.include partial bitcoin#21694: Use XLIFF file to provide more context to Transifex translators 2022-04-26 20:36:54 +05:30
Makefile.qttest.include merge bitcoin#17265: Remove OpenSSL 2022-04-25 15:29:52 +05:30
Makefile.test_util.include merge bitcoin#17542: Create test utility library from src/test/util 2022-02-26 10:45:13 +05:30
Makefile.test.include merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
Makefile.univalue.include merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
mapport.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
mapport.h merge bitcoin#18077: Add NAT-PMP port forwarding support 2022-02-26 17:49:13 +05:30
memusage.h merge bitcoin#17996: Add fuzzing harness for serialization/deserialization of floating-points and integrals 2022-03-25 00:58:20 +05:30
merkleblock.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
merkleblock.h
messagesigner.cpp merge bitcoin#15638: Pull wallet code out of libbitcoin_server (#4560) 2021-11-16 10:19:47 -05:00
messagesigner.h
miner.cpp Merge bitcoin/bitcoin#23692: mining, refactor: add m_mempool.cs thread safety lock assertions 2022-04-20 09:04:29 -05:00
miner.h merge bitcoin#17781: Remove mempool global from miner 2022-04-20 00:25:14 +05:30
net_permissions.cpp Merge bitcoin/bitcoin#21996: p2p: pass strings to NetPermissions::TryParse functions by const ref 2022-04-16 10:47:42 -06:00
net_permissions.h Merge bitcoin/bitcoin#21996: p2p: pass strings to NetPermissions::TryParse functions by const ref 2022-04-16 10:47:42 -06:00
net_processing.cpp merge bitcoin#17997: Remove mempool global from net 2022-04-20 00:25:14 +05:30
net_processing.h merge bitcoin#17997: Remove mempool global from net 2022-04-20 00:25:14 +05:30
net_types.h Merge #17297: refactor: Remove addrdb.h dependency from node.h 2022-03-07 09:36:17 -06:00
net.cpp Merge #17251: net: SocketHandler logs peer id for close and disconnect 2022-04-15 13:08:29 +05:30
net.h merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
netaddress.cpp merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
netaddress.h merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
netbase.cpp Merge #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7) 2022-03-04 23:38:33 -05:00
netbase.h merge bitcoin#16566: refactor upper/lowercase functions 2021-11-01 21:41:35 +05:30
netfulfilledman.cpp refactor: Fix warnings from cppcheck (#4625) 2021-12-29 00:54:50 +03:00
netfulfilledman.h refactor: Fix warnings from cppcheck (#4625) 2021-12-29 00:54:50 +03:00
netmessagemaker.h
noui.cpp merge bitcoin#18927: Pass bilingual_str argument to AbortNode() 2022-04-07 11:28:43 -05:00
noui.h Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
optional.h Merge #15292: Remove 'boost::optional'-related false positive -Wmaybe-uninitialized warnings on GCC compiler (#4635) 2021-12-22 12:59:27 +03:00
pow.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
pow.h
prevector.h refactor: fix numerous compilation warnings (#4682) 2022-02-11 19:15:26 +03:00
protocol.cpp feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
protocol.h feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
psbt.cpp Merge #15408: Remove unused TransactionError constants 2021-09-30 16:18:49 -07:00
psbt.h Merge pull request #4746 from vijaydasmp/bp2004 2022-04-07 13:17:34 +03:00
pubkey.cpp Merge bitcoin/bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization 2022-03-13 14:52:53 -05:00
pubkey.h
random.cpp Merge #18359: build: fix sysctl() detection on macOS 2022-04-25 14:02:48 -05:00
random.h Merge #17507: random: mark RandAddPeriodic and SeedPeriodic as noexcept 2022-04-25 14:02:43 -05:00
randomenv.cpp Merge #20358: src/randomenv.cpp: fix build on uclibc 2022-04-25 14:02:48 -05:00
randomenv.h merge bitcoin#17270: Feed environment data into RNG initializers 2022-04-25 15:29:51 +05:30
rest.cpp partial bitcoin#16240: JSONRPCRequest-aware RPCHelpMan 2022-03-12 19:14:59 +05:30
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp merge bitcoin#17270: Feed environment data into RNG initializers 2022-04-25 15:29:51 +05:30
scheduler.h merge bitcoin#18037: Allow scheduler to be mocked 2022-04-20 00:23:32 +05:30
serialize.h Merge #13719: Avoid creating a temporary vector for size-prefixed elements 2022-04-26 13:27:11 -04:00
shutdown.cpp
shutdown.h
span.h Merge #19367: doc: Span pitfalls 2022-04-03 18:09:07 -05:00
spentindex.h
spork.cpp merge bitcoin#17997: Remove mempool global from net 2022-04-20 00:25:14 +05:30
spork.h scripted-diff: Merge #18533 Replace strCommand with msg_type (#4761) 2022-04-18 11:47:26 -05:00
stacktraces.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
stacktraces.h
statsd_client.cpp refactor: Fix warnings from cppcheck (#4625) 2021-12-29 00:54:50 +03:00
statsd_client.h refactor: Fix warnings from cppcheck (#4625) 2021-12-29 00:54:50 +03:00
streams.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
sync.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
sync.h merge bitcoin#19340: Preserve the LockData initial state if "potential deadlock detected" exception thrown 2021-10-12 19:48:19 -04:00
threadinterrupt.cpp
threadinterrupt.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
threadsafety.h Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
timedata.cpp Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
timedata.h
tinyformat.h Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
torcontrol.cpp Merge #16186: doc/lint: Fix spelling errors identified by codespell 1.15.0 2021-10-05 20:34:00 +03:00
torcontrol.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
txdb.cpp merge bitcoin#16362: Add bilingual_str type 2022-04-06 00:08:01 +05:30
txdb.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
txmempool.cpp Merge #17316: refactor: Replace all uses of boost::optional with our own Optional type 2022-04-07 07:22:08 +05:30
txmempool.h Merge #17316: refactor: Replace all uses of boost::optional with our own Optional type 2022-04-07 07:22:08 +05:30
ui_interface.cpp Merge #19256: gui: change combiner for signals to optional_last_value 2022-04-16 10:47:00 -06:00
ui_interface.h Merge #19309: refactor: Fix link error with --enable-debug 2022-04-16 10:46:58 -06:00
uint256.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
uint256.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
undo.h
unordered_lru_cache.h
validation.cpp Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache 2022-05-23 02:23:02 -04:00
validation.h Merge #15383: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx 2022-02-27 13:33:36 -05:00
validationinterface.cpp Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
validationinterface.h Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
version.h feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
versionbits.cpp Merge #16587: doc: Improve versionbits.h documentation 2021-11-16 07:13:48 +05:30
versionbits.h Merge #16587: doc: Improve versionbits.h documentation 2021-11-16 07:13:48 +05:30
versionbitsinfo.cpp feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
versionbitsinfo.h
walletinitinterface.h merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
warnings.cpp merge bitcoin#16362: Add bilingual_str type 2022-04-06 00:08:01 +05:30
warnings.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00