mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
c516869bcf
0d101a340c44841cbbc5982d55354b1787bc39e2 test: Add test for maxtxfee option (MarcoFalke) 177550101b600ccb32886695326eb72cd9752c8b wallet: Remove unreachable code in CreateTransaction (MarcoFalke) 5c1b9714cb0a13be28324f91f4ec9ca66a1de8c7 wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (João Barbosa) Pull request description: Follow up to #16257, this PR makes `bumpfee` aware of `-maxtxfee`. It also prevents dangling locked unspents when calling `fundrawtransaction` - because the previous check was after `LockCoin`. ACKs for top commit: MarcoFalke: re-ACK 0d101a340c44841cbbc5982d55354b1787bc39e2, only change is small test fixup Tree-SHA512: 3464b24ae7cd4e72ed41438c6661828ba1304af020f05da62720b23668ae734e16cf47c6d97e150cc84ef631ee099b16fc786c858f3d089905845437338fd512
76 lines
3.0 KiB
Python
Executable File
76 lines
3.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
|
|
class CreateTxWalletTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = False
|
|
self.num_nodes = 1
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
self.test_anti_fee_sniping()
|
|
self.test_tx_size_too_large()
|
|
|
|
def test_anti_fee_sniping(self):
|
|
self.log.info('Check that we have some (old) blocks and that anti-fee-sniping is disabled')
|
|
self.bump_mocktime(8 * 60 * 60 + 1)
|
|
assert_equal(self.nodes[0].getblockchaininfo()['blocks'], 200)
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1)
|
|
tx = self.nodes[0].decoderawtransaction(self.nodes[0].gettransaction(txid)['hex'])
|
|
assert_equal(tx['locktime'], 0)
|
|
|
|
self.log.info('Check that anti-fee-sniping is enabled when we mine a recent block')
|
|
self.nodes[0].generate(1)
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1)
|
|
tx = self.nodes[0].decoderawtransaction(self.nodes[0].gettransaction(txid)['hex'])
|
|
assert 0 < tx['locktime'] <= 201
|
|
|
|
def test_tx_size_too_large(self):
|
|
# More than 10kB of outputs, so that we hit -maxtxfee with a high feerate
|
|
outputs = {self.nodes[0].getnewaddress(): 0.000025 for i in range(400)}
|
|
raw_tx = self.nodes[0].createrawtransaction(inputs=[], outputs=outputs)
|
|
|
|
for fee_setting in ['-minrelaytxfee=0.01', '-mintxfee=0.01', '-paytxfee=0.01']:
|
|
self.log.info('Check maxtxfee in combination with {}'.format(fee_setting))
|
|
self.restart_node(0, extra_args=[fee_setting])
|
|
assert_raises_rpc_error(
|
|
-6,
|
|
"Fee exceeds maximum configured by -maxtxfee",
|
|
lambda: self.nodes[0].sendmany(dummy="", amounts=outputs),
|
|
)
|
|
assert_raises_rpc_error(
|
|
-4,
|
|
"Fee exceeds maximum configured by -maxtxfee",
|
|
lambda: self.nodes[0].fundrawtransaction(hexstring=raw_tx),
|
|
)
|
|
|
|
self.log.info('Check maxtxfee in combination with settxfee')
|
|
self.restart_node(0)
|
|
self.nodes[0].settxfee(0.01)
|
|
assert_raises_rpc_error(
|
|
-6,
|
|
"Fee exceeds maximum configured by -maxtxfee",
|
|
lambda: self.nodes[0].sendmany(dummy="", amounts=outputs),
|
|
)
|
|
assert_raises_rpc_error(
|
|
-4,
|
|
"Fee exceeds maximum configured by -maxtxfee",
|
|
lambda: self.nodes[0].fundrawtransaction(hexstring=raw_tx),
|
|
)
|
|
self.nodes[0].settxfee(0)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
CreateTxWalletTest().main()
|