dash/src
fanquake 106ca023a0 Merge #19630: Cleanup fee estimation code
a3abeec33a6ae903e514c7a7b6f587b7c17288a0 policy/fees: remove a floating-point division by zero (Antoine Poinsot)
c36869bbf6a38626833b4aea53be024c48ede475 policy/fees: unify some duplicated for loops (Antoine Poinsot)
569d92a4d2924a1f6d50775980b591552f6372e7 policy/fees: small readability improvements (Antoine Poinsot)
5b8cb35621891b681f9b49a9de5f6d8da4ccdecc policy/fee: remove requireGreater parameter in EstimateMedianVal() (Antoine Poinsot)
dba8196b447b6a85be66890db70928100e867d8b policy/fees: correct decay explanation comments (Antoine Poinsot)

Pull request description:

  This (*does not* change behaviour and) cleans up a bit of unused code in `CBlockPolicyEstimator` and friends, and slightly improves readability of the rest (comment correction etc.). The last commit is a small reformatting one which I could not resist but am happy to remove at will.

ACKs for top commit:
  jnewbery:
    utACK a3abeec33a6ae903e514c7a7b6f587b7c17288a0
  MarcoFalke:
    ACK a3abeec33a6ae903e514c7a7b6f587b7c17288a0 💹
  ariard:
    Code Review ACK a3abeec.

Tree-SHA512: b7620bcd23a2ffa8f7ed859467868fc0f6488279e3ee634f6d408872cb866ad086a037e8ace76599a05b7e9c07768adf5016b0ae782d153196b9c030db4c34a5
2023-01-01 20:16:57 -06:00
..
bench refactor: create context for LLMQ subsystem within NodeContext, alias entangled globals (#5030) 2022-11-07 21:09:44 +03:00
bls feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
coinjoin feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
compat revert dash#1432: Rename consensus source library and API 2022-08-09 14:16:28 +05:30
config
consensus Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp} 2023-01-01 20:16:57 -06:00
crc32c
crypto partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
dashbls build/depends: commit dashpay/bls-signatures@66ee820f to source tree as vendored (#5077) 2022-11-22 11:34:46 -06:00
evo feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
governance feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
immer build: commit arximboldi/immer@9cb6a5a8 to source tree as 46b560d5 2022-11-23 10:12:10 +05:30
index merge bitcoin#21404: Remove MakeUnique<T>() 2022-10-20 16:08:45 -05:00
interfaces revert: revert bitcoin#15454 (Remove the automatic creation and loading of the default wallet) 2022-12-04 18:02:40 -06:00
leveldb Merge bitcoin/bitcoin#25739: Update leveldb subtree (#5005) 2022-09-23 18:43:39 +04:00
llmq feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
logging
masternode merge bitcoin#20788: add RAII socket and use it instead of bare SOCKET 2022-11-01 00:28:53 -05:00
node refactor: remove the g_evoDb global; use NodeContext and locals (#5058) 2022-12-10 11:58:17 -06:00
policy Merge #19630: Cleanup fee estimation code 2023-01-01 20:16:57 -06:00
primitives fix(build): Fix incorrect type conversion (#5037) 2022-10-17 11:31:27 -05:00
qt revert: revert bitcoin#15454 (Remove the automatic creation and loading of the default wallet) 2022-12-04 18:02:40 -06:00
rpc Merge #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help 2023-01-01 20:16:57 -06:00
script merge bitcoin#16251: Improve signrawtransaction error reporting 2022-11-01 00:28:53 -05:00
secp256k1
support partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
test Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp} 2023-01-01 20:16:57 -06:00
univalue merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
util merge bitcoin#20429: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size 2022-11-01 00:28:53 -05:00
wallet revert: revert bitcoin#20186 (Make -wallet setting not create wallets) 2022-12-04 18:02:40 -06:00
zmq merge bitcoin#21404: Remove MakeUnique<T>() 2022-10-20 16:08:45 -05:00
.clang-format
addrdb.cpp merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
addrdb.h merge bitcoin#19219: Replace automatic bans with discouragement filter 2022-06-21 19:11:49 +05:30
addressindex.h Merge #16908: txmempool: Make entry time type-safe (std::chrono) 2022-10-03 16:08:31 -04:00
addrman.cpp
addrman.h
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp merge bitcoin#19219: Replace automatic bans with discouragement filter 2022-06-21 19:11:49 +05:30
banman.h merge bitcoin#19219: Replace automatic bans with discouragement filter 2022-06-21 19:11:49 +05:30
base58.cpp merge bitcoin#20429: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size 2022-11-01 00:28:53 -05:00
base58.h Merge #17511: Add bounds checks before base58 decoding 2022-06-08 12:33:00 +07:00
batchedlogger.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
batchedlogger.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp
bip39.h
bitcoin-cli.cpp merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
bitcoin-tx.cpp trivial: revert dashification of source and header filenames 2022-08-09 14:16:29 +05:30
bitcoin-wallet.cpp trivial: revert dashification of source and header filenames 2022-08-09 14:16:29 +05:30
bitcoind.cpp refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
blockencodings.cpp merge bitcoin#15141: Rewrite DoS interface between validation and net_processing 2022-06-21 19:11:26 +05:30
blockencodings.h
blockfilter.cpp merge bitcoin#18190: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode) 2022-07-15 21:24:21 +05:30
blockfilter.h
bloom.cpp refactor(llmq): substitute memberless class llmq::CLLMQUtils with namespace llmq::utils (#4931) 2022-08-02 12:14:25 -05:00
bloom.h
cachemap.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
cachemultimap.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
chain.cpp
chain.h
chainparams.cpp chore: update assumevalid for v18.2.0 (#5128) 2023-01-01 16:02:19 -06:00
chainparams.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
chainparamsbase.cpp merge bitcoin#21404: Remove MakeUnique<T>() 2022-10-20 16:08:45 -05:00
chainparamsbase.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
chainparamsseeds.h Update hard coded seeds for v18.0.0-rc12 (#4953) 2022-08-11 01:57:13 +03:00
checkqueue.h
clientversion.cpp Merge bitcoin/bitcoin#22685: clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE 2022-05-11 11:03:39 -05:00
clientversion.h partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
coins.cpp Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
coins.h merge bitcoin#18637: allow cache resize after init 2022-05-23 10:39:43 +05:30
compat.h partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
compressor.cpp
compressor.h
context.h refactor: create context for LLMQ subsystem within NodeContext, alias entangled globals (#5030) 2022-11-07 21:09:44 +03:00
core_io.h merge bitcoin#15508: Refactor analyzepsbt for use outside RPC code 2022-09-24 08:51:04 +05:30
core_memusage.h
core_read.cpp merge bitcoin#18416: Limit decimal range of numbers ParseScript accepts 2022-11-01 00:28:53 -05:00
core_write.cpp Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
ctpl_stl.h refactor/chore: update cppcheck to 2.8 with needed refactoring (#4926) 2022-08-11 02:05:44 +03:00
cuckoocache.h Merge #17634: qt: Fix comparison function signature 2022-06-16 01:34:38 -04:00
cxxtimer.hpp test/refactor: upgrade to cppcheck 2.9 and fix warnings (#5049) 2022-10-18 13:24:00 +03:00
dash-cli-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-tx-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-wallet-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dashd-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dbwrapper.cpp
dbwrapper.h Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
dsnotificationinterface.cpp refactor: create context for LLMQ subsystem within NodeContext, alias entangled globals (#5030) 2022-11-07 21:09:44 +03:00
dsnotificationinterface.h refactor: create context for LLMQ subsystem within NodeContext, alias entangled globals (#5030) 2022-11-07 21:09:44 +03:00
dummywallet.cpp merge #19099: refactor: Move wallet methods out of chain.h and node.h 2022-06-21 19:08:57 +05:30
flat-database.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
flatfile.cpp
flatfile.h
fs.cpp
fs.h
hash.cpp merge bitcoin#19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 2022-04-27 19:58:39 +05:30
hash.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
hdchain.cpp fix: Pass KeyOriginInfo instead of CKeyMetadata to DeriveChildExtKey (#4918) 2022-07-18 16:56:33 +03:00
hdchain.h refactor/chore: update cppcheck to 2.8 with needed refactoring (#4926) 2022-08-11 02:05:44 +03:00
httprpc.cpp refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
httprpc.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
httpserver.cpp merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
httpserver.h merge bitcoin#18363: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions 2022-07-15 21:24:21 +05:30
indirectmap.h
init.cpp feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
init.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
key_io.cpp merge bitcoin#20480: Replace boost::variant with std::variant 2022-10-20 16:08:45 -05:00
key_io.h
key.cpp merge bitcoin#19379: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) 2022-08-21 18:09:28 +05:30
key.h
limitedmap.h
logging.cpp
logging.h
Makefile.am build: restore support for building immer from local subtree 2022-12-01 00:51:07 +05:30
Makefile.bench.include build/depends: commit dashpay/bls-signatures@66ee820f to source tree as vendored (#5077) 2022-11-22 11:34:46 -06:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include build/depends: commit dashpay/bls-signatures@66ee820f to source tree as vendored (#5077) 2022-11-22 11:34:46 -06:00
Makefile.qttest.include build/depends: commit dashpay/bls-signatures@66ee820f to source tree as vendored (#5077) 2022-11-22 11:34:46 -06:00
Makefile.test_fuzz.include merge bitcoin#18528: create test_fuzz library from src/test/fuzz/fuzz.cpp 2022-10-02 12:05:13 +05:30
Makefile.test_util.include merge bitcoin#18521: Add process_messages harness 2022-07-06 22:13:37 +05:30
Makefile.test.include build/depends: commit dashpay/bls-signatures@66ee820f to source tree as vendored (#5077) 2022-11-22 11:34:46 -06:00
Makefile.univalue.include merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
mapport.cpp partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
messagesigner.cpp merge bitcoin#17577: deduplicate the message sign/verify code 2022-09-24 08:51:05 +05:30
messagesigner.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
miner.cpp refactor: remove the g_evoDb global; use NodeContext and locals (#5058) 2022-12-10 11:58:17 -06:00
miner.h refactor: remove the g_evoDb global; use NodeContext and locals (#5058) 2022-12-10 11:58:17 -06:00
net_permissions.cpp Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests. 2022-10-03 16:08:31 -04:00
net_permissions.h Merge #17985: net: Remove forcerelay of rejected txs 2022-10-20 11:48:21 -04:00
net_processing.cpp feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
net_processing.h merge bitcoin#15437: Remove BIP61 reject messages 2022-12-02 15:43:01 +05:30
net_types.h
net.cpp merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
net.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
netaddress.cpp merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
netaddress.h merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
netbase.cpp merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
netbase.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
netfulfilledman.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
netfulfilledman.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
netmessagemaker.h
noui.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
noui.h
pow.cpp
pow.h
prevector.h Merge #17634: qt: Fix comparison function signature 2022-06-16 01:34:38 -04:00
protocol.cpp merge bitcoin#15437: Remove BIP61 reject messages 2022-12-02 15:43:01 +05:30
protocol.h merge bitcoin#15437: Remove BIP61 reject messages 2022-12-02 15:43:01 +05:30
psbt.cpp merge bitcoin#15938: silence GCC 7 warning "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp 2022-09-24 08:51:05 +05:30
psbt.h merge bitcoin#21415: remove Optional & nullopt 2022-10-20 16:08:45 -05:00
pubkey.cpp merge bitcoin#19379: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) 2022-08-21 18:09:28 +05:30
pubkey.h
random.cpp merge bitcoin#20429: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size 2022-11-01 00:28:53 -05:00
random.h merge bitcoin#18455: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h 2022-07-06 22:13:37 +05:30
randomenv.cpp merge bitcoin#20602: Allow use of C++14 chrono literals 2022-10-20 16:08:45 -05:00
randomenv.h
rest.cpp refactor: create context for LLMQ subsystem within NodeContext, alias entangled globals (#5030) 2022-11-07 21:09:44 +03:00
reverse_iterator.h
saltedhasher.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
saltedhasher.h fix!: Fix on QuorumDataRequests and refactoring (#4937) 2022-07-26 15:31:03 -05:00
scheduler.cpp
scheduler.h
serialize.h merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
shutdown.cpp
shutdown.h
span.h
spentindex.h
spork.cpp refactor: change Process* functions from accepting a ptr to a reference (#5062) 2022-10-28 22:50:54 +03:00
spork.h refactor: change Process* functions from accepting a ptr to a reference (#5062) 2022-10-28 22:50:54 +03:00
stacktraces.cpp Merge pull request #4478 from kittywhiskers/undashify 2022-08-11 12:34:55 -04:00
stacktraces.h
statsd_client.cpp refactor: resolve implicit-const-int-float-conversion warning in statsd_client 2022-10-21 21:51:35 +05:30
statsd_client.h test/refactor: upgrade to cppcheck 2.9 and fix warnings (#5049) 2022-10-18 13:24:00 +03:00
streams.h Merge #19593: refactor: Drop unused CBufferedFile::Seek() 2022-09-03 10:43:14 -05:00
sync.cpp partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
sync.h Merge #16034: refactoring: Rename LockAnnotation to LockAssertion and add run-time check to it 2022-05-17 12:57:47 -04:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h Merge #16034: refactoring: Rename LockAnnotation to LockAssertion and add run-time check to it 2022-05-17 12:57:47 -04:00
timedata.cpp partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
timedata.h
tinyformat.h
torcontrol.cpp merge bitcoin#20788: add RAII socket and use it instead of bare SOCKET 2022-11-01 00:28:53 -05:00
torcontrol.h
txdb.cpp merge bitcoin#21404: Remove MakeUnique<T>() 2022-10-20 16:08:45 -05:00
txdb.h merge bitcoin#18637: allow cache resize after init 2022-05-23 10:39:43 +05:30
txmempool.cpp merge bitcoin#21415: remove Optional & nullopt 2022-10-20 16:08:45 -05:00
txmempool.h merge bitcoin#21415: remove Optional & nullopt 2022-10-20 16:08:45 -05:00
ui_interface.cpp merge bitcoin#16963: Fix unique_ptr usage in boost::signals2 2022-05-13 18:06:06 +05:30
ui_interface.h merge bitcoin#16963: Fix unique_ptr usage in boost::signals2 2022-05-13 18:06:06 +05:30
uint256.cpp merge bitcoin#20016: 1 is a constant 2022-07-02 23:47:42 +05:30
uint256.h merge bitcoin#20016: 1 is a constant 2022-07-02 23:47:42 +05:30
undo.h
unordered_lru_cache.h
validation.cpp Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp} 2023-01-01 20:16:57 -06:00
validation.h refactor: remove the g_evoDb global; use NodeContext and locals (#5058) 2022-12-10 11:58:17 -06:00
validationinterface.cpp merge bitcoin#18338: Fix wallet unload race condition 2022-06-03 18:25:34 +05:30
validationinterface.h merge bitcoin#18338: Fix wallet unload race condition 2022-06-03 18:25:34 +05:30
version.h feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
versionbits.cpp fix: speed up GetStateFor (#5100) 2022-12-13 11:42:52 -06:00
versionbits.h
versionbitsinfo.cpp feat!: v19 BIP9 fork (#5070) 2022-11-22 11:34:21 -06:00
versionbitsinfo.h
walletinitinterface.h merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
warnings.cpp Merge #17750: util: change GetWarnings parameter to bool 2022-06-14 16:48:15 +07:00
warnings.h Merge #17750: util: change GetWarnings parameter to bool 2022-06-14 16:48:15 +07:00