dash/src/wallet
Vijay Manikpuri 3148450032
Merge #16129: refactor: Remove unused includes (#4623)
67f4e9c522 Include core_io.h from core_read.cpp (practicalswift)
eca9767673 Make reasoning about dependencies easier by not including unused dependencies (practicalswift)

Pull request description:

  Make reasoning about dependencies easier by not including unused dependencies.

  Please note that the removed headers are _not_ "transitively included" by other still included headers. Thus the removals are real.

  As an added bonus this change means less work for the preprocessor/compiler. At least 51 393 lines of code no longer needs to be processed:

  ```
  $ git diff -u HEAD~1 | grep -E '^\-#include ' | cut -f2 -d"<" | cut -f1 -d">" | \
        sed 's%^%src/%g' | xargs cat | wc -l
  51393
  ```

  Note that 51 393 is the lower bound: the real number is likely much higher when taking into account transitively included headers :-)

ACKs for commit 67f4e9:

Tree-SHA512: 0c8868aac59813f099ce53d5307eed7962dd6f2ff3546768ef9e5c4508b87f8210f1a22c7e826c3c06bebbf28bdbfcf1628ed354c2d0fdb9a31a42cefb8fdf13

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
2022-01-03 13:10:02 -06:00
..
test Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
coincontrol.cpp
coincontrol.h Merge #15557: Enhance bumpfee to include inputs when targeting a feerate 2021-12-26 22:23:01 -05:00
coinselection.cpp
coinselection.h
crypter.cpp Merge #15226: Allow creating blank (empty) wallets (alternative) 2021-12-17 21:11:10 +03:00
crypter.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
db.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
db.h Merge pull request #4619 from PastaPastaPasta/remove-includes 2021-12-17 20:21:12 +03:00
fees.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
fees.h merge bitcoin#15288: Remove wallet -> node global function calls 2021-11-14 15:32:37 +05:30
init.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
load.cpp merge bitcoin#15632: Remove ResendWalletTransactions from the Validation Interface 2021-12-12 21:27:51 +05:30
load.h merge bitcoin#16796: Fix segfault in CreateWalletFromFile 2021-12-12 18:57:02 +05:30
psbtwallet.cpp
psbtwallet.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
rpcdump.cpp Merge pull request #4636 from PastaPastaPasta/develop-trivial-2021-12-21 2021-12-29 00:44:05 +03:00
rpcwallet.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
rpcwallet.h merge bitcoin#10973: separate wallet from node 2021-11-14 15:32:50 +05:30
wallet.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
wallet.h merge bitcoin#16208: Consume ReserveDestination on successful CreateTransaction 2021-12-22 19:43:18 +05:30
walletdb.cpp merge bitcoin#16502: Drop unused OldKey 2021-12-12 22:36:50 +05:30
walletdb.h merge bitcoin#15741: Batch write imported stuff in importmulti 2021-12-22 19:43:18 +05:30
wallettool.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
wallettool.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
walletutil.cpp
walletutil.h