sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
330c5f9451
dash/src
History
UdjinM6 330c5f9451 fix: should avoid implicit conversions in pushKV params (#5719) 
## Issue being fixed or feature implemented
Should fix compilation errors like
```
masternode/meta.cpp:43:9: error: call to member function 'pushKV' is ambiguous
    ret.pushKV("lastOutboundAttemptElapsed", now - lastOutboundAttempt);
    ^~
masternode/meta.cpp:45:9: error: call to member function 'pushKV' is ambiguous
    ret.pushKV("lastOutboundSuccessElapsed", now - lastOutboundSuccess);
    ^~
```
on FreeBSD + clang-15

kudos to @MrDefacto for finding the issue and testing the fix


## What was done?
Specify `now` variable type explicitly instead of relying on `auto`


## How Has This Been Tested?
MrDefacto confirmed it compiles with no issues on FreeBSD now

## Breaking Changes
n/a

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
2023-12-04 17:04:59 +02:00
..
bench fix: add cast to void to avoid gcc warning inside string_cast.cpp 2023-11-06 09:15:29 -06:00
bls chore: Post v19 cleanup (#5622) 2023-10-19 11:33:44 -05:00
coinjoin chore: Post v19 cleanup (#5622) 2023-10-19 11:33:44 -05:00
compat partial Merge bitcoin/bitcoin#25233: compat: remove glibcxx sanity checks 2023-11-07 07:44:05 -06:00
config
consensus refactor: make MNActivationHeight in Params() indeed constant (#5658) 2023-11-10 08:31:12 -06:00
crc32c
crypto merge bitcoin#19521: Coinstats Index 2023-08-02 10:19:02 -05:00
dashbls build: stop tracking cmake dependency relic_conf.h.in 2023-06-28 23:44:03 +03:00
evo fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:37:07 -06:00
governance fix: actually vote NO on triggers we don't like, some additional cleanups and tests (#5670) 2023-11-06 23:45:42 +03:00
gsl refactor: add gsl::not_null to get compile time / run time pointer guarantees (#5595) 2023-10-22 09:14:30 -05:00
immer
index Merge bitcoin/bitcoin#25079: index: Change sync variables to use std::chrono::steady_clock 2023-10-31 08:40:25 -05:00
interfaces fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip (#5590) 2023-10-27 19:53:27 -05:00
leveldb
llmq fix: rename SPORK_24_EHF to SPORK_24_TEST_EHF, make sure it has no effect on mainnet (#5691) 2023-11-13 10:03:46 -06:00
logging Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
masternode fix: should avoid implicit conversions in pushKV params (#5719) 2023-12-04 17:04:59 +02:00
node fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip (#5590) 2023-10-27 19:53:27 -05:00
policy Merge #20497: [Refactor] Add MAX_STANDARD_SCRIPTSIG_SIZE to policy 2023-07-26 09:37:53 +05:30
primitives Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
qt ru 2023-11-14 09:08:39 -06:00
rpc refactor: make MNActivationHeight in Params() indeed constant (#5658) 2023-11-10 08:31:12 -06:00
script merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
secp256k1
support merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
test refactor: use more gsl::not_null in utils.h and deterministicmns.h (#5651) 2023-11-10 08:33:21 -06:00
univalue
util Merge bitcoin/bitcoin#25803: refactor: Drop boost/algorithm/string/replace.hpp dependency 2023-10-31 08:40:25 -05:00
wallet fix: FundTransaction should follow the same bip69 rules CreateTransaction does (#5667) 2023-11-03 10:05:37 -05:00
zmq Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
.clang-format
addrdb.cpp merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
addrdb.h merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
addressindex.cpp refactor: consolidate P2PK{H} types to P2PK_OR_P2PKH 2023-09-25 22:57:42 +05:30
addressindex.h refactor: consolidate P2PK{H} types to P2PK_OR_P2PKH 2023-09-25 22:57:42 +05:30
addrman.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
addrman.h Merge bitcoin/bitcoin#19238: refactor: Make CAddrMan::cs non-recursive 2023-08-28 11:24:41 -05:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
banman.h merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
base58.cpp merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
base58.h Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
batchedlogger.cpp
batchedlogger.h
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
bip39.h fix(wallet): truncate mnemonic passphrase instead of crashing 2023-06-12 10:56:10 +03:00
bitcoin-cli.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
bitcoin-tx.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
bitcoin-wallet.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
bitcoind.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
blockencodings.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
blockencodings.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
blockfilter.cpp merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
blockfilter.h
bloom.cpp merge bitcoin#23115: use Span instead of std::vector for insert and contains 2023-09-24 09:50:50 -05:00
bloom.h merge bitcoin#23115: use Span instead of std::vector for insert and contains 2023-09-24 09:50:50 -05:00
cachemap.h
cachemultimap.h
chain.cpp
chain.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
chainparams.cpp fix: enable the mn_rr hard fork in v20 so that a v20.1 in the future may activate mn_rr (#5699) 2023-11-14 09:08:06 -06:00
chainparams.h refactor: make MNActivationHeight in Params() indeed constant (#5658) 2023-11-10 08:31:12 -06:00
chainparamsbase.cpp feat!: reuse nHighSubsidyBlocks as a starting point for a fixed nSubsidyBase value to better mimic mainnet (#5664) 2023-11-07 07:51:23 -06:00
chainparamsbase.h merge bitcoin#19991: Use alternative port for incoming Tor connections 2023-04-17 08:30:49 +00:00
chainparamsseeds.h chore: update mainnet seeds 2023-11-13 10:13:12 -06:00
checkqueue.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
clientversion.cpp
clientversion.h merge bitcoin#21059: Drop boost/preprocessor dependencies 2023-09-04 20:50:27 -05:00
coins.cpp merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
coins.h merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
compat.h Merge #20221: net: compat.h related cleanup 2023-08-01 12:24:36 -05:00
compressor.cpp Merge bitcoin/bitcoin#18847: compressor: use a prevector in CompressScript serialization [ZAP1] 2023-04-14 23:34:13 -05:00
compressor.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
context.h trivial: consistently use context as the argument name for CoreContext 2023-07-28 00:18:27 -05:00
core_io.h
core_memusage.h
core_read.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
core_write.cpp fix: actually show json for assetlock/unlock txes (#5633) 2023-10-23 10:36:50 -05:00
ctpl_stl.h
cuckoocache.h merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
dbwrapper.h merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
dsnotificationinterface.cpp fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:37:07 -06:00
dsnotificationinterface.h fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:37:07 -06:00
dummywallet.cpp refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
flat-database.h merge bitcoin#19326: Simplify hash.h interface using Spans 2023-09-24 09:50:50 -05:00
flatfile.cpp Merge #14501: Fix possible data race when committing block files 2023-08-29 21:40:46 -05:00
flatfile.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
fs.cpp
fs.h
hash.cpp merge bitcoin#23115: use Span instead of std::vector for insert and contains 2023-09-24 09:50:50 -05:00
hash.h merge bitcoin#19326: Simplify hash.h interface using Spans 2023-09-24 09:50:50 -05:00
hdchain.cpp merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
hdchain.h feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
httprpc.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
httprpc.h
httpserver.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
httpserver.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
i2p.cpp merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
i2p.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
indirectmap.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
init.cpp fix: avoid crashes on "corrupted db" reindex attempts (#5717) 2023-12-04 17:03:50 +02:00
init.h partial Merge bitcoin/bitcoin#25233: compat: remove glibcxx sanity checks 2023-11-07 07:44:05 -06:00
key_io.cpp
key_io.h
key.cpp merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
key.h merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
limitedmap.h chore: Drop unused unordered_limitedmap::insert_or_update() 2023-07-17 01:00:48 +03:00
logging.cpp fix: add missing log categories (#5707) 2023-11-16 12:19:20 -06:00
logging.h feat: reduce spamming logs with messages from v20 features (#5669) 2023-11-06 09:26:36 -06:00
Makefile.am partial Merge bitcoin/bitcoin#25233: compat: remove glibcxx sanity checks 2023-11-07 07:44:05 -06:00
Makefile.bench.include Merge #18397: build: Fix libevent linking for bench_bitcoin binary 2023-05-31 12:01:04 -05:00
Makefile.crc32c.include Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove getauxval() weak linking 2023-10-31 08:40:25 -05:00
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include merge bitcoin#17513: Nuke some circular dependencies 2023-04-15 12:12:30 -05:00
Makefile.qttest.include
Makefile.test_fuzz.include merge bitcoin#20995: Avoid initializing version to less than MIN_PEER_PROTO_VERSION 2023-07-24 20:45:49 +03:00
Makefile.test_util.include merge bitcoin#27988: Use same timeout for all index sync 2023-08-02 10:19:02 -05:00
Makefile.test.include merge bitcoin#19055: Add MuHash3072 implementation 2023-08-29 21:55:45 -05:00
Makefile.univalue.include
mapport.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
mapport.h
memusage.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
merkleblock.cpp merge bitcoin#19326: Simplify hash.h interface using Spans 2023-09-24 09:50:50 -05:00
merkleblock.h
messagesigner.cpp
messagesigner.h
miner.cpp feat: reduce spamming logs with messages from v20 features (#5669) 2023-11-06 09:26:36 -06:00
miner.h fix: chain halt if some invalid asset lock transactions are in mempool (#5648) 2023-10-30 09:57:20 -05:00
net_permissions.cpp merge bitcoin#18991: Cache responses to GETADDR to prevent topology leaks 2023-06-05 10:11:03 -05:00
net_permissions.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
net_processing.cpp refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
net_processing.h refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
net_types.h
net.cpp Merge bitcoin/bitcoin#24974: refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono) 2023-10-31 08:40:25 -05:00
net.h fix: a couple of fixes for the way mnauth and probe nodes work (#5660) 2023-11-03 10:34:40 -05:00
netaddress.cpp merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
netaddress.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
netbase.cpp merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netbase.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netfulfilledman.cpp refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
netfulfilledman.h refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
outputtype.h Merge #18034: Get the OutputType for a descriptor 2023-05-24 12:43:57 -05:00
pow.cpp fix: respect fPowNoRetargeting for post-btc algos 2023-06-12 10:56:10 +03:00
pow.h
prevector.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
protocol.cpp merge bitcoin#19020: Use C++11 member initialization in protocol 2023-09-24 09:50:50 -05:00
protocol.h Merge #18996: net: Remove un-actionable TODO 2023-10-23 10:48:39 -05:00
psbt.cpp merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
psbt.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
pubkey.cpp
pubkey.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
random.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
random.h Merge bitcoin/bitcoin#24974: refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono) 2023-10-31 08:40:25 -05:00
randomenv.cpp Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove getauxval() weak linking 2023-10-31 08:40:25 -05:00
randomenv.h
rest.cpp merge bitcoin#21767: Prune g_chainman usage in auxiliary modules 2023-08-02 10:19:02 -05:00
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
scheduler.h Merge bitcoin/bitcoin#24069: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) 2023-05-31 10:52:02 -05:00
serialize.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
shutdown.cpp merge bitcoin#21575: Create blockstorage module 2023-07-28 00:18:27 -05:00
shutdown.h merge bitcoin#21575: Create blockstorage module 2023-07-28 00:18:27 -05:00
source_location.h refactor: add gsl::not_null to get compile time / run time pointer guarantees (#5595) 2023-10-22 09:14:30 -05:00
span.h refactor: further spanification of Dash code (#5586) 2023-10-03 09:52:33 -05:00
spentindex.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
spork.cpp refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
spork.h fix: rename SPORK_24_EHF to SPORK_24_TEST_EHF, make sure it has no effect on mainnet (#5691) 2023-11-13 10:03:46 -06:00
stacktraces.cpp ci: build TSan with clang 15 and add -Werror=thread-safety, fix-up stacktraces (#5375) 2023-05-26 13:49:29 -05:00
stacktraces.h
statsd_client.cpp
statsd_client.h
streams.h merge bitcoin#23451: Add std::byte helpers 2023-09-24 09:50:50 -05:00
sync.cpp Merge #21010: refactor: remove straggling boost::mutex usage 2023-07-25 10:45:09 -05:00
sync.h Merge bitcoin/bitcoin#26189: refactor: Do not discard try_lock() return value 2023-11-07 07:44:05 -06:00
threadinterrupt.cpp Merge bitcoin/bitcoin#24974: refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono) 2023-10-31 08:40:25 -05:00
threadinterrupt.h Merge bitcoin/bitcoin#24974: refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono) 2023-10-31 08:40:25 -05:00
threadsafety.h
timedata.cpp Merge #20141: Avoid the use of abs64 in timedata 2023-05-31 10:52:02 -05:00
timedata.h
timestampindex.h refactor: add missing headers to {address,timestamp}index 2023-09-25 22:57:41 +05:30
tinyformat.h Merge #20530: lint, refactor: Update cppcheck linter to c++17 and improve explicit usage 2023-08-01 12:24:36 -05:00
torcontrol.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
torcontrol.h merge bitcoin#19288: Add fuzzing harness for TorController 2023-08-29 21:55:45 -05:00
txdb.cpp refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
txdb.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
txmempool.cpp Merge bitcoin/bitcoin#23416: doc: Remove fee delta TODO from txmempool.cpp 2023-10-23 10:48:39 -05:00
txmempool.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
ui_interface.cpp fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip (#5590) 2023-10-27 19:53:27 -05:00
ui_interface.h fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip (#5590) 2023-10-27 19:53:27 -05:00
uint256.cpp Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uint256.* 2023-10-30 09:50:10 -05:00
uint256.h refactor: extend changes to uint512 2023-10-30 09:50:10 -05:00
undo.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
unordered_lru_cache.h fix: off-by-1 in unordered_lru_cache 2023-06-12 10:56:10 +03:00
validation.cpp fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:37:07 -06:00
validation.h fix: chain halt if some invalid asset lock transactions are in mempool (#5648) 2023-10-30 09:57:20 -05:00
validationinterface.cpp fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:37:07 -06:00
validationinterface.h fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:37:07 -06:00
version.h chore: Post v19 cleanup (#5622) 2023-10-19 11:33:44 -05:00
versionbits.cpp refactor: make MNActivationHeight in Params() indeed constant (#5658) 2023-11-10 08:31:12 -06:00
versionbits.h refactor: make MNActivationHeight in Params() indeed constant (#5658) 2023-11-10 08:31:12 -06:00
versionbitsinfo.cpp feat: v20 evonodes payment adjustment (#5493) 2023-07-31 23:52:48 -05:00
versionbitsinfo.h refactor: cleanup CChainParams unused data and functions (#5474) 2023-07-04 12:25:36 -05:00
walletinitinterface.h refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
warnings.cpp
warnings.h