mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
3383b79049
fa097d074bc1afcc2a52976796bb618f7c6a68b3 addrman: Log too low compat value (MarcoFalke)
Pull request description:
Before this patch, when writing a negative `lowest_compatible` value, it would be read as a positive value. For example `-32` will be read as `224`. There is generally nothing wrong with that. Though, similarly there shouldn't be anything wrong with refusing to read a negative value. I find the code after this patch more logical than before. Also, this allows dropping a file-wide sanitizer suppression.
In practice none of this should ever happen. Bitcoin Core would never write a negative `lowest_compatible` in normal operation, unless the file storage is later corrupted by external influence.
ACKs for top commit:
mzumsande:
re-ACK fa097d074bc1afcc2a52976796bb618f7c6a68b3
Tree-SHA512: 9aae7b8fe666f52f667f149667025e0160cef1a793cc4d392e36608f65c2bee8096da429235118f40a3368f327aabe30f3732ae78c5874648ea6f423f2687b65
105 lines
4.7 KiB
Plaintext
105 lines
4.7 KiB
Plaintext
# -fsanitize=undefined suppressions
|
|
# =================================
|
|
# This would be `signed-integer-overflow:CTxMemPool::PrioritiseTransaction`,
|
|
# however due to a bug in clang the symbolizer is disabled and thus no symbol
|
|
# names can be used.
|
|
# See https://github.com/google/sanitizers/issues/1364
|
|
signed-integer-overflow:txmempool.cpp
|
|
# https://github.com/bitcoin/bitcoin/pull/21798#issuecomment-829180719
|
|
signed-integer-overflow:policy/feerate.cpp
|
|
|
|
# -fsanitize=integer suppressions
|
|
# ===============================
|
|
# Unsigned integer overflow occurs when the result of an unsigned integer
|
|
# computation cannot be represented in its type. Unlike signed integer overflow,
|
|
# this is not undefined behavior, but it is often unintentional. The list below
|
|
# contains files in which we expect unsigned integer overflows to occur. The
|
|
# list is used to suppress -fsanitize=integer warnings when running our CI UBSan
|
|
# job.
|
|
unsigned-integer-overflow:*/include/c++/
|
|
unsigned-integer-overflow:addrman.cpp
|
|
unsigned-integer-overflow:arith_uint256.h
|
|
unsigned-integer-overflow:basic_string.h
|
|
unsigned-integer-overflow:bench/bench.h
|
|
unsigned-integer-overflow:common/bloom.cpp
|
|
unsigned-integer-overflow:chain.cpp
|
|
unsigned-integer-overflow:chain.h
|
|
unsigned-integer-overflow:coded_stream.h
|
|
unsigned-integer-overflow:coins.cpp
|
|
unsigned-integer-overflow:compressor.cpp
|
|
unsigned-integer-overflow:crypto/
|
|
# unsigned-integer-overflow in FuzzedDataProvider's ConsumeIntegralInRange
|
|
unsigned-integer-overflow:FuzzedDataProvider.h
|
|
unsigned-integer-overflow:hash.cpp
|
|
unsigned-integer-overflow:leveldb/
|
|
unsigned-integer-overflow:minisketch/
|
|
unsigned-integer-overflow:policy/fees.cpp
|
|
unsigned-integer-overflow:prevector.h
|
|
unsigned-integer-overflow:pubkey.h
|
|
unsigned-integer-overflow:script/interpreter.cpp
|
|
unsigned-integer-overflow:stl_bvector.h
|
|
unsigned-integer-overflow:test/fuzz/crypto_diff_fuzz_chacha20.cpp
|
|
unsigned-integer-overflow:txmempool.cpp
|
|
unsigned-integer-overflow:util/strencodings.cpp
|
|
unsigned-integer-overflow:validation.cpp
|
|
unsigned-integer-overflow:xoroshiro128plusplus.h
|
|
implicit-integer-sign-change:*/include/boost/
|
|
implicit-integer-sign-change:*/include/c++/
|
|
implicit-integer-sign-change:*/new_allocator.h
|
|
implicit-integer-sign-change:addrman.h
|
|
implicit-integer-sign-change:bech32.cpp
|
|
implicit-integer-sign-change:common/bloom.cpp
|
|
implicit-integer-sign-change:chain.cpp
|
|
implicit-integer-sign-change:chain.h
|
|
implicit-integer-sign-change:coins.h
|
|
implicit-integer-sign-change:compat/stdin.cpp
|
|
implicit-integer-sign-change:compressor.h
|
|
implicit-integer-sign-change:crc32c/
|
|
implicit-integer-sign-change:crypto/
|
|
# implicit-integer-sign-change in FuzzedDataProvider's ConsumeIntegralInRange
|
|
implicit-integer-sign-change:FuzzedDataProvider.h
|
|
implicit-integer-sign-change:key.cpp
|
|
implicit-integer-sign-change:minisketch/
|
|
implicit-integer-sign-change:policy/fees.cpp
|
|
implicit-integer-sign-change:prevector.h
|
|
implicit-integer-sign-change:script/bitcoinconsensus.cpp
|
|
implicit-integer-sign-change:script/interpreter.cpp
|
|
implicit-integer-sign-change:serialize.h
|
|
implicit-integer-sign-change:test/arith_uint256_tests.cpp
|
|
implicit-integer-sign-change:test/coins_tests.cpp
|
|
implicit-integer-sign-change:test/pow_tests.cpp
|
|
implicit-integer-sign-change:test/prevector_tests.cpp
|
|
implicit-integer-sign-change:test/sighash_tests.cpp
|
|
implicit-integer-sign-change:test/skiplist_tests.cpp
|
|
implicit-integer-sign-change:test/transaction_tests.cpp
|
|
implicit-integer-sign-change:txmempool.cpp
|
|
implicit-integer-sign-change:util/strencodings.cpp
|
|
implicit-integer-sign-change:util/strencodings.h
|
|
implicit-integer-sign-change:validation.cpp
|
|
implicit-signed-integer-truncation,implicit-integer-sign-change:chain.h
|
|
implicit-signed-integer-truncation,implicit-integer-sign-change:test/skiplist_tests.cpp
|
|
implicit-signed-integer-truncation:addrman.h
|
|
implicit-signed-integer-truncation:chain.h
|
|
implicit-signed-integer-truncation:crypto/
|
|
implicit-signed-integer-truncation:leveldb/
|
|
implicit-signed-integer-truncation:test/arith_uint256_tests.cpp
|
|
implicit-signed-integer-truncation:test/skiplist_tests.cpp
|
|
implicit-unsigned-integer-truncation:*/include/c++/
|
|
implicit-unsigned-integer-truncation:crypto/
|
|
implicit-unsigned-integer-truncation:leveldb/
|
|
implicit-unsigned-integer-truncation:test/fuzz/crypto_diff_fuzz_chacha20.cpp
|
|
# std::variant warning fixed in https://github.com/gcc-mirror/gcc/commit/074436cf8cdd2a9ce75cadd36deb8301f00e55b9
|
|
implicit-unsigned-integer-truncation:std::__detail::__variant::_Variant_storage
|
|
shift-base:xoroshiro128plusplus.h
|
|
shift-base:nanobench.h
|
|
shift-base:*/include/c++/
|
|
shift-base:arith_uint256.cpp
|
|
shift-base:crypto/
|
|
shift-base:hash.cpp
|
|
shift-base:leveldb/
|
|
shift-base:minisketch/
|
|
shift-base:streams.h
|
|
shift-base:test/fuzz/crypto_diff_fuzz_chacha20.cpp
|
|
shift-base:util/bip32.cpp
|
|
vptr:bls/bls.h
|