sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
38e70430b9
dash/src
History
PastaPastaPasta 38e70430b9
refactor: governance constification and deglobalization (#5572) 
## Issue being fixed or feature implemented
Some relatively simple refactoring; inspired by reviewing #5569; adds
some constification and some deglobalization

## What was done?
Partial deglobalization and constification

## How Has This Been Tested?
Building

## Breaking Changes
None

## Checklist:
_Go over all the following points, and put an `x` in all the boxes that
apply._
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
2023-09-10 14:05:49 -05:00
..
bench fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
bls feat: mnlistdiff v20 CL sig quorums (#5377) 2023-07-10 11:23:09 -05:00
coinjoin fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
compat Merge #21274: assumptions: Assume C++17 2023-08-28 11:24:41 -05:00
config
consensus fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
crc32c
crypto merge bitcoin#19521: Coinstats Index 2023-08-02 10:19:02 -05:00
dashbls build: stop tracking cmake dependency relic_conf.h.in 2023-06-28 23:44:03 +03:00
evo fix: actually erase old evodb data on db migration (#5570) 2023-09-09 12:28:12 -05:00
governance refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
immer build: fix gitian builds 2023-01-03 14:51:16 +03:00
index fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
interfaces merge bitcoin#23842: Rename interfaces::WalletClient to interfaces::WalletLoader 2023-09-04 20:50:27 -05:00
leveldb
llmq fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
logging Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
masternode refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
node fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
policy Merge #20497: [Refactor] Add MAX_STANDARD_SCRIPTSIG_SIZE to policy 2023-07-26 09:37:53 +05:30
primitives Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
qt merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
rpc refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
script merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
secp256k1
support Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
test refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
univalue
util fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
wallet fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
zmq Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
.clang-format
addrdb.cpp merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
addrdb.h
addressindex.h
addrman.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
addrman.h Merge bitcoin/bitcoin#19238: refactor: Make CAddrMan::cs non-recursive 2023-08-28 11:24:41 -05:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp feat(rpc): Added RPC cleardiscouraged (#5273) 2023-03-29 11:23:45 -05:00
banman.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
base58.cpp Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
base58.h Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
batchedlogger.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
batchedlogger.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
bip39.h fix(wallet): truncate mnemonic passphrase instead of crashing 2023-06-12 10:56:10 +03:00
bitcoin-cli.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
bitcoin-tx.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
bitcoin-wallet.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
bitcoind.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
blockencodings.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
blockencodings.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
blockfilter.cpp merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
blockfilter.h
bloom.cpp merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
bloom.h feat: add bloom filter for Asset Lock transactions (#5521) 2023-08-02 10:08:39 -05:00
cachemap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
cachemultimap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
chain.cpp
chain.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
chainparams.cpp chore: v20 Testnet signaling starttime (#5567) 2023-09-05 11:20:41 -05:00
chainparams.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
chainparamsbase.cpp Merge #16680: Preparations for more testchains 2023-04-25 23:41:20 -05:00
chainparamsbase.h merge bitcoin#19991: Use alternative port for incoming Tor connections 2023-04-17 08:30:49 +00:00
chainparamsseeds.h
checkqueue.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
clientversion.cpp
clientversion.h merge bitcoin#21059: Drop boost/preprocessor dependencies 2023-09-04 20:50:27 -05:00
coins.cpp merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
coins.h merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
compat.h Merge #20221: net: compat.h related cleanup 2023-08-01 12:24:36 -05:00
compressor.cpp Merge bitcoin/bitcoin#18847: compressor: use a prevector in CompressScript serialization [ZAP1] 2023-04-14 23:34:13 -05:00
compressor.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
context.h trivial: consistently use context as the argument name for CoreContext 2023-07-28 00:18:27 -05:00
core_io.h
core_memusage.h
core_read.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
core_write.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
ctpl_stl.h
cuckoocache.h merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
cxxtimer.hpp test/refactor: upgrade to cppcheck 2.9 and fix warnings (#5049) 2022-10-18 13:24:00 +03:00
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
dbwrapper.h fix: CDBTransaction::GetMemoryUsage() logging 2023-07-17 01:00:48 +03:00
dsnotificationinterface.cpp refactor: using reference instead reference to unique_ptr with object (#5381) 2023-06-04 15:26:23 -05:00
dsnotificationinterface.h refactor: using reference instead reference to unique_ptr with object (#5381) 2023-06-04 15:26:23 -05:00
dummywallet.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
flat-database.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
flatfile.cpp Merge #14501: Fix possible data race when committing block files 2023-08-29 21:40:46 -05:00
flatfile.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
fs.cpp Merge #19299: refactor: Remove unused vars, Add missing includes 2023-01-22 00:27:52 -06:00
fs.h
hash.cpp
hash.h
hdchain.cpp feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
hdchain.h feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
httprpc.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
httprpc.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
httpserver.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
httpserver.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
i2p.cpp merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
i2p.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
indirectmap.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
init.cpp refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
init.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
key_io.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
key_io.h
key.cpp
key.h partial Merge #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization methods 2023-04-17 10:42:25 -05:00
limitedmap.h chore: Drop unused unordered_limitedmap::insert_or_update() 2023-07-17 01:00:48 +03:00
logging.cpp Merge #18669: log: Use Join() helper when listing log categories 2023-08-29 21:40:46 -05:00
logging.h Merge #20584: Declare de facto const reference variables/member functions as const 2023-08-29 21:40:46 -05:00
Makefile.am merge bitcoin#23411: Avoid integer overflow in ApplyStats when activating snapshot 2023-09-04 20:50:27 -05:00
Makefile.bench.include Merge #18397: build: Fix libevent linking for bench_bitcoin binary 2023-05-31 12:01:04 -05:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include merge bitcoin#17513: Nuke some circular dependencies 2023-04-15 12:12:30 -05:00
Makefile.qttest.include partial bitcoin#19077: Add sqlite as an alternative wallet database and use it for new descriptor wallets 2023-02-07 10:53:33 -06:00
Makefile.test_fuzz.include merge bitcoin#20995: Avoid initializing version to less than MIN_PEER_PROTO_VERSION 2023-07-24 20:45:49 +03:00
Makefile.test_util.include merge bitcoin#27988: Use same timeout for all index sync 2023-08-02 10:19:02 -05:00
Makefile.test.include merge bitcoin#19055: Add MuHash3072 implementation 2023-08-29 21:55:45 -05:00
Makefile.univalue.include
mapport.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
mapport.h
memusage.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
merkleblock.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
merkleblock.h
messagesigner.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
messagesigner.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
miner.cpp refactor: rid-of magic constant by introducing MasternodePayments::PlatformShare 2023-09-05 11:25:28 -05:00
miner.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
net_permissions.cpp merge bitcoin#18991: Cache responses to GETADDR to prevent topology leaks 2023-06-05 10:11:03 -05:00
net_permissions.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
net_processing.cpp refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
net_processing.h refactor: governance constification and deglobalization (#5572) 2023-09-10 14:05:49 -05:00
net_types.h
net.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
net.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
netaddress.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
netaddress.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
netbase.cpp merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netbase.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netfulfilledman.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
netfulfilledman.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
outputtype.h Merge #18034: Get the OutputType for a descriptor 2023-05-24 12:43:57 -05:00
pow.cpp fix: respect fPowNoRetargeting for post-btc algos 2023-06-12 10:56:10 +03:00
pow.h
prevector.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
protocol.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
protocol.h Merge #20606: Remove unused bits from service flags enum 2023-08-01 12:21:16 -05:00
psbt.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
psbt.h Merge #17509: gui: save and load PSBT 2023-08-29 22:00:59 -05:00
pubkey.cpp
pubkey.h Merge #19237: wallet: Check size after unserializing a pubkey 2023-04-15 12:14:35 -05:00
random.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
random.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
randomenv.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
randomenv.h
rest.cpp merge bitcoin#21767: Prune g_chainman usage in auxiliary modules 2023-08-02 10:19:02 -05:00
reverse_iterator.h
saltedhasher.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
saltedhasher.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
scheduler.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
scheduler.h Merge bitcoin/bitcoin#24069: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) 2023-05-31 10:52:02 -05:00
serialize.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
shutdown.cpp merge bitcoin#21575: Create blockstorage module 2023-07-28 00:18:27 -05:00
shutdown.h merge bitcoin#21575: Create blockstorage module 2023-07-28 00:18:27 -05:00
span.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
spentindex.h
spork.cpp merge bitcoin#19791: Move Misbehaving() to PeerManager 2023-05-11 09:19:47 -05:00
spork.h merge bitcoin#19791: Move Misbehaving() to PeerManager 2023-05-11 09:19:47 -05:00
stacktraces.cpp ci: build TSan with clang 15 and add -Werror=thread-safety, fix-up stacktraces (#5375) 2023-05-26 13:49:29 -05:00
stacktraces.h
statsd_client.cpp refactor: resolve implicit-const-int-float-conversion warning in statsd_client 2022-10-21 21:51:35 +05:30
statsd_client.h chore: add missing copyrights via copyright_header.py insert 2023-01-13 00:49:04 +03:00
streams.h
sync.cpp Merge #21010: refactor: remove straggling boost::mutex usage 2023-07-25 10:45:09 -05:00
sync.h Merge #19337: sync: detect double lock from the same thread 2023-07-25 10:45:09 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp Merge #20141: Avoid the use of abs64 in timedata 2023-05-31 10:52:02 -05:00
timedata.h
tinyformat.h Merge #20530: lint, refactor: Update cppcheck linter to c++17 and improve explicit usage 2023-08-01 12:24:36 -05:00
torcontrol.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
torcontrol.h merge bitcoin#19288: Add fuzzing harness for TorController 2023-08-29 21:55:45 -05:00
txdb.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
txdb.h fix: implement missing logic for additional indexes, fix bugs and logging (#5477) 2023-07-24 20:54:24 +03:00
txmempool.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
txmempool.h merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
ui_interface.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
ui_interface.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
uint256.cpp uint256: add definition for constant 'ZERO' 2023-04-15 12:12:30 -05:00
uint256.h uint256: add definition for constant 'ZERO' 2023-04-15 12:12:30 -05:00
undo.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
unordered_lru_cache.h fix: off-by-1 in unordered_lru_cache 2023-06-12 10:56:10 +03:00
validation.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
validation.h merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
validationinterface.cpp Merge #18551: Do not clear validationinterface entries being executed 2023-08-03 11:16:41 -05:00
validationinterface.h Merge #18524: refactor: drop boost::signals2 in validationinterface 2023-08-03 11:16:41 -05:00
version.h feat: mnlistdiff v20 CL sig quorums (#5377) 2023-07-10 11:23:09 -05:00
versionbits.cpp partial bitcoin#11389: Support having SegWit always active in regtest 2023-08-29 21:55:45 -05:00
versionbits.h merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
versionbitsinfo.cpp feat: v20 evonodes payment adjustment (#5493) 2023-07-31 23:52:48 -05:00
versionbitsinfo.h refactor: cleanup CChainParams unused data and functions (#5474) 2023-07-04 12:25:36 -05:00
walletinitinterface.h
warnings.cpp merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00
warnings.h merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00