sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 21:12:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
3c90d26bab
dash/src/wallet
History
MarcoFalke 3c90d26bab Merge #15777: [docs] Add doxygen comments for keypool classes 
f1a77b0c51 [docs] Add doxygen comment for CReserveKey (John Newbery)
37796b2dd4 [docs] Add doxygen comment for CKeyPool (John Newbery)
ef2d515af3 [wallet] move-only: move CReserveKey to be next to CKeyPool (John Newbery)

Pull request description:

  Docs/move-only

  Adds doxygen comments for the CKeyPool and CReserveKey objects. The way these work is pretty confusing and it's easy to overlook details (eg https://github.com/bitcoin/bitcoin/pull/15557#discussion_r271956393).

  These are on the verbose side, but I think too much commenting is better than not enough. Happy to take feedback on what's an appropriate level.

ACKs for commit f1a77b:
  jonatack:
    Thanks, John. Re-ACK f1a77b0c5176306ca9f6f30211e32d3502ed4281, doc-only changes with respect to previous review.
  jb55:
    ACK f1a77b0c5176306ca9f6f30211e32d3502ed4281

Tree-SHA512: 8bc97c7029cd2e8d9bfd2d2144eeff73474c71eda5a9d10817e1578ca0b70da677252037d83143faaff1808e2193408a21a8a89d36049eac77fd313990f0b67b
2022-05-17 12:57:09 -04:00
..
test merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
bdb.cpp trivial: add some missing dashifications (#4772) 2022-04-19 09:09:42 +03:00
bdb.h Merge #18907: walletdb: Don't remove database transaction logs and instead error 2022-04-07 11:28:43 -05:00
coincontrol.cpp
coincontrol.h Merge #17316: refactor: Replace all uses of boost::optional with our own Optional type 2022-04-07 07:22:08 +05:30
coinselection.cpp Merge bitcoin/bitcoin#23254: doc: Fix typo and grammar 2022-04-11 09:41:11 -07:00
coinselection.h
crypter.cpp
crypter.h
db.cpp merge bitcoin#19290: Move BDB specific things into bdb.{cpp/h} 2022-03-06 12:30:58 +05:30
db.h merge bitcoin#18699: Avoid translating RPC errors 2022-04-07 10:13:16 +05:30
fees.cpp Merge #11882: Disable default fallbackfee on mainnet 2022-01-30 18:30:28 -05:00
fees.h
init.cpp merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
ismine.cpp Merge #16226: Move ismine to the wallet module (#4640) 2022-04-03 17:26:52 -05:00
ismine.h Merge #16226: Move ismine to the wallet module (#4640) 2022-04-03 17:26:52 -05:00
load.cpp Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
load.h Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
psbtwallet.cpp
psbtwallet.h
rpcdump.cpp merge bitcoin#15931: Remove GetDepthInMainChain dependency on locked chain interface 2022-04-20 00:20:30 +05:30
rpcwallet.cpp Merge #15492: [rpc] remove deprecated generate method 2022-05-01 20:52:10 +03:00
rpcwallet.h merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
salvage.cpp merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
salvage.h merge bitcoin#18918: Move salvagewallet into wallettool 2022-03-06 12:30:20 +05:30
wallet.cpp Merge #15492: [rpc] remove deprecated generate method 2022-05-01 20:52:10 +03:00
wallet.h Merge #15777: [docs] Add doxygen comments for keypool classes 2022-05-17 12:57:09 -04:00
walletdb.cpp merge bitcoin#15931: Remove GetDepthInMainChain dependency on locked chain interface 2022-04-20 00:20:30 +05:30
walletdb.h merge bitcoin#19334: Introduce WalletDatabase abstract class 2022-03-06 12:39:01 +05:30
wallettool.cpp partial bitcoin#15639: Drop libbitcoin_server.a dependency 2022-04-20 00:20:30 +05:30
wallettool.h
walletutil.cpp
walletutil.h