mirror of https://github.com/dashpay/dash.git synced 2024-12-23 19:12:47 +01:00

Dash - Reinventing Cryptocurrency

bitcoin blockchain cryptocurrency dash governance instant masternode p2p privacy

Go to file

pasta 3d5dc160d8 Some checks failed Guix Build / build-image (push) Failing after 6m2s Details Guix Build / build (aarch64-linux-gnu) (push) Has been skipped Details Guix Build / build (arm-linux-gnueabihf) (push) Has been skipped Details Guix Build / build (arm64-apple-darwin) (push) Has been skipped Details Guix Build / build (powerpc64-linux-gnu) (push) Has been skipped Details Guix Build / build (riscv64-linux-gnu) (push) Has been skipped Details Guix Build / build (x86_64-apple-darwin) (push) Has been skipped Details Guix Build / build (x86_64-linux-gnu) (push) Has been skipped Details Guix Build / build (x86_64-w64-mingw32) (push) Has been skipped Details Check Merge Fast-Forward Only / check_merge (push) Successful in 1m49s Details Label Merge Conflicts / main (push) Failing after 40s Details CI / Build Image (push) Failing after 15m29s Details CI / Build Dependencies (arm-linux, arm-linux-gnueabihf) (push) Has been cancelled Details CI / Build Dependencies (linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (arm-linux, arm-linux, arm-linux-gnueabihf) (push) Has been cancelled Details CI / Build (linux64, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (linux64_cxx20, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (linux64_fuzz, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (linux64_nowallet, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (linux64_sqlite, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (linux64_tsan, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details CI / Build (linux64_ubsan, linux64, x86_64-pc-linux-gnu) (push) Has been cancelled Details Merge #6462 : backport: merge bitcoin#23092, #23005 , #24704 , #24391 , #25338 , #25422 , #25493 , #26826 , #26814 , #26832 , #27418 , partial bitcoin#27254 (compat backports) `2ab561d281` partial bitcoin#27254: Extract util/fs from util/system (Kittywhiskers Van Gogh) `280988bee3` merge bitcoin#27418: Remove windows workaround in authproxy (Kittywhiskers Van Gogh) `a497df0339` merge bitcoin#26832: move (win) S_* defines into bdb (Kittywhiskers Van Gogh) `db676a7e5f` merge bitcoin#26814: remove windows-only compat.h usage in random (Kittywhiskers Van Gogh) `94e6637c33` merge bitcoin#26826: remove windows-only compat.h usage in randomenv (Kittywhiskers Van Gogh) `bbb0cceb7a` merge bitcoin#25493: document code in compat.h (Kittywhiskers Van Gogh) `3f143096c8` merge bitcoin#25422: globally define NOMINMAX when building with mingw-w64 (Kittywhiskers Van Gogh) `000495df8e` merge bitcoin#25338: Avoid incompatibility with CMake AUTOUIC feature (Kittywhiskers Van Gogh) `714ea55dbe` build: migrate stacktrace-related flags to `DEBUG_`{`C`,`CXX`}`FLAGS` (Kittywhiskers Van Gogh) `11323c3851` merge bitcoin#24391: stop overriding user autoconf flags (Kittywhiskers Van Gogh) `548121d366` merge bitcoin#24704: remove strnlen back-compat code (Kittywhiskers Van Gogh) `b65038ec94` merge bitcoin#23005: Delay wallet client construction (Kittywhiskers Van Gogh) `f3b065cd9c` merge bitcoin#23092: Remove Windows workaround in authproxy (WinError 10053) (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * This PR originally included [bitcoin#27378](https://github.com/bitcoin/bitcoin/pull/27378) but including it caused multiple tests to fail ([build](https://gitlab.com/dashpay/dash/-/jobs/8577987174#L2224)), even after adjusting `timeout`. It has been omitted instead. <details> <summary>Test failures:</summary> ``` feature_abortnode.py \| Failed \| 201 s feature_dip3_v19.py \| Failed \| 237 s feature_llmq_rotation.py \| Failed \| 54 s p2p_invalid_messages.py \| Failed \| 5 s rpc_bind.py --nonloopback \| Failed \| 63 s wallet_multiwallet.py --descriptors \| Failed \| 79 s wallet_multiwallet.py --legacy-wallet \| Failed \| 89 s ALL \| Failed \| 8540 s (accumulated) ``` </details> <details> <summary>feature_abortnode.py failure:</summary> ``` dash@107cfae2b2b5:/src/dash$ ./test/functional/feature_abortnode.py 2024-12-09T18:31:01.776000Z TestFramework (INFO): PRNG seed is: 6843309100291447752 2024-12-09T18:31:01.776000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_fcijb99n 2024-12-09T18:31:02.802000Z TestFramework (INFO): Waiting for crash 2024-12-09T18:34:23.026000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: '''' def is_node_stopped(self): """Checks whether the node has stopped. Returns True if the node has stopped. False otherwise. This method is responsible for freeing resources (self.process).""" if not self.running: return True return_code = self.process.poll() if return_code is None: return False # process has stopped. Assert that it didn't return an error code. assert return_code == 0, self._node_msg( "Node returned non-zero exit code (%d) when stopping" % return_code) self.running = False self.process = None self.rpc_connected = False self.rpc = None self.log.debug("Node stopped") return True ''' 2024-12-09T18:34:23.027000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/src/dash/test/functional/test_framework/test_framework.py", line 161, in main self.run_test() File "/src/dash/./test/functional/feature_abortnode.py", line 44, in run_test self.nodes[0].wait_until_stopped(timeout=200) File "/src/dash/test/functional/test_framework/test_node.py", line 414, in wait_until_stopped wait_until_helper(self.is_node_stopped, timeout=timeout, timeout_factor=self.timeout_factor) File "/src/dash/test/functional/test_framework/util.py", line 287, in wait_until_helper raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout)) AssertionError: Predicate '''' def is_node_stopped(self): """Checks whether the node has stopped. Returns True if the node has stopped. False otherwise. This method is responsible for freeing resources (self.process).""" if not self.running: return True return_code = self.process.poll() if return_code is None: return False # process has stopped. Assert that it didn't return an error code. assert return_code == 0, self._node_msg( "Node returned non-zero exit code (%d) when stopping" % return_code) self.running = False self.process = None self.rpc_connected = False self.rpc = None self.log.debug("Node stopped") return True ''' not true after 200.0 seconds 2024-12-09T18:34:23.530000Z TestFramework (INFO): Stopping nodes 2024-12-09T18:34:23.530000Z TestFramework (ERROR): Unexpected exception caught during shutdown Traceback (most recent call last): File "/src/dash/test/functional/test_framework/test_framework.py", line 341, in shutdown self.stop_nodes() File "/src/dash/test/functional/test_framework/test_framework.py", line 673, in stop_nodes node.stop_node(expected_stderr=expected_stderr, wait=wait, wait_until_stopped=False) File "/src/dash/test/functional/test_framework/test_node.py", line 368, in stop_node self.stop(wait=wait) File "/src/dash/test/functional/test_framework/coverage.py", line 49, in __call__ return_val = self.auth_service_proxy_instance.__call__(args, kwargs) File "/src/dash/test/functional/test_framework/authproxy.py", line 124, in __call__ response, status = self._request('POST', self.__url.path, postdata.encode('utf-8')) File "/src/dash/test/functional/test_framework/authproxy.py", line 103, in _request return self._get_response() File "/src/dash/test/functional/test_framework/authproxy.py", line 162, in _get_response raise JSONRPCException( test_framework.authproxy.JSONRPCException: non-JSON HTTP response with '503 Service Unavailable' from server (-342) 2024-12-09T18:34:23.531000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_fcijb99n 2024-12-09T18:34:23.531000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_fcijb99n/test_framework.log 2024-12-09T18:34:23.531000Z TestFramework (ERROR): 2024-12-09T18:34:23.531000Z TestFramework (ERROR): Hint: Call /src/dash/test/functional/combine_logs.py '/tmp/dash_func_test_fcijb99n' to consolidate all logs 2024-12-09T18:34:23.531000Z TestFramework (ERROR): 2024-12-09T18:34:23.531000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log. 2024-12-09T18:34:23.531000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues 2024-12-09T18:34:23.531000Z TestFramework (ERROR): [node 1] Cleaning up leftover process [node 0] Cleaning up leftover process ``` </details> [bitcoin#27254](https://github.com/bitcoin/bitcoin/pull/27254) has been partially backported to include a missing header to allow it to build. <details> <summary>Compile error:</summary> ``` In file included from ./util/system.h:19, from util/system.cpp:7: ./compat/assumptions.h:49:22: error: 'size_t' was not declared in this scope; did you mean 'std::size_t'? 49 \| static_assert(sizeof(size_t) == 4 \|\| sizeof(size_t) == 8, "size_t assumed to be 32-bit or 64-bit"); \| ^~~~~~ \| std::size_t In file included from /usr/include/c++/11/limits:42, from ./compat/assumptions.h:11, from ./util/system.h:19, from util/system.cpp:7: /usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:280:33: note: 'std::size_t' declared here 280 \| typedef __SIZE_TYPE__ size_t; \| ^~~~~~ ``` </details> * ~~GitLab job failures as of 2339ae6459cad77d94795c0e92ba3f3fe31c485a, for `linux64-build` ([source](https://gitlab.com/dashpay/dash/-/jobs/8590291130#L4621)), `linux64_cxx20-build` ([source](https://gitlab.com/dashpay/dash/-/jobs/8590291134#L3497)) and `linux64_sqlite-build` ([source](https://gitlab.com/dashpay/dash/-/jobs/8590291137#L3489)) are not related to failures in compilation or unit tests but are to do with reaching the artifact limit.~~ Resolved with [dash#6487](https://github.com/dashpay/dash/pull/6487), thanks Udjin! ## Breaking Changes None expected. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas (note: N/A) - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation (note: N/A) - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK `2ab561d281` PastaPastaPasta: utACK `2ab561d281` Tree-SHA512: 6d05305f17fd607ed93b4a2e00de195a96bde1a34bedf04f6dd84892dc71028ae71590fa5063026ec7ff728d6e411af410c363b4a88947ce6e5999d4431bb29b		2024-12-15 12:30:54 -06:00
.github	ci: do not check `--ff-only` on master branch	2024-12-14 12:50:11 +03:00
.tx	fix: follow-up #5393 - should be used `[dash.dash_ents]` (#5472 )	2023-07-01 14:16:50 +03:00
build-aux/m4	merge bitcoin#24391: stop overriding user autoconf flags	2024-12-15 09:08:22 +00:00
ci	Merge #6479 : feat: enable coverage linter for functional tests	2024-12-15 12:12:40 -06:00
contrib	merge bitcoin#23506: Make more shell scripts verifiable by the `shellcheck` tool	2024-12-04 15:55:11 +00:00
depends	merge bitcoin#30198: qt 5.15.14 and fix macOS build with Clang 18	2024-11-17 07:42:09 +00:00
doc	merge bitcoin#29452: document that BIP324 on by default	2024-12-14 12:00:51 +00:00
share	merge bitcoin#27676: Bump minimum required runtime version and prepare for building with upstream LLVM	2024-11-13 11:07:38 +00:00
src	Merge #6462 : backport: merge bitcoin#23092, #23005 , #24704 , #24391 , #25338 , #25422 , #25493 , #26826 , #26814 , #26832 , #27418 , partial bitcoin#27254 (compat backports)	2024-12-15 12:30:54 -06:00
test	Merge #6462 : backport: merge bitcoin#23092, #23005 , #24704 , #24391 , #25338 , #25422 , #25493 , #26826 , #26814 , #26832 , #27418 , partial bitcoin#27254 (compat backports)	2024-12-15 12:30:54 -06:00
.cirrus.yml	merge bitcoin#27676: Bump minimum required runtime version and prepare for building with upstream LLVM	2024-11-13 11:07:38 +00:00
.dockerignore	build: add dash minimal development environment container	2021-12-21 12:43:37 +05:30
.editorconfig	Merge #21123 : code style: Add EditorConfig file	2021-07-16 10:04:09 -05:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	merge bitcoin#24031: don't compress macOS DMG	2024-11-06 19:22:01 +00:00
.gitlab-ci.yml	ci: better names for artifacts	2024-12-14 12:48:50 +03:00
.python-version	partial Merge bitcoin/bitcoin#28210 : build: Bump clang minimum supported version to 13	2024-10-06 13:36:27 -05:00
.style.yapf	Merge bitcoin/bitcoin#27802 : Update .style.yapf	2024-10-25 09:12:00 -05:00
autogen.sh	Merge bitcoin/bitcoin#27875 : build: make sure we can overwrite config.{guess,sub} before doing so	2024-10-25 09:12:01 -05:00
CMakeLists.txt	chore: Added missing sources files in CMake (#5503 )	2023-07-25 12:23:56 -05:00
configure.ac	merge bitcoin#25422: globally define NOMINMAX when building with mingw-w64	2024-12-15 09:08:22 +00:00
CONTRIBUTING.md	Merge #6220 : backport: Merge bitcoin#18448,24433, 24139, 23001, (partial) 24339, (partial) core/gui#420	2024-09-27 12:29:08 -05:00
COPYING	docs: update license year range to 2024 (#5890 )	2024-02-22 20:56:43 -06:00
INSTALL.md	Dashify INSTALL.md and build-unix.md	2018-01-12 16:12:54 +01:00
libdashconsensus.pc.in	revert dash#1432: Rename consensus source library and API	2022-08-09 14:16:28 +05:30
Makefile.am	merge bitcoin#22861: Update test README and lint script	2024-11-27 04:55:46 +00:00
README.md	doc: make build steps more prominent	2024-07-18 01:22:42 -06:00
SECURITY.md	docs: update supported versions in SECURITY.md	2024-12-07 07:58:19 +00:00

README.md

Dash Core staging tree

CI	master	develop
Gitlab

https://www.dash.org

For an immediately usable, binary version of the Dash Core software, see https://www.dash.org/downloads/.

Further information about Dash Core is available in ./doc/.

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information read the original Dash whitepaper.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The develop branch is regularly built (see doc/build-*.md for instructions) and tested, but is not guaranteed to be completely stable.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Build / Compile from Source

The ./configure, make, and cmake steps, as well as build dependencies, are in ./doc/ as well:

Linux: ./doc/build-unix.md
Ubuntu, Debian, Fedora, Arch, and others
macOS: ./doc/build-osx.md
Windows: ./doc/build-windows.md
OpenBSD: ./doc/build-openbsd.md
FreeBSD: ./doc/build-freebsd.md
NetBSD: ./doc/build-netbsd.md

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.