mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00

History

UdjinM6 c49628de54 fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711 ) ## Issue being fixed or feature implemented `ConnectBlock` can fail after `ProcessSpecialTxsInBlock`, we shouldn't be notifying too early. Same for `DisconnectBlock` but that's less of an issue imo. ## What was done? Move notifications to the end of `ConnectBlock`/`DisconnectBlock`. There is no `connman` in `CChainState` and I don't want to pass it in updates struct so I changed `NotifyMasternodeListChanged` and used `connman` from `CDSNotificationInterface` instead. ## How Has This Been Tested? run unit test, run testnet qt wallet ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_		2023-11-16 12:37:07 -06:00
..
check-doc.py	merge bitcoin#19671: Remove -zapwallettxes	2022-05-13 18:06:06 +05:30
check-rpc-mappings.py	refactor: remove leftover rpc prefix from filename (evo, quorum)	2022-10-21 21:51:45 +05:30
commit-script-check.sh	Merge bitcoin/bitcoin#23543 : test: Prevent non-compatible sed binary for scripted-diffs	2022-04-11 09:46:40 -07:00
extended-lint-all.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
extended-lint-cppcheck.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
git-subtree-check.sh
lint-all.sh	Optimize linters (#4637 )	2021-12-30 19:34:36 +03:00
lint-assertions.sh	partial bitcoin#19277: Add Assert identity function'	2022-05-13 18:06:06 +05:30
lint-circular-dependencies.sh	fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711 )	2023-11-16 12:37:07 -06:00
lint-cppcheck-dash.sh	refactor: remove some now unneeded cppcheck suppressions (#5589 )	2023-09-29 07:53:22 -05:00
lint-filenames.sh	build: add exclusions to linting scripts and filters	2022-12-01 00:51:08 +05:30
lint-format-strings.py	Merge #16688 : log: Add validation interface logging	2023-05-24 12:43:57 -05:00
lint-format-strings.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
lint-git-commit-check.sh
lint-include-guards.sh	refactor: add gsl::not_null to get compile time / run time pointer guarantees (#5595 )	2023-10-22 09:14:30 -05:00
lint-includes.sh	Merge bitcoin/bitcoin#25803 : refactor: Drop `boost/algorithm/string/replace.hpp` dependency	2023-10-31 08:40:25 -05:00
lint-locale-dependence.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
lint-logs.sh	Merge #17260 : Split some CWallet functions into new LegacyScriptPubKeyMan (#4938 )	2022-08-08 11:05:21 -05:00
lint-python-dead-code.sh
lint-python-mutable-default-parameters.sh	Merge #16726 : tests: Avoid common Python default parameter gotcha when mutable dict/list:s are used as default parameter values	2023-04-04 12:45:27 -05:00
lint-python-utf8-encoding.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
lint-python.sh	build: add exclusions to linting scripts and filters	2022-12-01 00:51:08 +05:30
lint-qt.sh
lint-rpc-help.sh	Merge bitcoin#14726: Use RPCHelpMan for all RPCs (#4492 )	2021-10-12 00:55:23 +03:00
lint-shebang.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
lint-shell-locale.sh	build/depends: commit dashpay/bls-signatures@66ee820f to source tree as vendored (#5077 )	2022-11-22 11:34:46 -06:00
lint-shell.sh	Merge #18673 : scripted-diff: Sort test includes	2023-08-29 22:00:59 -05:00
lint-spelling.ignore-words.txt	Merge #18253 : doc: Correct spelling errors in comments	2023-04-04 12:53:49 -05:00
lint-spelling.sh	partial Merge bitcoin/bitcoin#22405 : build: remove --enable-glibc-back-compat from Guix build	2023-03-26 16:50:26 -05:00
lint-submodule.sh
lint-tests.sh
lint-whitespace.sh	Merge #20937 : guix: Make nsis reproducible by respecting SOURCE-DATE-EPOCH	2023-03-26 16:50:26 -05:00
README.md	Merge #17176 : ci: Cleanup macOS runs	2022-05-17 01:20:21 -04:00

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs. Scripted diffs are only assumed to run on the latest LTS release of Ubuntu. Running them on other operating systems might require installing GNU tools, such as GNU sed.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)
for src/crc32c: https://github.com/google/crc32c.git (branch master)

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.