40c259bdf3
* fix: compilation warnings
./validation.h:266:13: warning: ‘bool AcceptToMemoryPoolWithTime(const CChainParams&, CTxMemPool&, CValidationState&, const CTransactionRef&, bool*, int64_t, bool, CAmount, bool)’ declared ‘static’ but never defined [-Wunused-function]
static bool AcceptToMemoryPoolWithTime(const CChainParams& chainparams, CTxMemPool& pool, CValidationState &state, const CTransactionRef &tx,
^~~~~~~~~~~~~~~~~~~~~~~~~~
* fix: compilation warnings
./coinjoin/client.h: In constructor ‘CCoinJoinClientManager::CCoinJoinClientManager(CWallet&)’:
./coinjoin/client.h:199:10: warning: ‘CCoinJoinClientManager::fCreateAutoBackups’ will be initialized after [-Wreorder]
bool fCreateAutoBackups; // builtin support for automatic backups
^~~~~~~~~~~~~~~~~~
./coinjoin/client.h:187:14: warning: ‘CWallet& CCoinJoinClientManager::mixingWallet’ [-Wreorder]
CWallet& mixingWallet;
^~~~~~~~~~~~
./coinjoin/client.h:205:14: warning: when initialized here [-Wreorder]
explicit CCoinJoinClientManager(CWallet& wallet) :
^~~~~~~~~~~~~~~~~~~~~~
* fix: compilation warnings
interfaces/wallet.cpp: In constructor ‘interfaces::{anonymous}::WalletImpl::WalletImpl(const std::shared_ptr<CWallet>&)’:
interfaces/wallet.cpp:594:30: warning: ‘interfaces::{anonymous}::WalletImpl::m_wallet’ will be initialized after [-Wreorder]
std::shared_ptr<CWallet> m_wallet;
^~~~~~~~
interfaces/wallet.cpp:191:18: warning: ‘interfaces::{anonymous}::CoinJoinImpl interfaces::{anonymous}::WalletImpl::m_coinjoin’ [-Wreorder]
CoinJoinImpl m_coinjoin;
^~~~~~~~~~
interfaces/wallet.cpp:193:14: warning: when initialized here [-Wreorder]
explicit WalletImpl(const std::shared_ptr<CWallet>& wallet) : m_wallet(wallet), m_coinjoin(wallet) {}
^~~~~~~~~~
* fix: compilation warnings
validation.cpp:165:13: warning: ‘void CheckBlockIndex(const Consensus::Params&)’ declared ‘static’ but never defined [-Wunused-function]
static void CheckBlockIndex(const Consensus::Params& consensusParams);
^~~~~~~~~~~~~~~
* fix: compilation warnings
bls/bls_worker.cpp: In constructor ‘ContributionVerifier::ContributionVerifier(CBLSId, const std::vector<std::shared_ptr<std::vector<CBLSPublicKey> > >&, const BLSSecretKeyVector&, size_t, bool, bool, ctpl::thread_pool&, std::function<void(const std::vector<bool>&)>)’:
bls/bls_worker.cpp:425:51: warning: ‘ContributionVerifier::doneCallback’ will be initialized after [-Wreorder]
std::function<void(const std::vector<bool>&)> doneCallback;
^~~~~~~~~~~~
bls/bls_worker.cpp:420:12: warning: ‘size_t ContributionVerifier::batchCount’ [-Wreorder]
size_t batchCount;
^~~~~~~~~~
bls/bls_worker.cpp:427:5: warning: when initialized here [-Wreorder]
ContributionVerifier(CBLSId _forId, const std::vector<BLSVerificationVectorPtr>& _vvecs,
^~~~~~~~~~~~~~~~~~~~
* fix: compilation warnings
bls/bls_worker.cpp:342:10: warning: ‘VectorAggregator<CBLSPublicKey>::parallel’ will be initialized after [-Wreorder]
bool parallel;
^~~~~~~~
bls/bls_worker.cpp:340:12: warning: ‘size_t VectorAggregator<CBLSPublicKey>::start’ [-Wreorder]
size_t start;
^~~~~
bls/bls_worker.cpp:350:5: warning: when initialized here [-Wreorder]
VectorAggregator(const VectorVectorType& _vecs,
^~~~~~~~~~~~~~~~
bls/bls_worker.cpp:343:24: warning: ‘VectorAggregator<CBLSPublicKey>::workerPool’ will be initialized after [-Wreorder]
ctpl::thread_pool& workerPool;
^~~~~~~~~~
bls/bls_worker.cpp:337:18: warning: ‘VectorAggregator<CBLSPublicKey>::DoneCallback VectorAggregator<CBLSPublicKey>::doneCallback’ [-Wreorder]
DoneCallback doneCallback;
^~~~~~~~~~~~
bls/bls_worker.cpp:350:5: warning: when initialized here [-Wreorder]
VectorAggregator(const VectorVectorType& _vecs,
^~~~~~~~~~~~~~~~
* fix: compilation warnings
bls/bls_worker.cpp:494:235: required from here
bls/bls_worker.cpp:136:24: warning: ‘Aggregator<CBLSSecretKey>::workerPool’ will be initialized after [-Wreorder]
ctpl::thread_pool& workerPool;
^~~~~~~~~~
bls/bls_worker.cpp:135:10: warning: ‘bool Aggregator<CBLSSecretKey>::parallel’ [-Wreorder]
bool parallel;
^~~~~~~~
bls/bls_worker.cpp:152:5: warning: when initialized here [-Wreorder]
Aggregator(const std::vector<TP>& _inputVec,
^~~~~~~~~~
* fix: compilation warnings
bench/string_cast.cpp: In lambda function:
bench/string_cast.cpp:22:13: warning: statement has no effect [-Wunused-value]
atoi("1");
~~~~^~~~~
* fix: compilation warnings
./llmq/dkgsessionhandler.h: In constructor ‘llmq::CDKGPendingMessages::CDKGPendingMessages(size_t, int)’:
./llmq/dkgsessionhandler.h:48:12: warning: ‘llmq::CDKGPendingMessages::maxMessagesPerNode’ will be initialized after [-Wreorder]
size_t maxMessagesPerNode GUARDED_BY(cs);
^~~~~~~~~~~~~~~~~~
./llmq/dkgsessionhandler.h:47:15: warning: ‘const int llmq::CDKGPendingMessages::invType’ [-Wreorder]
const int invType;
^~~~~~~
llmq/dkgsessionhandler.cpp:23:1: warning: when initialized here [-Wreorder]
CDKGPendingMessages::CDKGPendingMessages(size_t _maxMessagesPerNode, int _invType) :
^~~~~~~~~~~~~~~~~~~
* fix: compilation warnings
Not sure this one is correct, but I believe so. Seems like the `!= 0` is completely not needed
rpc/masternode.cpp: In function ‘UniValue masternode_payments(const JSONRPCRequest&)’:
rpc/masternode.cpp:442:31: warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]
while (vecPayments.size() < std::abs(nCount) != 0 && pindex != nullptr) {
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
* fix: compilation warnings
test/cachemultimap_tests.cpp:14:13: warning: ‘void cachemultimap_tests::DumpMap(const CacheMultiMap<int, int>&)’ defined but not used [-Wunused-function]
static void DumpMap(const CacheMultiMap<int,int>& cmmap)
^~~~~~~
* fix: compilation warnings
In file included from qt/appearancewidget.cpp:11:
./qt/appearancewidget.h: In constructor ‘AppearanceWidget::AppearanceWidget(QWidget*)’:
./qt/appearancewidget.h:52:25: warning: ‘AppearanceWidget::prevFontFamily’ will be initialized after [-Wreorder]
GUIUtil::FontFamily prevFontFamily;
^~~~~~~~~~~~~~
./qt/appearancewidget.h:51:9: warning: ‘int AppearanceWidget::prevScale’ [-Wreorder]
int prevScale;
^~~~~~~~~
qt/appearancewidget.cpp:21:1: warning: when initialized here [-Wreorder]
AppearanceWidget::AppearanceWidget(QWidget* parent) :
^~~~~~~~~~~~~~~~
* fix: compilation warnings
In file included from qt/bitcoingui.cpp:6:
./qt/bitcoingui.h: In constructor ‘BitcoinGUI::BitcoinGUI(interfaces::Node&, const NetworkStyle*, QWidget*)’:
./qt/bitcoingui.h:212:31: warning: ‘BitcoinGUI::m_network_style’ will be initialized after [-Wreorder]
const NetworkStyle* const m_network_style;
^~~~~~~~~~~~~~~
./qt/bitcoingui.h:172:34: warning: ‘const std::unique_ptr<QMenu> BitcoinGUI::trayIconMenu’ [-Wreorder]
const std::unique_ptr<QMenu> trayIconMenu;
^~~~~~~~~~~~
qt/bitcoingui.cpp:81:1: warning: when initialized here [-Wreorder]
BitcoinGUI::BitcoinGUI(interfaces::Node& node, const NetworkStyle* networkStyle, QWidget* parent) :
^~~~~~~~~~
* fix: compilation warnings
In file included from qt/masternodelist.cpp:1:
./qt/masternodelist.h: In constructor ‘MasternodeList::MasternodeList(QWidget*)’:
./qt/masternodelist.h:66:18: warning: ‘MasternodeList::walletModel’ will be initialized after [-Wreorder]
WalletModel* walletModel;
^~~~~~~~~~~
./qt/masternodelist.h:61:10: warning: ‘bool MasternodeList::fFilterUpdatedDIP3’ [-Wreorder]
bool fFilterUpdatedDIP3;
^~~~~~~~~~~~~~~~~~
qt/masternodelist.cpp:45:1: warning: when initialized here [-Wreorder]
MasternodeList::MasternodeList(QWidget* parent) :
^~~~~~~~~~~~~~
In file included from qt/masternodelist.cpp:1:
./qt/masternodelist.h:61:10: warning: ‘MasternodeList::fFilterUpdatedDIP3’ will be initialized after [-Wreorder]
bool fFilterUpdatedDIP3;
^~~~~~~~~~~~~~~~~~
./qt/masternodelist.h:59:13: warning: ‘int64_t MasternodeList::nTimeFilterUpdatedDIP3’ [-Wreorder]
int64_t nTimeFilterUpdatedDIP3;
^~~~~~~~~~~~~~~~~~~~~~
qt/masternodelist.cpp:45:1: warning: when initialized here [-Wreorder]
MasternodeList::MasternodeList(QWidget* parent) :
^~~~~~~~~~~~~~
* fix: compilation warnings
In file included from qt/paymentserver.cpp:10:
./qt/paymentserver.h: In constructor ‘PaymentServer::PaymentServer(QObject*, bool)’:
./qt/paymentserver.h:156:28: warning: ‘PaymentServer::netManager’ will be initialized after [-Wreorder]
QNetworkAccessManager* netManager; // Used to fetch payment requests
^~~~~~~~~~
./qt/paymentserver.h:147:19: warning: ‘OptionsModel* PaymentServer::optionsModel’ [-Wreorder]
OptionsModel *optionsModel;
^~~~~~~~~~~~
qt/paymentserver.cpp:197:1: warning: when initialized here [-Wreorder]
PaymentServer::PaymentServer(QObject* parent, bool startLocalServer) :
^~~~~~~~~~~~~
|
||
|---|---|---|
| .github | ||
| .travis | ||
| .tx | ||
| build-aux/m4 | ||
| ci | ||
| contrib | ||
| depends | ||
| doc | ||
| docker | ||
| share | ||
| src | ||
| test | ||
| .cirrus.yml | ||
| .editorconfig | ||
| .fuzzbuzz.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .python-version | ||
| .style.yapf | ||
| .travis.yml | ||
| autogen.sh | ||
| CMakeLists.txt | ||
| configure.ac | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| INSTALL.md | ||
| libdashconsensus.pc.in | ||
| Makefile.am | ||
| README.md | ||
| SECURITY.md | ||
Dash Core staging tree 0.17
| CI | master | develop |
|---|---|---|
| Gitlab |  |
 |
What is Dash?
Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.
For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.
License
Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is meant to be stable. Development is normally done in separate branches.
Tags are created to indicate new official,
stable release versions of Dash Core.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python, that are run automatically on the build server.
These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py
The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
Translators should also follow the forum.