mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
deb7de26dd
9c18992bbaf649f8c5461d5e4dc39eb1a07ffc77 test: add coverage for `-bantime` (brunoerg)
Pull request description:
This PR adds test coverage for `-bantime`. This flag sets the time in seconds how long the IP is banned (in the case you don't explicitly set `bantime` when using `setban`).
ACKs for top commit:
MarcoFalke:
lgtm ACK 9c18992bbaf649f8c5461d5e4dc39eb1a07ffc77
Tree-SHA512: e95f8608aa5df9b09cc5577daae662ed79ef5d5c69ee5e704d7c69520b9b51cc142e9e6be69d80356eda25a5215c4770b1a208638560c48cd3bc8f6d195a371f
82 lines
3.0 KiB
Python
Executable File
82 lines
3.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the setban rpc call."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
p2p_port,
|
|
assert_equal,
|
|
)
|
|
|
|
class SetBanTests(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.setup_clean_chain = True
|
|
self.extra_args = [[],[]]
|
|
|
|
def is_banned(self, node, addr):
|
|
return any(e['address'] == addr for e in node.listbanned())
|
|
|
|
def run_test(self):
|
|
# Node 0 connects to Node 1, check that the noban permission is not granted
|
|
self.connect_nodes(0, 1)
|
|
peerinfo = self.nodes[1].getpeerinfo()[0]
|
|
assert not "noban" in peerinfo["permissions"]
|
|
|
|
# Node 0 get banned by Node 1
|
|
self.nodes[1].setban("127.0.0.1", "add")
|
|
|
|
# Node 0 should not be able to reconnect
|
|
with self.nodes[1].assert_debug_log(expected_msgs=['dropped (banned)\n'], timeout=50):
|
|
self.restart_node(1, [])
|
|
self.nodes[0].addnode("127.0.0.1:" + str(p2p_port(1)), "onetry")
|
|
|
|
# However, node 0 should be able to reconnect if it has noban permission
|
|
self.restart_node(1, ['-whitelist=127.0.0.1'])
|
|
self.connect_nodes(0, 1)
|
|
peerinfo = self.nodes[1].getpeerinfo()[0]
|
|
assert "noban" in peerinfo["permissions"]
|
|
|
|
# If we remove the ban, Node 0 should be able to reconnect even without noban permission
|
|
self.nodes[1].setban("127.0.0.1", "remove")
|
|
self.restart_node(1, [])
|
|
self.connect_nodes(0, 1)
|
|
peerinfo = self.nodes[1].getpeerinfo()[0]
|
|
assert not "noban" in peerinfo["permissions"]
|
|
|
|
self.log.info("Test that a non-IP address can be banned/unbanned")
|
|
node = self.nodes[1]
|
|
tor_addr = "pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion"
|
|
ip_addr = "1.2.3.4"
|
|
assert not self.is_banned(node, tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
node.setban(tor_addr, "add")
|
|
assert self.is_banned(node, tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
self.log.info("Test the ban list is preserved through restart")
|
|
|
|
self.restart_node(1)
|
|
assert self.is_banned(node, tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
node.setban(tor_addr, "remove")
|
|
assert not self.is_banned(self.nodes[1], tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
self.restart_node(1)
|
|
assert not self.is_banned(node, tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
self.log.info("Test -bantime")
|
|
self.restart_node(1, ["-bantime=1234"])
|
|
self.nodes[1].setban("127.0.0.1", "add")
|
|
banned = self.nodes[1].listbanned()[0]
|
|
assert_equal(banned['ban_duration'], 1234)
|
|
|
|
if __name__ == '__main__':
|
|
SetBanTests().main()
|