dash/src/llmq
UdjinM6 41b34186c6
fix: Redefine keepOldKeys and align quorum and dkgsession key storage depths (#5748)
## Issue being fixed or feature implemented
When DKG data recovery is triggered by `qgetdata` the data we use to
construct `qdata` reply is actually the one handled by
`CDKGSessionManager`, not by `CQuorumManager`. Not storing the data long
enough in `CDKGSessionManager` will result in this data simply not being
recoverable.

Also, the formula in `CDKGSessionManager::CleanupOldContributions()` is
broken for quorums which use rotation (the depth is way too large).

## What was done?
Fix both issues by redefining `keepOldKeys` and aligning key storage
depths in both modules.

## How Has This Been Tested?

## Breaking Changes
n/a

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
2023-12-04 13:38:32 +03:00
..
blockprocessor.cpp cleanup: drop UpgradeDB for llmq::BlockProcessor 2023-11-18 02:43:47 +07:00
blockprocessor.h cleanup: remove TODO so far as it is not clear what exactly to do 'cleanup' 2023-11-18 02:43:47 +07:00
chainlocks.cpp fix: Avoid using GetAdjustedTime() where adjusted time is not really needed or can be harmful (#5631) 2023-10-23 10:39:39 -05:00
chainlocks.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
clsig.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
clsig.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
commitment.cpp refactor: add gsl::not_null to get compile time / run time pointer guarantees (#5595) 2023-10-22 09:14:30 -05:00
commitment.h refactor: add gsl::not_null to get compile time / run time pointer guarantees (#5595) 2023-10-22 09:14:30 -05:00
context.cpp feat: auto generation EHF and spork+EHF activation for MN_RR (#5597) 2023-10-17 22:31:40 -05:00
context.h feat: auto generation EHF and spork+EHF activation for MN_RR (#5597) 2023-10-17 22:31:40 -05:00
debug.cpp merge bitcoin#20749: Prune g_chainman usage related to ::LookupBlockIndex 2023-04-04 12:41:45 -05:00
debug.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
dkgsession.cpp refactor: a new struct CDKGJustification::Contribution instead std::pair 2023-11-18 02:43:47 +07:00
dkgsession.h refactor: a new struct CDKGJustification::Contribution instead std::pair 2023-11-18 02:43:47 +07:00
dkgsessionhandler.cpp merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
dkgsessionhandler.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
dkgsessionmgr.cpp fix: Redefine keepOldKeys and align quorum and dkgsession key storage depths (#5748) 2023-12-04 13:38:32 +03:00
dkgsessionmgr.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
ehf_signals.cpp refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
ehf_signals.h feat: auto generation EHF and spork+EHF activation for MN_RR (#5597) 2023-10-17 22:31:40 -05:00
instantsend.cpp refactor: deprecate non-deterministic IS support (#5553) 2023-11-20 10:17:04 -06:00
instantsend.h refactor: deprecate non-deterministic IS support (#5553) 2023-11-20 10:17:04 -06:00
params.h fix: Redefine keepOldKeys and align quorum and dkgsession key storage depths (#5748) 2023-12-04 13:38:32 +03:00
quorums.cpp fix: Improve quorum data caching and cleanup (#5731) 2023-11-29 08:17:58 -06:00
quorums.h fix: Improve quorum data caching and cleanup (#5731) 2023-11-29 08:17:58 -06:00
signing_shares.cpp fix: Avoid using GetAdjustedTime() where adjusted time is not really needed or can be harmful (#5631) 2023-10-23 10:39:39 -05:00
signing_shares.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
signing.cpp refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
signing.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
snapshot.cpp refactor: deprecate non-deterministic IS support (#5553) 2023-11-20 10:17:04 -06:00
snapshot.h refactor: further spanification of Dash code (#5586) 2023-10-03 09:52:33 -05:00
utils.cpp Merge bitcoin/bitcoin#19438: Introduce deploymentstatus 2023-12-01 09:08:50 -06:00
utils.h fix: Improve quorum data caching and cleanup (#5731) 2023-11-29 08:17:58 -06:00