Wladimir J. van der Laan 44c7301288 Merge #13603: bitcoin-tx: Stricter check for valid integers ... 57889e688dd0987a1e087cd48d216a413127601e bitcoin-tx: Stricter check for valid integers (Daniel Kraft) Pull request description: Just calling `atoi` to convert strings to integers does not check for valid integers very thoroughly; in particular, it just ignores everything starting from the first non-numeral character. Even a string like "foo" is fine and silently returns 0. This meant that `bitcoin-tx` would not fail if such a string was passed in various places where an integer is expected (like the `locktime` or an input/output index); this means that it would, for instance, silently accept a typo and interpret it in an unexpected way. In this change, we use `ParseInt64` for parsing strings to integers, which actually verifies that the full string is valid as number. New tests in the `bitcoin-util-test` cover the new error paths. This fixes #13599. Tree-SHA512: 146a0af275e9f57784e5d0582d3defbac35551b54b6b7232f8a0b20db04aa611125e52aa4512ef2f8ed2cafc2a12fe586f9d10ed66d641cff090288f279b1988		2020-12-18 12:55:45 -06:00
..
data	Merge #13603: bitcoin-tx: Stricter check for valid integers	2020-12-18 12:55:45 -06:00
bitcoin-util-test.py	Merge #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python	2020-07-07 11:50:56 -05:00
rpcauth-test.py	Add missing encoding="utf8"	2020-07-29 11:04:42 -05:00