mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
42d4f9a9b9
BACKPORT NOTE:
the field `banscore` is used by functional test p2p_quorum_data.py and can't be removed now
454a4088a87eac5878070b26d13d5574da891877 [doc] Add release notes for removed getpeerinfo fields. (Amiti Uttarwar)
b1a936d4ae7dd9030b0720ef05579a90ce2894f1 [rpc] Remove deprecated "whitelisted" field from getpeerinfo (Amiti Uttarwar)
094c3beaa47c909070607e94f2544ed1472ddb17 [rpc] Remove deprecated "banscore" field from getpeerinfo (Amiti Uttarwar)
537053336fbc1b633e7c99286c3e3492eaca1e9d [rpc] Remove deprecated "addnode" field from getpeerinfo (Amiti Uttarwar)
Pull request description:
This PR removes support for 3 fields on the `getpeerinfo` RPC that were deprecated in v0.21- `addnode`, `banscore` & `whitelisted`.
ACKs for top commit:
sipa:
utACK 454a4088a87eac5878070b26d13d5574da891877
jnewbery:
ACK 454a4088a87eac5878070b26d13d5574da891877.
Tree-SHA512: ccc0e90c0763eeb8529cf0c46162dbaca3f7773981b3b52d9925166ea7421aed086795d56b320e16c9340f68862388785f52a9b78314865070917b33180d7cd6
28 lines
991 B
Python
Executable File
28 lines
991 B
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test deprecation of getpeerinfo RPC fields."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
|
|
class GetpeerinfoDeprecationTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.extra_args = [[], ["-deprecatedrpc=banscore"]]
|
|
|
|
def run_test(self):
|
|
self.test_banscore_deprecation()
|
|
|
|
def test_banscore_deprecation(self):
|
|
self.log.info("Test getpeerinfo by default no longer returns a banscore field")
|
|
assert "banscore" not in self.nodes[0].getpeerinfo()[0].keys()
|
|
|
|
self.log.info("Test getpeerinfo returns banscore with -deprecatedrpc=banscore")
|
|
assert "banscore" in self.nodes[1].getpeerinfo()[0].keys()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
GetpeerinfoDeprecationTest().main()
|