dash/src/evo
Odysseas Gabrielides 49271358ee
fix: non-aligned BLS serialization within MNLISTDIFF (#5151)
## Issue being fixed or feature implemented
When constructing `CSimplifiedMNListDiff`,
`CSimplifiedMNListDiff::nVersion` is set to 2 if the v19 fork is active.
It turns out that `CSimplifiedMNListEntry::nVersion` wasn't set to 2 as
well as it was supposed.

Because we used `emplace_back` when filling the list of
`CSimplifiedMNListEntry`, this actually constructed the object with the
default value of 1 instead of copying it.

Surprising but I managed to see that while debugging.

## What was done?

## How Has This Been Tested?


## Breaking Changes


## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation

**For repository code-owners and collaborators only**
- [x] I have assigned this pull request to a milestone

Co-authored-by: pasta <pasta@dashboost.org>
2023-01-10 14:53:14 -06:00
..
cbtx.cpp merge bitcoin#21415: remove Optional & nullopt 2022-10-20 16:08:45 -05:00
cbtx.h refactor: pass references to objects instead of using global definitions (#4988) 2022-09-22 15:14:48 +04:00
deterministicmns.cpp fix: non-aligned BLS serialization within MNLISTDIFF (#5151) 2023-01-10 14:53:14 -06:00
deterministicmns.h refactor: Removed old evo/deterministicmns parts (#5113) 2022-12-26 18:58:51 -06:00
dmnstate.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
dmnstate.h fix: preserve the original order of fields in CDeterministicMNStateDiff (#5139) 2023-01-10 13:06:44 -06:00
evodb.cpp refactor: remove the g_evoDb global; use NodeContext and locals (#5058) 2022-12-10 11:58:17 -06:00
evodb.h refactor: remove the g_evoDb global; use NodeContext and locals (#5058) 2022-12-10 11:58:17 -06:00
mnauth.cpp refactor: begin to de-globalize masternodeSync (#5103) 2023-01-04 23:37:20 +03:00
mnauth.h feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
mnhftx.cpp feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
mnhftx.h feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
providertx.cpp feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
providertx.h feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
simplifiedmns.cpp feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
simplifiedmns.h feat!: BLS scheme upgrade (#5021) 2022-12-29 23:45:31 -06:00
specialtx.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
specialtx.h test/refactor: upgrade to cppcheck 2.9 and fix warnings (#5049) 2022-10-18 13:24:00 +03:00
specialtxman.cpp refactor: pass references to objects instead of using global definitions (#4988) 2022-09-22 15:14:48 +04:00
specialtxman.h refactor: pass references to objects instead of using global definitions (#4988) 2022-09-22 15:14:48 +04:00