mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
a11743f009
faa9a74c9e99eb43ba0d27fa906767ee88011aeb test: Fail wait_until early if connection is lost (MarcoFalke)
Pull request description:
Calling `minonode.wait_until` needs a connection to make progress (e.g. waiting for an inv), unless the mininode waits for the initial connection or for a disconnection. So for test development and failure debugging, fail early in all `wait_until`, unless opted out.
ACKs for top commit:
jnewbery:
Code review ACK faa9a74c9e99eb43ba0d27fa906767ee88011aeb.
Tree-SHA512: 4be850b96e23b87bc2ff42c028a5045d6f5cdbc9482ce6a6ba01cc5eb26710dab9e2ed547c363aac4bd5825151ee9996fb797261420b631bceeddbfa698d1dec
123 lines
5.0 KiB
Python
Executable File
123 lines
5.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test ping message
|
|
"""
|
|
|
|
import time
|
|
|
|
from test_framework.messages import msg_pong
|
|
from test_framework.p2p import P2PInterface
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
PING_INTERVAL = 2 * 60
|
|
|
|
|
|
class msg_pong_corrupt(msg_pong):
|
|
def serialize(self):
|
|
return b""
|
|
|
|
|
|
class NodePongAdd1(P2PInterface):
|
|
def on_ping(self, message):
|
|
self.send_message(msg_pong(message.nonce + 1))
|
|
|
|
|
|
class NodeNoPong(P2PInterface):
|
|
def on_ping(self, message):
|
|
pass
|
|
|
|
|
|
class PingPongTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [['-peertimeout=3']]
|
|
|
|
def check_peer_info(self, *, pingtime, minping, pingwait):
|
|
stats = self.nodes[0].getpeerinfo()[0]
|
|
assert_equal(stats.pop('pingtime', None), pingtime)
|
|
assert_equal(stats.pop('minping', None), minping)
|
|
assert_equal(stats.pop('pingwait', None), pingwait)
|
|
|
|
def mock_forward(self, delta):
|
|
self.mock_time += delta
|
|
self.nodes[0].setmocktime(self.mock_time)
|
|
|
|
def run_test(self):
|
|
self.mock_time = int(time.time())
|
|
self.mock_forward(0)
|
|
|
|
self.log.info('Check that ping is sent after connection is established')
|
|
no_pong_node = self.nodes[0].add_p2p_connection(NodeNoPong())
|
|
self.mock_forward(3)
|
|
assert no_pong_node.last_message.pop('ping').nonce != 0
|
|
self.check_peer_info(pingtime=None, minping=None, pingwait=3)
|
|
|
|
self.log.info('Reply without nonce cancels ping')
|
|
with self.nodes[0].assert_debug_log(['pong peer=0: Short payload']):
|
|
no_pong_node.send_and_ping(msg_pong_corrupt())
|
|
self.check_peer_info(pingtime=None, minping=None, pingwait=None)
|
|
|
|
self.log.info('Reply without ping')
|
|
with self.nodes[0].assert_debug_log([
|
|
'pong peer=0: Unsolicited pong without ping, 0 expected, 0 received, 8 bytes',
|
|
]):
|
|
no_pong_node.send_and_ping(msg_pong())
|
|
self.check_peer_info(pingtime=None, minping=None, pingwait=None)
|
|
|
|
self.log.info('Reply with wrong nonce does not cancel ping')
|
|
assert 'ping' not in no_pong_node.last_message
|
|
with self.nodes[0].assert_debug_log(['pong peer=0: Nonce mismatch']):
|
|
# mock time PING_INTERVAL ahead to trigger node into sending a ping
|
|
self.mock_forward(PING_INTERVAL + 1)
|
|
no_pong_node.wait_until(lambda: 'ping' in no_pong_node.last_message)
|
|
self.mock_forward(9)
|
|
# Send the wrong pong
|
|
no_pong_node.send_and_ping(msg_pong(no_pong_node.last_message.pop('ping').nonce - 1))
|
|
self.check_peer_info(pingtime=None, minping=None, pingwait=9)
|
|
|
|
self.log.info('Reply with zero nonce does cancel ping')
|
|
with self.nodes[0].assert_debug_log(['pong peer=0: Nonce zero']):
|
|
no_pong_node.send_and_ping(msg_pong(0))
|
|
self.check_peer_info(pingtime=None, minping=None, pingwait=None)
|
|
|
|
self.log.info('Check that ping is properly reported on RPC')
|
|
assert 'ping' not in no_pong_node.last_message
|
|
# mock time PING_INTERVAL ahead to trigger node into sending a ping
|
|
self.mock_forward(PING_INTERVAL + 1)
|
|
no_pong_node.wait_until(lambda: 'ping' in no_pong_node.last_message)
|
|
ping_delay = 29
|
|
self.mock_forward(ping_delay)
|
|
no_pong_node.wait_until(lambda: 'ping' in no_pong_node.last_message)
|
|
no_pong_node.send_and_ping(msg_pong(no_pong_node.last_message.pop('ping').nonce))
|
|
# TODO this check doesn't work due to partial 18638
|
|
# re-enable it after #19499 is done
|
|
# self.check_peer_info(pingtime=ping_delay, minping=ping_delay, pingwait=None)
|
|
|
|
self.log.info('Check that minping is decreased after a fast roundtrip')
|
|
# mock time PING_INTERVAL ahead to trigger node into sending a ping
|
|
self.mock_forward(PING_INTERVAL + 1)
|
|
no_pong_node.wait_until(lambda: 'ping' in no_pong_node.last_message)
|
|
ping_delay = 9
|
|
self.mock_forward(ping_delay)
|
|
no_pong_node.wait_until(lambda: 'ping' in no_pong_node.last_message)
|
|
no_pong_node.send_and_ping(msg_pong(no_pong_node.last_message.pop('ping').nonce))
|
|
# TODO this check doesn't work due to partial 18638
|
|
# re-enable it after #19499 is done
|
|
# self.check_peer_info(pingtime=ping_delay, minping=ping_delay, pingwait=None)
|
|
|
|
self.log.info('Check that peer is disconnected after ping timeout')
|
|
assert 'ping' not in no_pong_node.last_message
|
|
self.nodes[0].ping()
|
|
no_pong_node.wait_until(lambda: 'ping' in no_pong_node.last_message)
|
|
with self.nodes[0].assert_debug_log(['ping timeout: 1201.000000s']):
|
|
self.mock_forward(20 * 60 + 1)
|
|
time.sleep(4) # peertimeout + 1
|
|
|
|
|
|
if __name__ == '__main__':
|
|
PingPongTest().main()
|