mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
4a5dd0d80f
1499fdc350 Add shell script linting: Check for shellcheck warnings in shell scripts (practicalswift)
Pull request description:
Add shell script linting: Check for `shellcheck` warnings in shell scripts.
Tree-SHA512: c7f3f5ed9933415666d2a02f5658cdc62b959ce8112f46b6327ff5f77bb5a66710704c0cde5fd8e719d1fa1fc4f0375a0c115faced166b78e81b75dfb862f08e
Signed-off-by: pasta <pasta@dashboost.org>
28 lines
1.5 KiB
Bash
Executable File
28 lines
1.5 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check for shellcheck warnings in shell scripts.
|
|
|
|
# Disabled warnings:
|
|
# SC2001: See if you can use ${variable//search/replace} instead.
|
|
# SC2004: $/${} is unnecessary on arithmetic variables.
|
|
# SC2005: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
|
|
# SC2006: Use $(..) instead of legacy `..`.
|
|
# SC2016: Expressions don't expand in single quotes, use double quotes for that.
|
|
# SC2028: echo won't expand escape sequences. Consider printf.
|
|
# SC2046: Quote this to prevent word splitting.
|
|
# SC2048: Use "$@" (with quotes) to prevent whitespace problems.
|
|
# SC2066: Since you double quoted this, it will not word split, and the loop will only run once.
|
|
# SC2086: Double quote to prevent globbing and word splitting.
|
|
# SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
|
|
# SC2148: Tips depend on target shell and yours is unknown. Add a shebang.
|
|
# SC2162: read without -r will mangle backslashes.
|
|
# SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
|
|
# SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
|
|
# SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
|
|
shellcheck -e SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181 \
|
|
$(git ls-files -- "*.sh" | grep -vE 'src/(secp256k1|univalue)/')
|