dash/src
Wladimir J. van der Laan dc914a32bc Merge #13791: gui: Reject dialogs if key escape is pressed
7bf22bf0c21d13557ec46a67413819ebcabc3df0 gui: Reject options dialog when key escape is pressed (João Barbosa)
4a43306a4f643cf0d356d5d5e16913541f1bc893 gui: Reject edit address dialog when key escape is pressed (João Barbosa)
f7a553177d4b969956bc04a0140fce34958971f5 gui: Add GUIUtil::ItemDelegate with keyEscapePressed signal (João Barbosa)

Pull request description:

  Currently `EditAddressDialog` and `OptionsDialog` don't close when the escape key is pressed. The `QDataWidgetMapper` instances prevents closing the dialogs because the escape key is used to reset the widgets values. More details and workarounds in https://stackoverflow.com/a/51487847 and http://qtramblings.blogspot.com/2010/10/qdatawidgetmapper-annoyances.html.

  The adopted solution is different from the above references. It turns out that `QDataWidgetMapper::setItemDelegate` sets the event filter for all mapped widgets. So in this PR the mapper's delegate are changed to a custom `GUIUtil::ItemDelegate` that offers the signal `keyEscapePressed`, which is connected to the `QDialog::reject` slot.

  Note that the installed event filter lets all events pass, so the current behaviour isn't changed, meaning that widgets values are reset in addition to closing the dialog.

Tree-SHA512: 9c961d488480b4ccc3880a11a8f1824b65f77570ee8918c7302c62775a1a73e52ae988a31a55ffff87b4170ddbecf833c2f09b66095c00eb6854a4d43f030f1f
2020-07-28 21:35:31 -05:00
..
bench Merge #13711: [bench] Add benchmark for unserialize prevector 2020-07-28 20:26:57 -05:00
bls remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
compat Merge #12998: Default to defining endian-conversion DECLs in compat w/o config 2020-04-03 04:10:53 -05:00
config
consensus scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
crypto scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
evo Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
governance scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
immer scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
leveldb Merge #12518: [0.16] Bump leveldb subtree 2020-03-24 11:43:10 -05:00
llmq Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
masternode Create one PS manager per wallet 2020-07-20 10:10:43 -05:00
obj
obj-test
policy Merge pull request #3618 from PastaPastaPasta/backports-0.17-pr16 2020-07-20 18:03:11 +03:00
primitives Merge #12731: Support serialization as another type without casting 2020-06-11 23:20:48 -05:00
privatesend privatesend|qt|rpc|wallet: Improve CPrivateSendClientOptions 2020-07-20 10:15:59 -05:00
qt Merge #13791: gui: Reject dialogs if key escape is pressed 2020-07-28 21:35:31 -05:00
rpc scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
script scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
secp256k1 Merge #15703: Update secp256k1 subtree to latest upstream 2020-03-14 11:01:03 -05:00
support Merge #11878: Add Travis check for duplicate includes 2020-07-01 20:12:03 -05:00
test scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
univalue Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (#3532) 2020-06-18 12:17:23 +03:00
wallet Fix crash on splash screen when wallet fails to load (#3629) 2020-07-28 23:50:23 +03:00
zmq Merge #13570: RPC: Add new "getzmqnotifications" method 2020-07-17 15:42:49 -05:00
.clang-format Merge #12982: Fix inconsistent namespace formatting guidelines 2020-06-27 10:43:32 -05:00
addrdb.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2020-04-01 12:43:18 -05:00
addrdb.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
addressindex.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
addrman.cpp scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
addrman.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
amount.h
arith_uint256.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
arith_uint256.h Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator 2020-06-13 14:50:11 -05:00
base58.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
base58.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
batchedlogger.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
batchedlogger.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
bip39_english.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
bip39.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
bip39.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
blockencodings.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
blockencodings.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
blockfilter.cpp Merge #14073: blockfilter: Avoid out-of-bounds script access. 2020-06-13 14:08:18 -05:00
blockfilter.h Rename BlockFilterType::BASIC to BASIC_FILTER 2020-06-13 14:08:18 -05:00
bloom.cpp scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
bloom.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
cachemap.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
cachemultimap.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
chain.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
chain.h Merge #13234: Break circular dependency: chain -> pow -> chain 2020-07-01 14:08:47 -05:00
chainparams.cpp privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
chainparams.h Merge #13012: [doc] Add comments for chainparams.h, validation.cpp 2020-07-21 11:54:50 -05:00
chainparamsbase.cpp Merge #13690: [moveonly] Extract MakeUnique into utilmemory.h 2020-07-26 19:39:13 -05:00
chainparamsbase.h Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections 2020-05-09 17:35:59 -05:00
chainparamsseeds.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
checkpoints.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2020-04-01 12:43:18 -05:00
checkpoints.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
checkqueue.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
clientversion.cpp scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
clientversion.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
coins.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2020-04-01 12:43:18 -05:00
coins.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
compat.h Merge pull request #3445 from codablock/pr_epoll 2020-04-22 17:10:33 +02:00
compressor.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
compressor.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
core_io.h Merge #13422: Drop ParseHashUV in favor of calling ParseHashStr 2020-07-07 11:39:35 -05:00
core_memusage.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
core_read.cpp Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency 2020-07-17 15:42:20 -05:00
core_write.cpp Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (#3532) 2020-06-18 12:17:23 +03:00
ctpl.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
cuckoocache.h Merge #12716: Fix typos and cleanup in various files 2020-06-11 23:20:48 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running 2020-06-13 14:50:11 -05:00
dash-tx-res.rc
dash-tx.cpp Merge #13422: Drop ParseHashUV in favor of calling ParseHashStr 2020-07-07 11:39:35 -05:00
dashd-res.rc
dashd.cpp Merge #13740: trivial: remove unneeded include 2020-07-28 20:14:46 -05:00
dbwrapper.cpp Merge #12659: Improve Fatal LevelDB Log Messages 2020-06-18 11:41:53 -05:00
dbwrapper.h Merge #12604: Add DynamicMemoryUsage() to CDBWrapper to estimate LevelDB memory use 2020-06-14 11:41:07 -05:00
dsnotificationinterface.cpp Create one PS manager per wallet 2020-07-20 10:10:43 -05:00
dsnotificationinterface.h Fix issues introduced with asynchronous signal handling (#3369) 2020-03-20 19:11:54 +03:00
flat-database.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
fs.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
fs.h
hash.cpp Merge #11884: Remove unused include in hash.cpp 2020-03-24 11:43:10 -05:00
hash.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
hdchain.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
hdchain.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
httprpc.cpp scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
httprpc.h
httpserver.cpp Merge pull request #3518 from PastaPastaPasta/backports-0.17-pr1 2020-06-11 20:51:58 +03:00
httpserver.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
indirectmap.h
init.cpp Merge pull request #3621 from PastaPastaPasta/backports-0.17-pr17 2020-07-28 23:48:37 +03:00
init.h scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
keepass.cpp Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (#3532) 2020-06-18 12:17:23 +03:00
keepass.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
key.cpp Merge #9598: Improve readability by removing redundant casts to same type (on all platforms) 2020-06-18 11:41:53 -05:00
key.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
keystore.cpp Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size 2020-07-26 19:39:13 -05:00
keystore.h Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore 2020-07-17 15:42:20 -05:00
limitedmap.h Add cache for CBlockTreeDB::HasTxIndex (#3402) 2020-04-08 22:18:33 +02:00
logging.cpp Fix 13021 2020-07-19 10:34:16 -05:00
logging.h Merge #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. 2020-07-18 03:08:13 -05:00
Makefile.am Merge #13690: [moveonly] Extract MakeUnique into utilmemory.h 2020-07-26 19:39:13 -05:00
Makefile.bench.include Merge #13312: docs: Add a note about the source code filename naming convention 2020-07-07 11:17:45 -05:00
Makefile.leveldb.include Merge #10806: build: verify that the assembler can handle crc32 functions 2019-07-17 19:01:41 -05:00
Makefile.qt.include qt: Drop PlatformStyle (#3573) 2020-07-26 14:20:19 +03:00
Makefile.qttest.include Merge #13408: crypto: cleanup sha256 build 2019-10-01 23:20:06 +02:00
Makefile.test.include Merge #13056: [tests] Make rpcauth.py testable and add unit tests 2020-07-22 12:12:46 -05:00
memusage.h Bugfix: Include <memory> for std::unique_ptr 2020-04-08 11:46:27 -05:00
merkleblock.cpp Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage 2020-04-08 11:46:27 -05:00
merkleblock.h Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage 2020-04-08 11:46:27 -05:00
messagesigner.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
messagesigner.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
miner.cpp Merge #13480: Avoid copies in range-for loops and add a warning to detect them 2020-07-08 18:32:04 -05:00
miner.h Merge #11689: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…) 2020-07-01 14:08:47 -05:00
net_processing.cpp Create one PS manager per wallet 2020-07-20 10:10:43 -05:00
net_processing.h Merge #13615: net: Remove unused interrupt from SendMessages 2020-07-08 20:03:37 -05:00
net.cpp Merge #13824: doc: Remove outdated net comment 2020-07-17 15:45:43 -05:00
net.h Merge #13679: Initialize m_next_send_inv_to_incoming 2020-07-26 19:39:13 -05:00
netaddress.cpp Merge pull request #3518 from PastaPastaPasta/backports-0.17-pr1 2020-06-11 20:51:58 +03:00
netaddress.h Merge #14728: fix uninitialized read when stringifying an addrLocal 2020-06-09 19:06:54 -05:00
netbase.cpp Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency 2020-07-17 15:42:20 -05:00
netbase.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
netfulfilledman.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
netfulfilledman.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
netmessagemaker.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
noui.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
noui.h
pow.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
pow.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
prevector.h Speed up prevector initialization and vector assignment from prevectors (#3274) 2020-01-08 08:02:17 +01:00
protocol.cpp Merge bitcoin#10387: Eventually connect to NODE_NETWORK_LIMITED peers (#3417) 2020-04-19 16:21:47 +03:00
protocol.h Merge #12731: Support serialization as another type without casting 2020-06-11 23:20:48 -05:00
pubkey.cpp Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible 2020-07-28 20:08:40 -05:00
pubkey.h Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size 2020-07-26 19:39:13 -05:00
random.cpp Merge #13236: break circular dependency: random/sync -> util -> random/sync 2020-07-18 03:08:13 -05:00
random.h Merge #12716: Fix typos and cleanup in various files 2020-06-11 23:20:48 -05:00
rest.cpp Merge #13259: refactoring: add a method for determining if a block is pruned or not 2020-07-01 20:12:03 -05:00
reverse_iterator.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
reverselock.h
saltedhasher.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
saltedhasher.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
scheduler.cpp Merge #11824: Block ActivateBestChain to empty validationinterface queue 2020-03-24 17:21:59 +03:00
scheduler.h Merge #13835: [trivial,doc] Fix memory consistency model in comment 2020-07-17 15:45:43 -05:00
serialize.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
spentindex.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
spork.cpp privatesend: Increase max participants to 20 (#3610) 2020-07-17 13:19:29 +03:00
spork.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
stacktraces.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
stacktraces.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
streams.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
sync.cpp Merge #13236: break circular dependency: random/sync -> util -> random/sync 2020-07-18 03:08:13 -05:00
sync.h Merge #13423: [net] Thread safety annotations in net_processing 2020-06-08 20:27:14 -05:00
threadinterrupt.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
threadinterrupt.h
threadsafety.h Merge #13423: [net] Thread safety annotations in net_processing 2020-06-08 20:27:14 -05:00
timedata.cpp Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} 2020-06-28 19:28:57 -05:00
timedata.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
tinyformat.h Merge #12716: Fix typos and cleanup in various files 2020-06-11 23:20:48 -05:00
torcontrol.cpp Merge #13291: test: Don't include torcontrol.cpp into the test file 2020-07-01 14:08:47 -05:00
torcontrol.h Backport 12381 (#3528) 2020-06-13 21:21:30 +03:00
txdb.cpp scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
txdb.h Merge #12731: Support serialization as another type without casting 2020-06-11 23:20:48 -05:00
txmempool.cpp scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
txmempool.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
ui_interface.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
ui_interface.h Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable" 2020-01-03 08:35:55 -06:00
uint256.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
uint256.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
undo.h Merge #12254: BIP 158: Compact Block Filters for Light Clients 2020-06-13 14:08:18 -05:00
unordered_lru_cache.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
util.cpp remove unneeded boost string includes 2020-07-28 11:45:26 -05:00
util.h Remove unused code and assosiated tests that were only used by old mnlist 2020-07-26 20:35:39 -05:00
utilmemory.h Merge #13690: [moveonly] Extract MakeUnique into utilmemory.h 2020-07-26 19:39:13 -05:00
utilmoneystr.cpp Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
utilmoneystr.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
utilstrencodings.cpp Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency 2020-07-17 15:42:20 -05:00
utilstrencodings.h Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency 2020-07-17 15:42:20 -05:00
utiltime.cpp remove duplicate includes so that ./contrib/devtools/lint-includes.sh is clean 2020-07-01 20:12:03 -05:00
utiltime.h Merge #16046: util: Add type safe GetTime 2020-04-08 14:50:07 +02:00
validation.cpp Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency 2020-07-26 19:39:13 -05:00
validation.h scripted-diff: Merge #13753: Remove trailing whitespaces 2020-07-28 20:23:12 -05:00
validationinterface.cpp Merge #11824: Block ActivateBestChain to empty validationinterface queue 2020-03-24 17:21:59 +03:00
validationinterface.h Merge #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model 2020-07-17 15:45:43 -05:00
version.h Verify min proto version and open ports of LLMQ members and vote on bad ones 2020-03-31 07:07:52 +02:00
versionbits.cpp scripted-diff: Convert 11 enums into scoped enums (C++11) (merge #10742) 2020-06-11 23:20:48 -05:00
versionbits.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
walletinitinterface.h Merge #12757: Clarify include guard naming convention 2020-07-19 00:42:54 -05:00
warnings.cpp Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} 2020-06-28 19:28:57 -05:00
warnings.h Merge #13895: Docs: fix GetWarnings docs to reflect behavior 2020-07-17 15:45:43 -05:00