mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
b07a7b810c
* Merge #11796: [tests] Functional test naming convention5fecd84
[tests] Remove redundant import in blocktools.py test (Anthony Towns)9b20bb4
[tests] Check tests conform to naming convention (Anthony Towns)7250b4e
[tests] README.md nit fixes (Anthony Towns)82b2712
[tests] move witness util functions to blocktools.py (John Newbery)1e10854
[tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting #11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80 * update violation count Signed-off-by: pasta <pasta@dashboost.org> * Merge #11774: [tests] Rename functional tests6f881cc880
[tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns)3150b3fea7
[tests] Rename misc functional tests. (Anthony Towns)81b79f2c39
[tests] Rename rpc_* functional tests. (Anthony Towns)61b8f7f273
[tests] Rename p2p_* functional tests. (Anthony Towns)90600bc7db
[tests] Rename wallet_* functional tests. (Anthony Towns)ca6523d0c8
[tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16 * rename tests and edit associated strings to align test-suite with test name standards Signed-off-by: pasta <pasta@dashboost.org> * fix grammar in test/functional/test_runner.py Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * ci: Fix excluded test names * rename feature_privatesend.py to rpc_privatesend.py Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com> Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
143 lines
6.3 KiB
Python
Executable File
143 lines
6.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the prioritisetransaction mining RPC."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import *
|
|
from test_framework.mininode import COIN, MAX_BLOCK_SIZE
|
|
|
|
class PrioritiseTransactionTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 2
|
|
self.extra_args = [["-printpriority=1"]] * 2
|
|
|
|
def run_test(self):
|
|
# Test `prioritisetransaction` required parameters
|
|
assert_raises_rpc_error(-1, "prioritisetransaction", self.nodes[0].prioritisetransaction)
|
|
assert_raises_rpc_error(-1, "prioritisetransaction", self.nodes[0].prioritisetransaction, '')
|
|
|
|
# Test `prioritisetransaction` invalid extra parameters
|
|
assert_raises_rpc_error(-1, "prioritisetransaction", self.nodes[0].prioritisetransaction, '', 0, 0)
|
|
|
|
# Test `prioritisetransaction` invalid `txid`
|
|
assert_raises_rpc_error(-1, "txid must be hexadecimal string", self.nodes[0].prioritisetransaction, txid='foo', fee_delta=0)
|
|
|
|
txid = '1d1d4e24ed99057e84c3f80fd8fbec79ed9e1acee37da269356ecea000000000'
|
|
|
|
# Test `prioritisetransaction` invalid `fee_delta`
|
|
assert_raises_rpc_error(-1, "JSON value is not an integer as expected", self.nodes[0].prioritisetransaction, txid=txid, fee_delta='foo')
|
|
|
|
self.txouts = gen_return_txouts()
|
|
self.relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
|
|
utxo_count = 90
|
|
utxos = create_confirmed_utxos(self.relayfee, self.nodes[0], utxo_count)
|
|
base_fee = self.relayfee*100 # our transactions are smaller than 100kb
|
|
txids = []
|
|
|
|
# Create 3 batches of transactions at 3 different fee rate levels
|
|
range_size = utxo_count // 3
|
|
for i in range(3):
|
|
txids.append([])
|
|
start_range = i * range_size
|
|
end_range = start_range + range_size
|
|
txids[i] = create_lots_of_big_transactions(self.nodes[0], self.txouts, utxos[start_range:end_range], end_range - start_range, (i+1)*base_fee)
|
|
|
|
# Make sure that the size of each group of transactions exceeds
|
|
# MAX_BLOCK_SIZE -- otherwise the test needs to be revised to create
|
|
# more transactions.
|
|
mempool = self.nodes[0].getrawmempool(True)
|
|
sizes = [0, 0, 0]
|
|
for i in range(3):
|
|
for j in txids[i]:
|
|
assert(j in mempool)
|
|
sizes[i] += mempool[j]['size']
|
|
assert(sizes[i] > MAX_BLOCK_SIZE) # Fail => raise utxo_count
|
|
|
|
# add a fee delta to something in the cheapest bucket and make sure it gets mined
|
|
# also check that a different entry in the cheapest bucket is NOT mined
|
|
self.nodes[0].prioritisetransaction(txids[0][0], int(3*base_fee*COIN))
|
|
|
|
self.nodes[0].generate(1)
|
|
|
|
mempool = self.nodes[0].getrawmempool()
|
|
self.log.info("Assert that prioritised transaction was mined")
|
|
assert(txids[0][0] not in mempool)
|
|
assert(txids[0][1] in mempool)
|
|
|
|
high_fee_tx = None
|
|
for x in txids[2]:
|
|
if x not in mempool:
|
|
high_fee_tx = x
|
|
|
|
# Something high-fee should have been mined!
|
|
assert(high_fee_tx != None)
|
|
|
|
# Add a prioritisation before a tx is in the mempool (de-prioritising a
|
|
# high-fee transaction so that it's now low fee).
|
|
self.nodes[0].prioritisetransaction(high_fee_tx, -int(2*base_fee*COIN))
|
|
|
|
# Add everything back to mempool
|
|
self.nodes[0].invalidateblock(self.nodes[0].getbestblockhash())
|
|
|
|
# Check to make sure our high fee rate tx is back in the mempool
|
|
mempool = self.nodes[0].getrawmempool()
|
|
assert(high_fee_tx in mempool)
|
|
|
|
# Now verify the modified-high feerate transaction isn't mined before
|
|
# the other high fee transactions. Keep mining until our mempool has
|
|
# decreased by all the high fee size that we calculated above.
|
|
while (self.nodes[0].getmempoolinfo()['bytes'] > sizes[0] + sizes[1]):
|
|
self.nodes[0].generate(1)
|
|
|
|
# High fee transaction should not have been mined, but other high fee rate
|
|
# transactions should have been.
|
|
mempool = self.nodes[0].getrawmempool()
|
|
self.log.info("Assert that de-prioritised transaction is still in mempool")
|
|
assert(high_fee_tx in mempool)
|
|
for x in txids[2]:
|
|
if (x != high_fee_tx):
|
|
assert(x not in mempool)
|
|
|
|
# Create a free transaction. Should be rejected.
|
|
utxo_list = self.nodes[0].listunspent()
|
|
assert(len(utxo_list) > 0)
|
|
utxo = utxo_list[0]
|
|
|
|
inputs = []
|
|
outputs = {}
|
|
inputs.append({"txid" : utxo["txid"], "vout" : utxo["vout"]})
|
|
outputs[self.nodes[0].getnewaddress()] = utxo["amount"]
|
|
raw_tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
tx_hex = self.nodes[0].signrawtransaction(raw_tx)["hex"]
|
|
tx_id = self.nodes[0].decoderawtransaction(tx_hex)["txid"]
|
|
|
|
# This will raise an exception due to min relay fee not being met
|
|
assert_raises_rpc_error(-26, "min relay fee not met (code 66)", self.nodes[0].sendrawtransaction, tx_hex)
|
|
assert(tx_id not in self.nodes[0].getrawmempool())
|
|
|
|
# This is a less than 1000-byte transaction, so just set the fee
|
|
# to be the minimum for a 1000-byte transaction and check that it is
|
|
# accepted.
|
|
self.nodes[0].prioritisetransaction(tx_id, int(self.relayfee*COIN))
|
|
|
|
self.log.info("Assert that prioritised free transaction is accepted to mempool")
|
|
assert_equal(self.nodes[0].sendrawtransaction(tx_hex), tx_id)
|
|
assert(tx_id in self.nodes[0].getrawmempool())
|
|
|
|
# Test that calling prioritisetransaction is sufficient to trigger
|
|
# getblocktemplate to (eventually) return a new block.
|
|
self.nodes[0].setmocktime(self.mocktime)
|
|
template = self.nodes[0].getblocktemplate()
|
|
self.nodes[0].prioritisetransaction(tx_id, -int(self.relayfee*COIN))
|
|
self.nodes[0].setmocktime(self.mocktime+10)
|
|
new_template = self.nodes[0].getblocktemplate()
|
|
|
|
assert(template != new_template)
|
|
|
|
if __name__ == '__main__':
|
|
PrioritiseTransactionTest().main()
|