dash/src
MarcoFalke 4af8db6d33 Merge #11031: [rpc] deprecate estimatefee
048e0c3e2 [rpc] [tests] Add deprecated RPC test (Cristian Mircea Messel)
d4cdbd6fb [rpc] Deprecate estimatefee RPC (John Newbery)

Pull request description:

  Deprecates estimatefee in v0.16, for final removal in v0.17.

  This commit introduces a phased removal of RPC methods. RPC method is
  disabled by default in version x, but can be enabled by using the
  `-deprecatedrpc=<methodname>` argument. RPC method is removed entirely in version
  (x+1).

  This gives users fair warning that an RPC is to be removed, and time to change client software if necessary. Deprecation warnings in RPC return values or release notes are easily ignored.

  This is a more generic version of the approach I tried to use in #10841, which too late to make it into v0.15.

Tree-SHA512: 9695a600e84b812974387333e4a6805d18972da30befb754e9e4da77cd9815d00c5cc2ee0b0350bdbbdb5fdc6ba47789f8b2c6f5b15c8cd5a1deefcc4832da30
2020-01-11 18:47:34 -06:00
..
bench More of 10793 2020-01-10 10:34:03 -06:00
bls More of 10969 2020-01-10 10:34:03 -06:00
compat Merge #11144: Move local include to before system includes 2020-01-01 22:31:14 -06:00
config
consensus Use smaller LLMQs in regtest (#3269) 2020-01-07 13:49:51 +01:00
crypto Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
evo More of 10969 2020-01-10 10:34:03 -06:00
governance More of 10969 2020-01-10 10:34:03 -06:00
immer
leveldb Merge #10958: Update to latest Bitcoin patches for LevelDB 2019-08-12 09:07:03 -05:00
llmq More of 10969 2020-01-10 10:34:03 -06:00
masternode More of 10969 2020-01-10 10:34:03 -06:00
obj
obj-test
policy Merge #10682: Trivial: Move the AreInputsStandard documentation next to its implementation 2020-01-01 22:31:14 -06:00
primitives keep nVersion as 16 byte integer 2020-01-10 10:33:58 -06:00
privatesend [Pretty Trivial] Adjust some comments (#3252) 2020-01-08 08:02:49 +01:00
qt More of 10793 2020-01-10 10:34:03 -06:00
rpc Merge #11031: [rpc] deprecate estimatefee 2020-01-11 18:47:34 -06:00
script Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
secp256k1
support Merge #11351: Refactor: Modernize disallowed copy constructors/assignment 2020-01-11 18:22:25 -06:00
test More of 10793 2020-01-10 10:34:03 -06:00
univalue Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
wallet Merge #11351: Refactor: Modernize disallowed copy constructors/assignment 2020-01-11 18:22:25 -06:00
zmq Merge #10809: optim: mark a few classes final 2020-01-02 22:01:29 -06:00
.clang-format \#10193 clang-format: Delete ForEachMacros 2019-07-24 11:59:09 -05:00
addrdb.cpp
addrdb.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
addressindex.h
addrman.cpp Respect logips config option in few more log outputs (#3078) 2019-09-22 23:48:15 +03:00
addrman.h Merge #11252: [P2P] When clearing addrman clear mapInfo and mapAddr. (#3171) 2019-10-23 09:56:30 +02:00
amount.h
arith_uint256.cpp
arith_uint256.h Merge #11071: Use static_assert(…, …) (C++11) instead of assert(…) where appropriate 2020-01-01 21:32:57 -06:00
base58.cpp More of 10793 2020-01-10 10:34:03 -06:00
base58.h #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
batchedlogger.cpp
batchedlogger.h
bip39_english.h
bip39.cpp More of 10793 2020-01-10 10:34:03 -06:00
bip39.h
blockencodings.cpp
blockencodings.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
bloom.cpp #10193 scripted-diff: Remove #include <boost/foreach.hpp> 2019-07-24 11:59:09 -05:00
bloom.h
cachemap.h More of 10969 2020-01-10 10:34:03 -06:00
cachemultimap.h
chain.cpp Merge #11469: fix typo in comment of chain.cpp 2020-01-10 10:34:02 -06:00
chain.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
chainparams.cpp Use smaller LLMQs in regtest (#3269) 2020-01-07 13:49:51 +01:00
chainparams.h Use smaller LLMQs in regtest (#3269) 2020-01-07 13:49:51 +01:00
chainparamsbase.cpp Change regtest and devnet p2p/rpc ports (#3064) 2019-08-28 10:52:00 +03:00
chainparamsbase.h
chainparamsseeds.h Update static and dns seeds for mainnet and testnet (#3234) 2019-12-11 12:30:38 +01:00
checkpoints.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
checkpoints.h
checkqueue.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
clientversion.cpp
clientversion.h
coins.cpp Merge #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant 2020-01-02 22:01:28 -06:00
coins.h Merge #11351: Refactor: Modernize disallowed copy constructors/assignment 2020-01-11 18:22:25 -06:00
compat.h Merge #12549: Make prevector::resize() and other prevector operations much faster 2019-10-02 15:25:27 +02:00
compressor.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
compressor.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
core_io.h Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
core_memusage.h Merge #10760: Avoid dereference-of-casted-pointer 2019-07-24 11:59:09 -05:00
core_read.cpp Merge #10792: Replace MAX_OPCODE for OP_NOP10. 2019-08-12 09:07:03 -05:00
core_write.cpp Add missing tx type to TxToUniv (#3069) 2019-08-28 10:54:44 +03:00
ctpl.h
cuckoocache.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp Merge #11125: Add bitcoin-cli -stdin and -stdinrpcpass functional tests 2020-01-02 21:59:55 -06:00
dash-tx-res.rc
dash-tx.cpp Merge #11554: Sanity-check script sizes in bitcoin-tx 2019-09-30 08:33:16 +02:00
dashd-res.rc
dashd.cpp Merge #10919: Fix more init bugs. 2019-09-20 10:30:04 -05:00
dbwrapper.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
dbwrapper.h More of 10969 2020-01-10 10:34:03 -06:00
dsnotificationinterface.cpp Make sure mempool txes are properly processed by CChainLocksHandler despite node restarts (#3226) 2019-12-07 13:56:17 +03:00
dsnotificationinterface.h More of 10969 2020-01-10 10:34:03 -06:00
flat-database.h More of 10793 2020-01-10 10:34:03 -06:00
fs.cpp
fs.h
hash.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
hash.h Merge #11385: Remove some unused functions and methods 2020-01-10 10:34:01 -06:00
hdchain.cpp More of 10793 2020-01-10 10:34:03 -06:00
hdchain.h
httprpc.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
httprpc.h
httpserver.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
httpserver.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
indirectmap.h
init.cpp Merge #11031: [rpc] deprecate estimatefee 2020-01-11 18:47:34 -06:00
init.h Merge #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue 2019-08-01 09:02:48 -05:00
keepass.cpp More of 10793 2020-01-10 10:34:03 -06:00
keepass.h
key.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
key.h Merge #11385: Remove some unused functions and methods 2020-01-10 10:34:01 -06:00
keystore.cpp
keystore.h Merge #10916: add missing lock to crypter GetKeys() 2020-01-10 10:33:54 -06:00
limitedmap.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
Makefile.am Merge #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp #10976 2020-01-10 10:33:57 -06:00
Makefile.bench.include Merge pull request #3133 from codablock/pr_backport_sha256_stuff 2019-10-03 13:46:26 +03:00
Makefile.leveldb.include Merge #10806: build: verify that the assembler can handle crc32 functions 2019-07-17 19:01:41 -05:00
Makefile.qt.include Merge pull request #3217 from codablock/pr_backport_hidpi_fix 2019-11-22 21:14:22 +03:00
Makefile.qttest.include Merge #13408: crypto: cleanup sha256 build 2019-10-01 23:20:06 +02:00
Makefile.test.include Merge #13386: SHA256 implementations based on Intel SHA Extensions 2019-10-01 23:20:06 +02:00
memusage.h #10193 scripted-diff: Remove #include <boost/foreach.hpp> 2019-07-24 11:59:09 -05:00
merkleblock.cpp Merge #9980: Fix mem access violation merkleblock 2019-07-24 11:59:09 -05:00
merkleblock.h Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
messagesigner.cpp More of 10793 2020-01-10 10:34:03 -06:00
messagesigner.h
miner.cpp Merge #11238: Add assertions before potential null deferences 2020-01-10 10:33:59 -06:00
miner.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
net_processing.cpp Merge pull request #3276 from PastaPastaPasta/backports-0.16-pr2 2020-01-12 01:17:33 +01:00
net_processing.h Make orphan TX map limiting dependent on total TX size instead of TX count (#3121) 2019-09-30 15:34:13 +02:00
net.cpp Merge #11301: add m_added_nodes to connman options 2020-01-11 18:22:25 -06:00
net.h Merge #11301: add m_added_nodes to connman options 2020-01-11 18:22:25 -06:00
netaddress.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
netaddress.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
netbase.cpp Merge #11397: net: Improve and document SOCKS code 2019-09-25 10:33:21 +02:00
netbase.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
netfulfilledman.cpp Skip mnsync restrictions for whitelisted and manually added nodes (#3249) 2019-12-31 13:01:48 +03:00
netfulfilledman.h Skip mnsync restrictions for whitelisted and manually added nodes (#3249) 2019-12-31 13:01:48 +03:00
netmessagemaker.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
noui.cpp
noui.h
pow.cpp Refactor some pow functions (#3198) 2019-11-13 21:17:36 +03:00
pow.h
prevector.h Speed up prevector initialization and vector assignment from prevectors (#3274) 2020-01-08 08:02:17 +01:00
protocol.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
protocol.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
pubkey.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
pubkey.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
random.cpp Merge #10843: Add attribute [[noreturn]] (C++11) to functions that will not return 2020-01-03 08:35:55 -06:00
random.h Merge #15512: Add ChaCha20 encryption option (XOR) 2019-07-23 09:14:28 -05:00
rest.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
reverse_iterator.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
reverselock.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
scheduler.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
serialize.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
spentindex.h
spork.cpp Refactor few things here and there (#3066) 2019-08-28 14:51:59 +03:00
spork.h
stacktraces.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
stacktraces.h
streams.h Merge #11351: Refactor: Modernize disallowed copy constructors/assignment 2020-01-11 18:22:25 -06:00
sync.cpp Merge #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant 2020-01-02 22:01:28 -06:00
sync.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp #10193 scripted-diff: Remove #include <boost/foreach.hpp> 2019-07-24 11:59:09 -05:00
timedata.h
tinyformat.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
torcontrol.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
torcontrol.h
txdb.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
txdb.h Merge #11351: Refactor: Modernize disallowed copy constructors/assignment 2020-01-11 18:22:25 -06:00
txmempool.cpp Merge #11161: Remove redundant explicitly defined copy ctors 2020-01-01 22:31:14 -06:00
txmempool.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
ui_interface.cpp
ui_interface.h Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable" 2020-01-03 08:35:55 -06:00
uint256.cpp Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
uint256.h Merge #11385: Remove some unused functions and methods 2020-01-10 10:34:01 -06:00
undo.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
unordered_lru_cache.h More of 10969 2020-01-10 10:34:03 -06:00
util.cpp Merge #10901: Fix constness of ArgsManager methods 2020-01-02 22:01:28 -06:00
util.h Merge #10901: Fix constness of ArgsManager methods 2020-01-02 22:01:28 -06:00
utilmoneystr.cpp
utilmoneystr.h Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
utilstrencodings.cpp Merge #10357: Allow setting nMinimumChainWork on command line 2019-09-29 12:42:14 +02:00
utilstrencodings.h Merge #10357: Allow setting nMinimumChainWork on command line 2019-09-29 12:42:14 +02:00
utiltime.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
utiltime.h
validation.cpp Merge pull request #3276 from PastaPastaPasta/backports-0.16-pr2 2020-01-12 01:17:33 +01:00
validation.h Merge #11340: Trivial: Fix validation comments 2020-01-10 10:34:00 -06:00
validationinterface.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
validationinterface.h Make sure mempool txes are properly processed by CChainLocksHandler despite node restarts (#3226) 2019-12-07 13:56:17 +03:00
version.h
versionbits.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
versionbits.h #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
warnings.cpp Merge #10501: remove some unused functions -- ignoring removal of SetPort due to dash#2168 2019-09-08 00:10:48 -05:00
warnings.h Merge #10501: remove some unused functions -- ignoring removal of SetPort due to dash#2168 2019-09-08 00:10:48 -05:00