Samuel Dobson 4fcd7850b0 Merge #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior ... 8925df86c4df16b1070343fef8e4d238f3cc3bd1 doc: update release notes (Jon Atack) 8bb405bbadf11391ccba7b334b4cfe66dc85b390 test: getaddressinfo labels purpose deprecation test (Jon Atack) 60aba1f2f11529add115d963d05599130288ae28 rpc: simplify getaddressinfo labels, deprecate previous behavior (Jon Atack) 7851f14ccf2bcd1e9b2ad48e5e08881be06d9d21 rpc: incorporate review feedback from PR 17283 (Jon Atack) Pull request description: This PR builds on #17283 (now merged) and is followed by #17585. It modifies the value returned by rpc getaddressinfo `labels` to an array of label name strings and deprecates the previous behavior of returning an array of JSON hash structures containing label `name` and address `purpose` key/value pairs. before ``` "labels": [ { "name": "DOUBLE SPEND", "purpose": "receive" } ``` after ``` "labels": [ "DOUBLE SPEND" ] ``` The deprecated behavior can be re-enabled by starting bitcoind with `-deprecatedrpc=labelspurpose`. For context, see: - https://github.com/bitcoin/bitcoin/pull/17283#issuecomment-554458001 - http://www.erisian.com.au/bitcoin-core-dev/log-2019-12-13.html#l-425 (lines 425-427) - http://www.erisian.com.au/bitcoin-core-dev/log-2019-11-22.html#l-622 Reviewers: This PR may be tested manually by building, then running bitcoind with and without the `-deprecatedrpc=labelspurpose` flag while verifying the rpc getaddressinfo help text and `labels` output. Next steps: deprecate the rpc getaddressinfo `label` field (EDIT: done in #17585) and add support for multiple labels per address. This PR will unblock those. ACKs for top commit: jnewbery: reACK 8925df8 promag: Code review ACK 8925df86c4df16b1070343fef8e4d238f3cc3bd1. meshcollider: Code review ACK 8925df86c4df16b1070343fef8e4d238f3cc3bd1 Tree-SHA512: c2b717209996da32b6484de7bb8800e7048410f9ce6afdb3e02a6866bd4a8f2c730f905fca27b10b877b91cf407f546e69e8c4feb9cd934325a6c71c166bd438		2023-04-25 23:14:25 +03:00
..
__init__.py
address.py	Merge #17984: test: Add p2p test for forcerelay permission	2022-10-20 11:48:12 -04:00
authproxy.py	Merge #18596: test: Try once more when RPC connection fails on Windows	2021-09-28 14:46:44 -04:00
blocktools.py	Merge #19082: test: Moved the CScriptNum asserts into the unit test in script.py	2023-02-27 23:12:41 -06:00
coverage.py
descriptors.py	Merge #18032: rpc: Output a descriptor in createmultisig and addmultisigaddress	2023-04-06 20:15:47 +03:00
key.py	merge bitcoin#19105: Add Muhash3072 implementation in Python	2022-04-27 20:05:13 +05:30
messages.py	feat: min protocol version check for SML serialisation (#5302)	2023-04-09 00:12:39 -05:00
mininode.py	Merge #18593: test: complete impl. of msg_merkleblock and wait_for_merkleblock	2023-04-09 00:06:56 -05:00
muhash.py	partial bitcoin#19055: Add MuHash3072 implementation	2022-04-27 20:05:13 +05:30
netutil.py	Merge bitcoin/bitcoin#24342: test: remove import socket in test_ipv6_local	2022-04-11 09:46:40 -07:00
ripemd160.py	docs/build: Kubuntu 22.04 build fix (#4843)	2022-05-28 23:27:04 -05:00
script_util.py	Merge #18732: test: Remove unused, undocumented and misleading CScript.__add__	2023-03-03 23:07:15 +05:30
script.py	Merge #18732: test: Remove unused, undocumented and misleading CScript.__add__	2023-03-03 23:07:15 +05:30
siphash.py
socks5.py
test_framework.py	fix(tests): a couple of fixes for dynamically_add/update functions (#5288)	2023-04-09 00:09:18 -05:00
test_node.py	merge bitcoin#18691: add wait_for_cookie_credentials() to framework for rpcwait tests	2023-04-17 08:30:49 +00:00
test_shell.py	Merge #17378: TestShell: Fix typos & implement cleanups	2023-01-23 12:22:29 -06:00
util.py	Merge #16524: Wallet: Disable -fallbackfee by default	2023-04-17 10:42:25 -05:00
wallet_util.py	Merge #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior	2023-04-25 23:14:25 +03:00