mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
666859b47f
* fix(llmq): Ensure connections between quorums Every masternode will now "watch" a single node from _every other_ quorum in addition to intra-quorum connections. This should make propagation of recsigs produced by one quorum to other quorums much more reliable. * fix: Do this only for masternodes which participate in IS quorums * refactor: rename `CQuorumManager::EnsureQuorumConnections` to better match the actual behaviour (and avoid confusion with `CLLMQUtils::EnsureQuorumConnections`) * refactor: move IS quorums watch logic into `CQuorumManager::CheckQuorumConnections` avoid calling slow `ScanQuorums` (no caching atm) inside the loop * tests: check that inter-quorum connections are added * use `ranges::any_of`
156 lines
6.0 KiB
Python
Executable File
156 lines
6.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2021 The Dash Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
'''
|
|
feature_llmq_connections.py
|
|
|
|
Checks intra quorum connections
|
|
|
|
'''
|
|
|
|
import time
|
|
|
|
from test_framework.test_framework import DashTestFramework
|
|
from test_framework.util import assert_greater_than_or_equal, connect_nodes, wait_until
|
|
|
|
|
|
class LLMQConnections(DashTestFramework):
|
|
def set_test_params(self):
|
|
self.set_dash_test_params(15, 14, fast_dip3_enforcement=True)
|
|
self.set_dash_llmq_test_params(5, 3)
|
|
|
|
def run_test(self):
|
|
self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
q = self.mine_quorum()
|
|
|
|
self.log.info("checking for old intra quorum connections")
|
|
total_count = 0
|
|
for mn in self.get_quorum_masternodes(q):
|
|
count = self.get_mn_connection_count(mn.node)
|
|
total_count += count
|
|
assert_greater_than_or_equal(count, 2)
|
|
assert total_count < 40
|
|
|
|
self.check_reconnects(2)
|
|
|
|
self.log.info("Activating SPORK_23_QUORUM_POSE")
|
|
self.nodes[0].sporkupdate("SPORK_23_QUORUM_POSE", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
self.log.info("mining one block and waiting for all members to connect to each other")
|
|
self.nodes[0].generate(1)
|
|
for mn in self.get_quorum_masternodes(q):
|
|
self.wait_for_mnauth(mn.node, 4)
|
|
|
|
self.log.info("mine a new quorum and verify that all members connect to each other")
|
|
q = self.mine_quorum()
|
|
|
|
self.log.info("checking that all MNs got probed")
|
|
for mn in self.get_quorum_masternodes(q):
|
|
wait_until(lambda: self.get_mn_probe_count(mn.node, q, False) == 4)
|
|
|
|
self.log.info("checking that probes age")
|
|
self.bump_mocktime(60)
|
|
for mn in self.get_quorum_masternodes(q):
|
|
wait_until(lambda: self.get_mn_probe_count(mn.node, q, False) == 0)
|
|
|
|
self.log.info("mine a new quorum and re-check probes")
|
|
q = self.mine_quorum()
|
|
for mn in self.get_quorum_masternodes(q):
|
|
wait_until(lambda: self.get_mn_probe_count(mn.node, q, True) == 4)
|
|
|
|
self.log.info("Activating SPORK_21_QUORUM_ALL_CONNECTED")
|
|
self.nodes[0].sporkupdate("SPORK_21_QUORUM_ALL_CONNECTED", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
self.check_reconnects(4)
|
|
|
|
self.log.info("check that old masternode conections are dropped")
|
|
removed = False
|
|
for mn in self.mninfo:
|
|
if len(mn.node.quorum("memberof", mn.proTxHash)) > 0:
|
|
try:
|
|
with mn.node.assert_debug_log(['removing masternodes quorum connections']):
|
|
with mn.node.assert_debug_log(['keeping mn quorum connections']):
|
|
self.mine_quorum()
|
|
mn.node.mockscheduler(60) # we check for old connections via the scheduler every 60 seconds
|
|
removed = True
|
|
except:
|
|
pass # it's ok to not remove connections sometimes
|
|
if removed:
|
|
break
|
|
assert removed # no way we removed none
|
|
|
|
self.log.info("check that inter-quorum masternode conections are added")
|
|
added = False
|
|
for mn in self.mninfo:
|
|
if len(mn.node.quorum("memberof", mn.proTxHash)) > 0:
|
|
try:
|
|
with mn.node.assert_debug_log(['adding mn inter-quorum connections']):
|
|
self.mine_quorum()
|
|
added = True
|
|
except:
|
|
pass # it's ok to not add connections sometimes
|
|
if added:
|
|
break
|
|
assert added # no way we added none
|
|
|
|
def check_reconnects(self, expected_connection_count):
|
|
self.log.info("disable and re-enable networking on all masternodes")
|
|
for mn in self.mninfo:
|
|
mn.node.setnetworkactive(False)
|
|
for mn in self.mninfo:
|
|
wait_until(lambda: len(mn.node.getpeerinfo()) == 0)
|
|
for mn in self.mninfo:
|
|
mn.node.setnetworkactive(True)
|
|
self.bump_mocktime(60)
|
|
|
|
self.log.info("verify that all masternodes re-connected")
|
|
for q in self.nodes[0].quorum('list')['llmq_test']:
|
|
for mn in self.get_quorum_masternodes(q):
|
|
self.wait_for_mnauth(mn.node, expected_connection_count)
|
|
|
|
# Also re-connect non-masternode connections
|
|
for i in range(1, len(self.nodes)):
|
|
connect_nodes(self.nodes[i], 0)
|
|
self.nodes[i].ping()
|
|
# wait for ping/pong so that we can be sure that spork propagation works
|
|
time.sleep(1) # needed to make sure we don't check before the ping is actually sent (fPingQueued might be true but SendMessages still not called)
|
|
for i in range(1, len(self.nodes)):
|
|
wait_until(lambda: all('pingwait' not in peer for peer in self.nodes[i].getpeerinfo()))
|
|
|
|
def get_mn_connection_count(self, node):
|
|
peers = node.getpeerinfo()
|
|
count = 0
|
|
for p in peers:
|
|
if 'verified_proregtx_hash' in p and p['verified_proregtx_hash'] != '':
|
|
count += 1
|
|
return count
|
|
|
|
def get_mn_probe_count(self, node, q, check_peers):
|
|
count = 0
|
|
mnList = node.protx('list', 'registered', 1)
|
|
peerList = node.getpeerinfo()
|
|
mnMap = {}
|
|
peerMap = {}
|
|
for mn in mnList:
|
|
mnMap[mn['proTxHash']] = mn
|
|
for p in peerList:
|
|
if 'verified_proregtx_hash' in p and p['verified_proregtx_hash'] != '':
|
|
peerMap[p['verified_proregtx_hash']] = p
|
|
for mn in self.get_quorum_masternodes(q):
|
|
pi = mnMap[mn.proTxHash]
|
|
if pi['metaInfo']['lastOutboundSuccessElapsed'] < 60:
|
|
count += 1
|
|
elif check_peers and mn.proTxHash in peerMap:
|
|
count += 1
|
|
return count
|
|
|
|
|
|
if __name__ == '__main__':
|
|
LLMQConnections().main()
|