sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-24 19:42:46 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
578fac1743
dash/src
History
Samuel Dobson 4fcd7850b0 Merge #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior 
8925df86c4df16b1070343fef8e4d238f3cc3bd1 doc: update release notes (Jon Atack)
8bb405bbadf11391ccba7b334b4cfe66dc85b390 test: getaddressinfo labels purpose deprecation test (Jon Atack)
60aba1f2f11529add115d963d05599130288ae28 rpc: simplify getaddressinfo labels, deprecate previous behavior (Jon Atack)
7851f14ccf2bcd1e9b2ad48e5e08881be06d9d21 rpc: incorporate review feedback from PR 17283 (Jon Atack)

Pull request description:

  This PR builds on #17283 (now merged) and is followed by #17585.

  It modifies the value returned by rpc getaddressinfo `labels` to an array of label name strings and deprecates the previous behavior of returning an array of JSON hash structures containing label `name` and address `purpose` key/value pairs.

  before
  ```
    "labels": [
      {
        "name": "DOUBLE SPEND",
        "purpose": "receive"
      }
  ```
  after
  ```
    "labels": [
      "DOUBLE SPEND"
    ]
  ```

  The deprecated behavior can be re-enabled by starting bitcoind with `-deprecatedrpc=labelspurpose`.

  For context, see:
  - https://github.com/bitcoin/bitcoin/pull/17283#issuecomment-554458001
  - http://www.erisian.com.au/bitcoin-core-dev/log-2019-12-13.html#l-425 (lines 425-427)
  - http://www.erisian.com.au/bitcoin-core-dev/log-2019-11-22.html#l-622

  Reviewers: This PR may be tested manually by building, then running bitcoind with and without the `-deprecatedrpc=labelspurpose` flag while verifying the rpc getaddressinfo help text and `labels` output.

  Next steps: deprecate the rpc getaddressinfo `label` field (EDIT: done in #17585) and add support for multiple labels per address. This PR will unblock those.

ACKs for top commit:
  jnewbery:
    reACK 8925df8
  promag:
    Code review ACK 8925df86c4df16b1070343fef8e4d238f3cc3bd1.
  meshcollider:
    Code review ACK 8925df86c4df16b1070343fef8e4d238f3cc3bd1

Tree-SHA512: c2b717209996da32b6484de7bb8800e7048410f9ce6afdb3e02a6866bd4a8f2c730f905fca27b10b877b91cf407f546e69e8c4feb9cd934325a6c71c166bd438
2023-04-25 23:14:25 +03:00
..
bench Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
bls refactor: convert most std::vector const references to Spans in bls code 2023-04-19 01:12:28 +03:00
coinjoin refactor(coinjoin): convert nConfirmedHeight to std::optional (#5108) 2023-04-17 23:56:53 -05:00
compat revert dash#1432: Rename consensus source library and API 2022-08-09 14:16:28 +05:30
config
consensus Merge #17624: net: Fix an uninitialized read in ProcessMessage(…, "tx", …) when receiving a transaction we already have 2023-04-17 10:42:25 -05:00
crc32c
crypto partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
dashbls build: stop tracking cmake dependency relic_conf.h.in 2023-03-16 16:37:02 +00:00
evo refactor: move CDeterministicMN class members above functions (#5341) 2023-04-25 10:15:58 -05:00
governance refactor: Spanify some governance APIs 2023-04-19 01:12:28 +03:00
immer build: fix gitian builds 2023-01-03 14:51:16 +03:00
index merge bitcoin#20749: Prune g_chainman usage related to ::LookupBlockIndex 2023-04-04 12:41:45 -05:00
interfaces Merge bitcoin/bitcoin#23644: wallet: Replace confusing getAdjustedTime() with GetTime() 2023-04-17 11:17:34 -05:00
leveldb Merge bitcoin/bitcoin#25739: Update leveldb subtree (#5005) 2022-09-23 18:43:39 +04:00
llmq refactor: drop flag m_block_relay_peer and use m_addr_relay object instead (#5339) 2023-04-19 09:57:27 -05:00
logging Merge #18088: build: ensure we aren't using GNU extensions 2023-03-03 23:07:16 +05:30
masternode feat!: 4k collateral high performance masternode implementation (#5039) 2023-02-14 12:48:33 -06:00
node Merge bitcoin/bitcoin#23644: wallet: Replace confusing getAdjustedTime() with GetTime() 2023-04-17 11:17:34 -05:00
policy Merge #16507: feefilter: Compute the absolute fee rather than stored rate 2023-04-17 10:42:25 -05:00
primitives Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 2023-03-03 23:07:15 +05:30
qt Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
rpc feat(rpc): protx listdiff rpc (#5338) 2023-04-19 09:47:49 -05:00
script Merge #16658: validation: Rename CheckInputs to CheckInputScripts 2023-04-25 23:14:25 +03:00
secp256k1
support fix: Fix missing includes (#5295) 2023-04-05 21:20:41 -05:00
test Merge #16658: validation: Rename CheckInputs to CheckInputScripts 2023-04-25 23:14:25 +03:00
univalue
util Merge #17762: net: Log to net category for exceptions in ProcessMessages 2023-04-25 23:14:25 +03:00
wallet Merge #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior 2023-04-25 23:14:25 +03:00
zmq refactor: use enums instead of random const ints (#5322) 2023-04-16 12:09:37 -05:00
.clang-format
addrdb.cpp merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
addrdb.h merge bitcoin#19219: Replace automatic bans with discouragement filter 2022-06-21 19:11:49 +05:30
addressindex.h Merge #16908: txmempool: Make entry time type-safe (std::chrono) 2022-10-03 16:08:31 -04:00
addrman.cpp merge bitcoin#21016: remove boost::thread_group usage 2023-01-19 03:42:51 +00:00
addrman.h merge bitcoin#20291: Consolidate logic around calling CAddrMan::Connected() 2023-02-28 00:11:11 +03:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp feat(rpc): Added RPC cleardiscouraged (#5273) 2023-03-29 11:23:45 -05:00
banman.h feat(rpc): Added RPC cleardiscouraged (#5273) 2023-03-29 11:23:45 -05:00
base58.cpp Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
base58.h Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
batchedlogger.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
batchedlogger.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp
bip39.h
bitcoin-cli.cpp Merge bitcoin/bitcoin#22894: netinfo: clarify client and server versions in header 2023-04-18 23:24:06 +03:00
bitcoin-tx.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
bitcoin-wallet.cpp trivial: revert dashification of source and header filenames 2022-08-09 14:16:29 +05:30
bitcoind.cpp Merge #16489: log: harmonize bitcoind logging 2023-04-06 20:14:58 +03:00
blockencodings.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
blockencodings.h
blockfilter.cpp Merge bitcoin/bitcoin#23760: util: move MapIntoRange() for reuse in fuzz tests 2023-04-17 11:17:34 -05:00
blockfilter.h
bloom.cpp Merge #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix 2023-01-22 00:27:52 -06:00
bloom.h Merge #17164: p2p: Avoid allocating memory for addrKnown where we don't need it 2023-04-17 19:34:02 +03:00
cachemap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
cachemultimap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
chain.cpp
chain.h
chainparams.cpp chore: Delay v20 activation (regtest only) (#5346) 2023-04-25 09:15:43 -05:00
chainparams.h refactor: tweak GetLLMQ to fail gracefully and let caller handle results accordingly (#5247) 2023-03-13 11:11:17 -05:00
chainparamsbase.cpp merge bitcoin#19991: Use alternative port for incoming Tor connections 2023-04-17 08:30:49 +00:00
chainparamsbase.h merge bitcoin#19991: Use alternative port for incoming Tor connections 2023-04-17 08:30:49 +00:00
chainparamsseeds.h Update hard coded seeds for v18.0.0-rc12 (#4953) 2022-08-11 01:57:13 +03:00
checkqueue.h
clientversion.cpp
clientversion.h partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
coins.cpp Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 2023-03-03 23:07:15 +05:30
coins.h Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 2023-03-03 23:07:15 +05:30
compat.h partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
compressor.cpp Merge bitcoin/bitcoin#18847: compressor: use a prevector in CompressScript serialization [ZAP1] 2023-04-14 23:34:13 -05:00
compressor.h Merge bitcoin/bitcoin#18847: compressor: use a prevector in CompressScript serialization [ZAP1] 2023-04-14 23:34:13 -05:00
context.h merge bitcoin#18766: disable fee estimation in blocksonly mode (by removing the fee estimates global) 2023-02-28 00:11:11 +03:00
core_io.h merge bitcoin#15508: Refactor analyzepsbt for use outside RPC code 2022-09-24 08:51:04 +05:30
core_memusage.h
core_read.cpp merge bitcoin#25057: replace remaining boost::split with SplitString 2023-01-19 03:49:04 +00:00
core_write.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
ctpl_stl.h refactor/chore: update cppcheck to 2.8 with needed refactoring (#4926) 2022-08-11 02:05:44 +03:00
cuckoocache.h Merge #17634: qt: Fix comparison function signature 2022-06-16 01:34:38 -04:00
cxxtimer.hpp test/refactor: upgrade to cppcheck 2.9 and fix warnings (#5049) 2022-10-18 13:24:00 +03:00
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp Merge bitcoin/bitcoin#23214: Replace stoul with ToIntegral in dbwrapper 2023-04-17 11:17:34 -05:00
dbwrapper.h Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
dsnotificationinterface.cpp Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
dsnotificationinterface.h Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
dummywallet.cpp fix(gui): remove "Upgrade wallet format" button from "Wallet Repair" tab 2023-02-17 14:21:19 -06:00
flat-database.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
flatfile.cpp
flatfile.h
fs.cpp Merge #19299: refactor: Remove unused vars, Add missing includes 2023-01-22 00:27:52 -06:00
fs.h
hash.cpp
hash.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
hdchain.cpp fix: Pass KeyOriginInfo instead of CKeyMetadata to DeriveChildExtKey (#4918) 2022-07-18 16:56:33 +03:00
hdchain.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
httprpc.cpp merge bitcoin#25057: replace remaining boost::split with SplitString 2023-01-19 03:49:04 +00:00
httprpc.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
httpserver.cpp Merge bitcoin/bitcoin#22914: util: remove libevent <= 2.0.18 back-compat code 2023-04-17 11:17:34 -05:00
httpserver.h merge bitcoin#18363: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions 2022-07-15 21:24:21 +05:30
indirectmap.h
init.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
init.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
key_io.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
key_io.h
key.cpp merge bitcoin#19379: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) 2022-08-21 18:09:28 +05:30
key.h partial Merge #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization methods 2023-04-17 10:42:25 -05:00
limitedmap.h
logging.cpp
logging.h
Makefile.am Merge #16889: Add some general std::vector utility functions 2023-04-17 10:42:25 -05:00
Makefile.bench.include Merge #16267: bench: Benchmark blockToJSON 2023-03-29 21:01:56 +03:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include merge bitcoin#17513: Nuke some circular dependencies 2023-04-15 12:12:30 -05:00
Makefile.qttest.include partial bitcoin#19077: Add sqlite as an alternative wallet database and use it for new descriptor wallets 2023-02-07 10:53:33 -06:00
Makefile.test_fuzz.include merge bitcoin#18528: create test_fuzz library from src/test/fuzz/fuzz.cpp 2022-10-02 12:05:13 +05:30
Makefile.test_util.include merge bitcoin#18521: Add process_messages harness 2022-07-06 22:13:37 +05:30
Makefile.test.include fix: ./autogen fails due to newline (#5325) 2023-04-15 20:41:32 +03:00
Makefile.univalue.include
mapport.cpp partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
messagesigner.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
messagesigner.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
miner.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
miner.h partial bitcoin#21270: Prune g_chainman usage in validation-adjacent modules 2023-04-04 12:41:45 -05:00
net_permissions.cpp Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests. 2022-10-03 16:08:31 -04:00
net_permissions.h Merge #17985: net: Remove forcerelay of rejected txs 2022-10-20 11:48:21 -04:00
net_processing.cpp Merge #17762: net: Log to net category for exceptions in ProcessMessages 2023-04-25 23:14:25 +03:00
net_processing.h Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
net_types.h
net.cpp refactor: drop flag m_block_relay_peer and use m_addr_relay object instead (#5339) 2023-04-19 09:57:27 -05:00
net.h refactor: drop flag m_block_relay_peer and use m_addr_relay object instead (#5339) 2023-04-19 09:57:27 -05:00
netaddress.cpp partial bitcoin#19998: Add CNode::ConnectedThroughNetwork member function 2023-04-17 08:30:49 +00:00
netaddress.h partial bitcoin#19998: Add CNode::ConnectedThroughNetwork member function 2023-04-17 08:30:49 +00:00
netbase.cpp Merge bitcoin/bitcoin#17160: refactor: net: subnet lookup: use single-result LookupHost() 2023-04-17 11:17:34 -05:00
netbase.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
netfulfilledman.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
netfulfilledman.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
netmessagemaker.h
noui.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
noui.h
outputtype.cpp Merge #18067: wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition 2023-03-19 11:08:31 -05:00
outputtype.h Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple 2023-03-19 11:08:31 -05:00
pow.cpp
pow.h
prevector.h Merge #18088: build: ensure we aren't using GNU extensions 2023-03-03 23:07:16 +05:30
protocol.cpp Merge bitcoin/bitcoin#21905: net: initialize nMessageSize to uint32_t max 2023-04-14 23:34:14 -05:00
protocol.h Merge bitcoin/bitcoin#21905: net: initialize nMessageSize to uint32_t max 2023-04-14 23:34:14 -05:00
psbt.cpp Merge #17156: psbt: check that various indexes and amounts are within bounds 2023-02-04 10:02:37 -06:00
psbt.h Merge #17524: psbt: handle unspendable psbts 2023-02-04 10:02:37 -06:00
pubkey.cpp merge bitcoin#19379: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) 2022-08-21 18:09:28 +05:30
pubkey.h Merge #19237: wallet: Check size after unserializing a pubkey 2023-04-15 12:14:35 -05:00
random.cpp merge bitcoin#20429: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size 2022-11-01 00:28:53 -05:00
random.h merge bitcoin#18455: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h 2022-07-06 22:13:37 +05:30
randomenv.cpp merge bitcoin#20602: Allow use of C++14 chrono literals 2022-10-20 16:08:45 -05:00
randomenv.h
rest.cpp merge bitcoin#20749: Prune g_chainman usage related to ::LookupBlockIndex 2023-04-04 12:41:45 -05:00
reverse_iterator.h
saltedhasher.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
saltedhasher.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
scheduler.cpp merge bitcoin#19090: Misc scheduler cleanups 2023-01-19 03:42:49 +00:00
scheduler.h merge bitcoin#21016: remove boost::thread_group usage 2023-01-19 03:42:51 +00:00
serialize.h merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
shutdown.cpp
shutdown.h
span.h Merge #19508: Work around memory-aliasing in descriptor ParsePubkey 2023-01-23 12:22:31 -06:00
spentindex.h
spork.cpp partial bitcoin#17938: Disallow automatic conversion between disparate hash types 2023-04-15 12:12:30 -05:00
spork.h refactor: using C++11/14/17 features in dash specifict code (#5190) 2023-02-19 17:04:57 -06:00
stacktraces.cpp Merge pull request #4478 from kittywhiskers/undashify 2022-08-11 12:34:55 -04:00
stacktraces.h
statsd_client.cpp refactor: resolve implicit-const-int-float-conversion warning in statsd_client 2022-10-21 21:51:35 +05:30
statsd_client.h chore: add missing copyrights via copyright_header.py insert 2023-01-13 00:49:04 +03:00
streams.h Merge #19593: refactor: Drop unused CBufferedFile::Seek() 2022-09-03 10:43:14 -05:00
sync.cpp Merge #19982: test: Fix inconsistent lock order in wallet_tests/CreateWallet 2023-03-19 11:08:31 -05:00
sync.h merge bitcoin#17954: Remove calls to Chain::Lock methods 2023-04-15 12:12:30 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
timedata.h
tinyformat.h
torcontrol.cpp Merge bitcoin/bitcoin#22288: Resolve Tor control plane address 2023-04-18 23:24:06 +03:00
torcontrol.h merge bitcoin#19991: Use alternative port for incoming Tor connections 2023-04-17 08:30:49 +00:00
txdb.cpp merge bitcoin#21016: remove boost::thread_group usage 2023-01-19 03:42:51 +00:00
txdb.h
txmempool.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
txmempool.h Merge #16507: feefilter: Compute the absolute fee rather than stored rate 2023-04-17 10:42:25 -05:00
ui_interface.cpp
ui_interface.h
uint256.cpp uint256: add definition for constant 'ZERO' 2023-04-15 12:12:30 -05:00
uint256.h uint256: add definition for constant 'ZERO' 2023-04-15 12:12:30 -05:00
undo.h
unordered_lru_cache.h
validation.cpp Merge #16658: validation: Rename CheckInputs to CheckInputScripts 2023-04-25 23:14:25 +03:00
validation.h Merge bitcoin/bitcoin#23929: doc: fix undo data filename (s/undo???.dat/rev???.dat/) 2023-04-17 11:17:34 -05:00
validationinterface.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
validationinterface.h Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
version.h chore: Bump MIN_MASTERNODE_PROTO_VERSION for v19 (#5223) 2023-02-28 09:59:57 -06:00
versionbits.cpp fix: speed up GetStateFor (#5100) 2022-12-13 11:42:52 -06:00
versionbits.h merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
versionbitsinfo.cpp feat!: v20 BIP9 fork (#5121) 2023-04-14 17:01:46 -05:00
versionbitsinfo.h
walletinitinterface.h merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
warnings.cpp merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00
warnings.h merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00