mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
ae051bb6e0
* Move wallet enums to walletutil.h
* MOVEONLY: Move key handling code out of wallet to keyman file
Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp
The easiest way to review this commit is to run:
git log -p -n1 --color-moved=dimmed_zebra
And check that everything is a move (other than includes and copyrights comments).
This commit is move-only and doesn't change code or affect behavior.
* Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes
This moves CWallet members and methods dealing with keys to a new
LegacyScriptPubKeyMan class, and updates calling code to reference the new
class instead of CWallet.
Most of the changes are simple text replacements and variable substitutions
easily verified with:
git log -p -n1 -U0 --word-diff-regex=.
The only nontrivial chunk of code added is the new LegacyScriptPubKeyMan class
declaration, but this code isn't new and is just selectively copied and moved
from the previous CWallet class declaration. This can be verified with:
git log -p -n1 --color-moved=dimmed_zebra src/wallet/scriptpubkeyman.h src/wallet/wallet.h
or
git diff HEAD~1:src/wallet/wallet.h HEAD:src/wallet/scriptpubkeyman.h
This commit does not change behavior.
* Renamed classes in scriptpubkeyman
* Fixes for conflicts, compilation and linkage errors due to previous commits
* Reordered methods in scriptpubkeyman to make further backports easier
* Reordered methods in scriptpubkeyman to make further backports easier (part II)
* Remove HDChain copy from SigningProvider class
* fixes/suggestions
Co-authored-by: Andrew Chow <achow101-github@achow101.com>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
30 lines
890 B
Bash
Executable File
30 lines
890 B
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check that all logs are terminated with '\n'
|
|
#
|
|
# Some logs are continued over multiple lines. They should be explicitly
|
|
# commented with /* Continued */
|
|
#
|
|
# There are some instances of LogPrintf() in comments. Those can be
|
|
# ignored
|
|
|
|
export LC_ALL=C
|
|
|
|
UNTERMINATED_LOGS=$(git grep --extended-regexp "LogPrintf?\(" -- "*.cpp" | \
|
|
grep -v '\\n"' | \
|
|
grep -v '\.\.\.' | \
|
|
grep -v "/\* Continued \*/" | \
|
|
grep -v "LogPrint()" | \
|
|
grep -v "LogPrintf()")
|
|
if [[ ${UNTERMINATED_LOGS} != "" ]]; then
|
|
# shellcheck disable=SC2028
|
|
echo "All calls to LogPrintf() and LogPrint() should be terminated with \\n"
|
|
echo
|
|
echo "${UNTERMINATED_LOGS}"
|
|
exit 1
|
|
fi
|