dash/src/coinjoin
MarcoFalke 6a164eaea9
Merge #19501: send* RPCs in the wallet returns the "fee reason"
69cf5d4eeb73f7d685e915fc17af64634d88a4a2 [test] Make sure send rpc returns fee reason (Sishir Giri)
d5863c0b3e20d56acf7246008b7832efde68ab21 [send] Make send RPCs return fee reason (Sishir Giri)

Pull request description:

  Whenever a wallet funds a transaction, the fee reason is reported to the user only if the verbose is set to true. I added an extra parameter to `CreateTransaction` function in wallet.cpp. Then I implemented the fee reason return logic in `SendMoney`  in rpcwallet.cpp, followed by verbose parameter in `sendtoaddress` and `sendmany` functions. I also added a fee reason test case in walletbasic.py.

  link to the issue: https://github.com/MarcoFalke/bitcoin-core/issues/22#issue-616251578

ACKs for top commit:
  instagibbs:
    ACK 69cf5d4eeb
  meshcollider:
    utACK 69cf5d4eeb73f7d685e915fc17af64634d88a4a2

Tree-SHA512: 2e3af32dcfbd5511ba95f8bc8edca7acfe709a8430ff03e43172e5d0af3dfa4b2f57906978e7f272d878043b9ed8c6004674cf47d7496b005d5f612e9a58aa0e
2024-05-29 14:03:56 +07:00
..
client.cpp fix: resolve potential deadlocks in CJ 2024-05-02 22:33:22 +03:00
client.h coinjoin: replace LOCKS_EXCLUDED with negative EXCLUSIVE_LOCKS_REQUIRED 2024-04-30 11:46:59 +00:00
coinjoin.cpp refactor: pass CActiveMasternodeManager as pointer arg to CJContext 2024-03-24 07:37:31 +00:00
coinjoin.h merge bitcoin#25109: Strengthen AssertLockNotHeld assertions 2024-05-09 08:52:48 +00:00
common.cpp non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
common.h non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
context.cpp refactor: remove fMasternodeMode usage from coinjoin logic 2024-04-24 18:42:33 +00:00
context.h net: retire CConnman::RelayTransaction, use PeerManager::RelayTransaction 2024-04-23 16:06:41 +00:00
interfaces.cpp refactor: drop global coinJoinWalletManager 2024-01-10 12:06:04 -06:00
options.cpp non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
options.h non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
server.cpp refactor: remove fMasternodeMode usage from coinjoin logic 2024-04-24 18:42:33 +00:00
server.h coinjoin: replace LOCKS_EXCLUDED with negative EXCLUSIVE_LOCKS_REQUIRED 2024-04-30 11:46:59 +00:00
util.cpp Merge #19501: send* RPCs in the wallet returns the "fee reason" 2024-05-29 14:03:56 +07:00
util.h coinjoin: replace LOCKS_EXCLUDED with negative EXCLUSIVE_LOCKS_REQUIRED 2024-04-30 11:46:59 +00:00