mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
6a164eaea9
69cf5d4eeb73f7d685e915fc17af64634d88a4a2 [test] Make sure send rpc returns fee reason (Sishir Giri)
d5863c0b3e20d56acf7246008b7832efde68ab21 [send] Make send RPCs return fee reason (Sishir Giri)
Pull request description:
Whenever a wallet funds a transaction, the fee reason is reported to the user only if the verbose is set to true. I added an extra parameter to `CreateTransaction` function in wallet.cpp. Then I implemented the fee reason return logic in `SendMoney` in rpcwallet.cpp, followed by verbose parameter in `sendtoaddress` and `sendmany` functions. I also added a fee reason test case in walletbasic.py.
link to the issue: https://github.com/MarcoFalke/bitcoin-core/issues/22#issue-616251578
ACKs for top commit:
instagibbs:
ACK
|
||
---|---|---|
.. | ||
client.cpp | ||
client.h | ||
coinjoin.cpp | ||
coinjoin.h | ||
common.cpp | ||
common.h | ||
context.cpp | ||
context.h | ||
interfaces.cpp | ||
options.cpp | ||
options.h | ||
server.cpp | ||
server.h | ||
util.cpp | ||
util.h |