mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
5ab7f9074f
32d665c2657793c8b2cc7248d26d80a940acfe20 test: fix "tx-size-small" errors after default address change (Sebastian Falbesoner)
Pull request description:
Addresses #17043, affects RBF and BIP68 functional tests.
The "tx-size-small" policy rule rejects transactions with a non-witness size of
smaller than 82 bytes (see `src/validation.cpp:MemPoolAccept::PreChecks(...)`),
which corresponds to a transaction with 1 segwit input and 1 P2WPKH output.
Through the default address change, the created test transactions have segwit
inputs now and sending to short scriptPubKeys might violate this rule. By
bumping the dummy scriptPubKey size to 22 bytes (= the size of a P2WPKH
scriptPubKey), on all occurences the problem is solved.
The dummy scriptPubKey has the format:
```21 <21-byte-long string of 'a' or 1s>```
ACKs for top commit:
instagibbs:
reACK
|
||
---|---|---|
.. | ||
__init__.py | ||
address.py | ||
authproxy.py | ||
blocktools.py | ||
coverage.py | ||
descriptors.py | ||
key.py | ||
messages.py | ||
mininode.py | ||
muhash.py | ||
netutil.py | ||
script_util.py | ||
script.py | ||
siphash.py | ||
socks5.py | ||
test_framework.py | ||
test_node.py | ||
util.py | ||
wallet_util.py |