mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00

Dash - Reinventing Cryptocurrency

bitcoin blockchain cryptocurrency dash governance instant masternode p2p privacy

Go to file

pasta 5c240bbc5e Merge #5986 : trivial: remove boost::{function, lexical_cast} usage, backport bitcoin#25550, #24624 , #24406 , cleanup some gArgs usage in init `740d25c062` merge bitcoin#24406: Fix Wambiguous-reversed-operator compiler warnings (Kittywhiskers Van Gogh) `3265b54a2f` merge bitcoin#24624: Avoid potential -Wdeprecated-enum-enum-conversion warnings (Kittywhiskers Van Gogh) `65585e68e6` merge bitcoin#25550: remove note on arm cross-compilation from build-unix.md (Kittywhiskers Van Gogh) `fbc6bc88cf` init: use local ArgsManager variable instead of global when possible (Kittywhiskers Van Gogh) `9ae39f9ba7` qt: drop leftover `boost::function` usage in Qt, drop header from list (Kittywhiskers Van Gogh) `c47e9e78ed` bench: drop leftover `boost::lexical_cast` benches, drop header from list (Kittywhiskers Van Gogh) Pull request description: ## Additional Information When building Dash with `clang-16`, I use the following `CXXFLAGS`: ``` -Werror -Werror=reorder -Werror=thread-safety -Wno-unused-command-line-argument -Wno-deprecated-builtins -Wno-deprecated-volatile -Wno-ambiguous-reversed-operator -Wno-deprecated-enum-enum-conversion ``` The explanations of the `-Wno` flags are as follows: \| Argument \| Reason \| \| -------------------------------------- \| ------------------------------------------------------------ \| \| `-Wno-unused-command-line-argument` \| Lingering use of `-static-libstdc++`, a GCC-ism that isn't recognized as a valid argument in Clang (no longer an issue thanks to https://github.com/dashpay/dash/pull/5958, thanks knst!) \| \| `-Wno-deprecated-builtins` \| Due to usage of [deprecated builtins](`2dacfb08bd/src/bench/nanobench.h (L104-L110)`) in `nanobench` that exist even in the [most current version](`a5a50c2b33/src/include/nanobench.h (L115-L121)`) (see below) \| \| `-Wno-deprecated-volatile` \| The detection code for C++20 in the CI image (based on Ubuntu `focal`) relies on deprecated volatiles (see below) \| \| `-Wno-ambiguous-reversed-operator` \| Due to an ambiguous operator in a Dash unit test ([source](`2dacfb08bd/src/test/fuzz/addrman.cpp (L145)`)) (see below) \| \| `-Wno-deprecated-enum-enum-conversion` \| Due to key combination code in Dash Qt ([source](`2dacfb08bd/src/qt/bitcoingui.cpp (L376)`)) (see below) \| <details> <summary>-Wno-deprecated-builtins</summary> ``` > make Making all in src make[1]: Entering directory '/src/dash/src' make[2]: Entering directory '/src/dash/src' make[3]: Entering directory '/src/dash' make[3]: Leaving directory '/src/dash' CXX bench/bench_dash-addrman.o In file included from bench/addrman.cpp:6: In file included from ./bench/bench.h:16: ./bench/nanobench.h:952:13: error: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Werror,-Wdeprecated-builtins] return !ANKERL_NANOBENCH_IS_TRIVIALLY_COPYABLE(Decayed) \|\| sizeof(Decayed) > sizeof(long) \|\| std::is_pointer<Decayed>::value; ^ ./bench/nanobench.h:107:57: note: expanded from macro 'ANKERL_NANOBENCH_IS_TRIVIALLY_COPYABLE' # define ANKERL_NANOBENCH_IS_TRIVIALLY_COPYABLE(...) __has_trivial_copy(__VA_ARGS__) ^ 1 error generated. make[2]: [Makefile:14567: bench/bench_dash-addrman.o] Error 1 make[2]: Leaving directory '/src/dash/src' make[1]: * [Makefile:18568: all-recursive] Error 1 make[1]: Leaving directory '/src/dash/src' make: * [Makefile:800: all-recursive] Error 1 ``` </details> <details> <summary>-Wno-deprecated-volatile</summary> ``` > ./configure [...] [...] checking whether clang++-16 supports C++20 features with -h std=c++20... no checking whether clang++-16 supports C++20 features with -std=c++2a... no checking whether clang++-16 supports C++20 features with +std=c++2a... no checking whether clang++-16 supports C++20 features with -h std=c++2a... no configure: error: * A compiler with support for C++20 language features is required. > cat config.log This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by Dash Core configure 21.0.0, which was generated by GNU Autoconf 2.69. Invocation command line was $ ./configure --prefix=/src/dash/depends/x86_64-pc-linux-gnu --enable-zmq --enable-reduce-exports --disable-crash-hooks --disable-stacktraces --enable-c++20 --enable-suppress-external-warnings --enable-debug --disable-ccache --with-sanitizers=thread [...] configure:4450: checking whether clang++-16 accepts -g configure:4470: clang++-16 -c -g -I/src/dash/depends/x86_64-pc-linux-gnu/include/ -DDEBUG_LOCKORDER -DENABLE_DASH_DEBUG -DARENA_DEBUG conftest.cpp >&5 configure:4470: $? = 0 configure:4511: result: yes configure:4537: checking whether make supports the include directive configure:4552: make -f confmf.GNU && cat confinc.out this is the am__doit target configure:4555: $? = 0 configure:4574: result: yes (GNU style) configure:4599: checking dependency style of clang++-16 configure:4710: result: gcc3 configure:4756: checking whether clang++-16 supports C++20 features with -std=c++20 configure:5558: clang++-16 -std=c++20 -c -pipe -O2 -Werror -Werror=reorder -Werror=thread-safety -Wno-deprecated-builtins -I/src/dash/depends/x86_64-pc-linux-gnu/include/ -DDEBUG_LOCKORDER -DENABLE_DASH_DEBUG -DARENA_DEBUG conftest.cpp >&5 conftest.cpp:109:36: error: volatile-qualified parameter type 'volatile int' is deprecated [-Werror,-Wdeprecated-volatile] test(const int c, volatile int v) // 'volatile is deprecated in C++20' ^ 1 error generated. ``` </details> <details> <summary>-Wno-ambiguous-reversed-operator</summary> ``` > make Making all in src make[1]: Entering directory '/src/dash/src' make[2]: Entering directory '/src/dash/src' make[3]: Entering directory '/src/dash' make[3]: Leaving directory '/src/dash' [...] CXX test/fuzz/fuzz-addrman.o test/fuzz/addrman.cpp:329:22: error: ISO C++20 considers use of overloaded operator '==' (with operand types 'CAddrManDeterministic' and 'CAddrManDeterministic') to be ambiguous despite there being a unique best viable function [-Werror,-Wambiguous-reversed-operator] assert(addr_man1 == addr_man2); ~~~~~~~~~ ^ ~~~~~~~~~ /usr/include/assert.h:93:27: note: expanded from macro 'assert' (static_cast <bool> (expr) \ ^~~~ test/fuzz/addrman.cpp:145:10: note: ambiguity is between a regular call to this operator and a call with the argument order reversed bool operator==(const CAddrManDeterministic& other) ^ test/fuzz/addrman.cpp:145:10: note: mark 'operator==' as const or add a matching 'operator!=' to resolve the ambiguity 1 error generated. make[2]: * [Makefile:15393: test/fuzz/fuzz-addrman.o] Error 1 make[2]: * Waiting for unfinished jobs.... make[3]: Leaving directory '/src/dash/src/dashbls' make[2]: Leaving directory '/src/dash/src' make[1]: * [Makefile:18568: all-recursive] Error 1 make[1]: Leaving directory '/src/dash/src' make: * [Makefile:800: all-recursive] Error 1 ``` </details> <details> <summary>-Wno-deprecated-enum-enum-conversion</summary> ``` > make Making all in src make[1]: Entering directory '/src/dash/src' make[2]: Entering directory '/src/dash/src' make[3]: Entering directory '/src/dash' make[3]: Leaving directory '/src/dash' [...] CXX qt/libbitcoinqt_a-bitcoingui.o qt/bitcoingui.cpp:376:51: error: arithmetic between different enumeration types ('Qt::Modifier' and 'Qt::Key') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] quitAction->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_Q)); ~~~~~~~~ ^ ~~~~~~~~~ qt/bitcoingui.cpp:609:56: error: arithmetic between different enumeration types ('Qt::Modifier' and 'Qt::Key') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] minimize_action->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_M)); ~~~~~~~~ ^ ~~~~~~~~~ 2 errors generated. make[2]: * [Makefile:12803: qt/libbitcoinqt_a-bitcoingui.o] Error 1 make[2]: * Waiting for unfinished jobs.... make[2]: Leaving directory '/src/dash/src' make[1]: * [Makefile:18568: all-recursive] Error 1 make[1]: Leaving directory '/src/dash/src' make: * [Makefile:800: all-recursive] Error 1 ``` </details> This pull request removes the need for the last two `-Wno` flags, removes some leftover `boost::`{`function`, `lexical_cast`} usage and some `gArgs` usage where a local variable would be more applicable. Additionally, in some builds, there is an deprecation warning (`-Wdeprecation`) for using `[=]` and relying on its implicit capture of `this` (see below), this can be seen during GCC builds but not Clang builds and correspond to a proposal to the C++20 standard ([proposal](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0806r2.html)). It has also been mentioned at https://en.cppreference.com/w/cpp/language/lambda, "The implicit capture of `this` when the capture default is `=` is deprecated. _(since C++20)_". This has also been remedied as part of this PR. <details> <summary>-Wdeprecated</summary> ``` > make -j10 [...] CXX qt/libbitcoinqt_a-trafficgraphwidget.o qt/optionsdialog.cpp: In lambda function: qt/optionsdialog.cpp:195:63: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated] 195 \| connect(appearance, &AppearanceWidget::appearanceChanged, [=](){ \| ^ qt/optionsdialog.cpp:195:63: note: add explicit 'this' or 'this' capture qt/optionsdialog.cpp: In lambda function: qt/optionsdialog.cpp:277:55: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated] 277 \| connect(ui->coinJoinEnabled, &QCheckBox::clicked, [=](bool fChecked) { \| ^ qt/optionsdialog.cpp:277:55: note: add explicit 'this' or 'this' capture qt/optionsdialog.cpp: In lambda function: qt/optionsdialog.cpp:293:45: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated] 293 \| connect(this, &OptionsDialog::rejected, [=]() { \| ^ qt/optionsdialog.cpp:293:45: note: add explicit 'this' or 'this' capture CXX qt/libbitcoinqt_a-utilitydialog.o CXX qt/libbitcoinqt_a-addressbookpage.o [...] ``` </details> ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas (note: N/A)* - [x] I have added or updated relevant unit/integration/functional/e2e tests (note: N/A) - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK `740d25c062` knst: utACK `740d25c062` Tree-SHA512: 52793f9862192ccb556debcac2ec766c4f86e69ec4bedc2fdbaaff965ab4ac478b65b3983b1cb3a92610db85aee6f8668b0ded3494c617c5af7d8801284e461b		2024-04-23 09:45:43 -05:00
.github	chore: narrow score of clang-diff-format for dash specific files only	2024-03-24 00:41:24 +07:00
.tx	fix: follow-up #5393 - should be used `[dash.dash_ents]` (#5472 )	2023-07-01 14:16:50 +03:00
build-aux/m4	Merge #19522 : build: fix building libconsensus with reduced exports for Darwin targets	2024-04-11 02:25:06 +07:00
ci	Merge #5974 : backport: bitcoin#19522, #19809 , #20993 , #21075 , #21126 , #21138 , #21221 , #21354 , #21542	2024-04-12 10:20:15 -05:00
contrib	Merge #21418 : contrib: Make systemd invoke dependencies only when ready	2024-04-22 09:42:16 -05:00
depends	Merge #21354 : build, doc: Drop no longer required packages from macOS cross-compiling dependencies	2024-04-11 02:25:07 +07:00
doc	merge bitcoin#25550: remove note on arm cross-compilation from build-unix.md	2024-04-23 15:34:49 +00:00
share	Merge #20813 : scripted-diff: Bump copyright headers	2024-04-10 03:19:34 +07:00
src	merge bitcoin#24406: Fix Wambiguous-reversed-operator compiler warnings	2024-04-23 15:34:50 +00:00
test	qt: drop leftover `boost::function` usage in Qt, drop header from list	2024-04-23 15:34:48 +00:00
.cirrus.yml	Merge #5976 : backport: bitcoin#17934, #21338 , #21390 , #21445 , #21602 , #21606 , #21609 , #21676 , bitcoin-core/gui#260 ,	2024-04-12 10:30:27 -05:00
.dockerignore	build: add dash minimal development environment container	2021-12-21 12:43:37 +05:30
.editorconfig	Merge #21123 : code style: Add EditorConfig file	2021-07-16 10:04:09 -05:00
.fuzzbuzz.yml	Merge #21064 : refactor: use std::shared_mutex & remove Boost Thread	2024-01-16 09:29:52 -06:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	merge bitcoin#21336: Make .gitignore ignore src/test/fuzz/fuzz.exe	2024-02-06 08:39:51 -06:00
.gitlab-ci.yml	chore: increase amount of build jobs from 4 to 8 for depends	2024-03-17 01:09:41 +07:00
.python-version	partial bitcoin#27483: Bump python minimum version to 3.8	2023-05-11 09:18:48 -05:00
.style.yapf	Merge #15533 : test: .style.yapf: Set column_limit=160	2021-07-10 12:10:51 -05:00
autogen.sh	Merge #17829 : scripted-diff: Bump copyright of files changed in 2019	2023-12-06 11:40:14 -06:00
CMakeLists.txt	chore: Added missing sources files in CMake (#5503 )	2023-07-25 12:23:56 -05:00
configure.ac	Merge #21007 : bitcoind: Add -daemonwait option to wait for initialization	2024-04-22 09:42:16 -05:00
CONTRIBUTING.md	Merge bitcoin/bitcoin#25165 : doc: Explain squashing with merge commits	2024-02-22 20:58:44 -06:00
COPYING	docs: update license year range to 2024 (#5890 )	2024-02-22 20:56:43 -06:00
INSTALL.md	Dashify INSTALL.md and build-unix.md	2018-01-12 16:12:54 +01:00
libdashconsensus.pc.in	revert dash#1432: Rename consensus source library and API	2022-08-09 14:16:28 +05:30
Makefile.am	Merge #20549 : Support make src/bitcoin-node and src/bitcoin-gui	2024-01-16 09:34:27 -06:00
README.md	Merge #20691 : ci, doc: Travis CI features and mentions cleanup	2024-03-27 00:48:26 +07:00
SECURITY.md	Merge bitcoin/bitcoin#23466 : doc: Suggest `keys.openpgp.org` as keyserver in SECURITY.md	2022-04-03 18:46:47 -05:00

README.md

Dash Core staging tree

CI	master	develop
Gitlab

https://www.dash.org

For an immediately usable, binary version of the Dash Core software, see https://www.dash.org/downloads/.

Further information about Dash Core is available in the doc folder.

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information read the original Dash whitepaper.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The develop branch is regularly built (see doc/build-*.md for instructions) and tested, but is not guaranteed to be completely stable.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.