mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 13:32:47 +01:00
a76bafb98c
fa013664ae23d0682a195b9bded85bc19c99536e util: Add type safe GetTime (MarcoFalke)
Pull request description:
There are basically two ways to get the time in Bitcoin Core:
* get the system time (via `GetSystemTimeInSeconds` or `GetTime{Millis,Micros}`)
* get the mockable time (via `GetTime`)
Both return the same type (a plain int). This can lead to (test-only) bugs such as 99464bc38e.
Fix that by deprecating `GetTime` and adding a `GetTime<>` that returns the mockable time in a non-int type. The new util function is currently unused, but new code should it where possible.
ACKs for commit fa0136:
promag:
utACK fa013664.
Tree-SHA512: efab9c463f079fd8fd3030c479637c7b1e8be567a881234bd0f555c8f87e518e3b43ef2466128103db8fc40295aaf24e87ad76d91f338c631246fc703477e95c
40 lines
1.1 KiB
C++
40 lines
1.1 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2019 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_UTILTIME_H
|
|
#define BITCOIN_UTILTIME_H
|
|
|
|
#include <stdint.h>
|
|
#include <string>
|
|
#include <chrono>
|
|
|
|
/**
|
|
* DEPRECATED
|
|
* Use either GetSystemTimeInSeconds (not mockable) or GetTime<T> (mockable)
|
|
*/
|
|
int64_t GetTime();
|
|
|
|
/** Returns the system time (not mockable) */
|
|
int64_t GetTimeMillis();
|
|
/** Returns the system time (not mockable) */
|
|
int64_t GetTimeMicros();
|
|
/** Returns the system time (not mockable) */
|
|
int64_t GetSystemTimeInSeconds(); // Like GetTime(), but not mockable
|
|
|
|
/** For testing. Set e.g. with the setmocktime rpc, or -mocktime argument */
|
|
void SetMockTime(int64_t nMockTimeIn);
|
|
/** For testing */
|
|
int64_t GetMockTime();
|
|
|
|
void MilliSleep(int64_t n);
|
|
|
|
/** Return system time (or mocked time, if set) */
|
|
template <typename T>
|
|
T GetTime();
|
|
|
|
std::string DateTimeStrFormat(const char* pszFormat, int64_t nTime);
|
|
|
|
#endif // BITCOIN_UTILTIME_H
|