mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
12047d77d0
c82190cdb6 tests: Add Python dead code linter (vulture) (practicalswift) 590a57fdec tests: Remove unused testing code (practicalswift) Pull request description: Add Python dead code linter (`vulture`) to Travis. Rationale for allowing dead code only after explicit opt-in (via `--ignore-names`): * Less is more :-) * Unused code is by definition "untested" * Unused code can be an indication of bugs/logical errors. By making the contributor aware of newly introduced unused code it gives him/her an opportunity to investigate if the unused code they introduce is malignant or benign :-) * Unused code is hard to spot for humans and is thus often missed during manual review * [YAGNI](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it) Based on #14312 to make linter job pass. Tree-SHA512: 4c581df7c34986e226e4ade479e0d3c549daf38f4a4dc4564b25564d63e773a1830ba55d1289c771b1fa325483e8855b82b56e61859fe8e4b7dfa54034b093b6
62 lines
2.3 KiB
Python
Executable File
62 lines
2.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2015 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#
|
|
# Test timestampindex generation and fetching
|
|
#
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.test_node import ErrorMatch
|
|
from test_framework.util import assert_equal, connect_nodes
|
|
|
|
|
|
class TimestampIndexTest(BitcoinTestFramework):
|
|
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 4
|
|
|
|
def setup_network(self):
|
|
self.add_nodes(self.num_nodes)
|
|
# Nodes 0/1 are "wallet" nodes
|
|
self.start_node(0)
|
|
self.start_node(1, ["-timestampindex"])
|
|
# Nodes 2/3 are used for testing
|
|
self.start_node(2)
|
|
self.start_node(3, ["-timestampindex"])
|
|
connect_nodes(self.nodes[0], 1)
|
|
connect_nodes(self.nodes[0], 2)
|
|
connect_nodes(self.nodes[0], 3)
|
|
|
|
self.sync_all()
|
|
|
|
def run_test(self):
|
|
self.log.info("Test that settings can't be changed without -reindex...")
|
|
self.stop_node(1)
|
|
self.nodes[1].assert_start_raises_init_error(["-timestampindex=0"], "You need to rebuild the database using -reindex to change -timestampindex", match=ErrorMatch.PARTIAL_REGEX)
|
|
self.start_node(1, ["-timestampindex=0", "-reindex"])
|
|
connect_nodes(self.nodes[0], 1)
|
|
self.sync_all()
|
|
self.stop_node(1)
|
|
self.nodes[1].assert_start_raises_init_error(["-timestampindex"], "You need to rebuild the database using -reindex to change -timestampindex", match=ErrorMatch.PARTIAL_REGEX)
|
|
self.start_node(1, ["-timestampindex", "-reindex"])
|
|
connect_nodes(self.nodes[0], 1)
|
|
self.sync_all()
|
|
|
|
self.log.info("Mining 5 blocks...")
|
|
blockhashes = self.nodes[0].generate(5)
|
|
low = self.nodes[0].getblock(blockhashes[0])["time"]
|
|
high = self.nodes[0].getblock(blockhashes[4])["time"]
|
|
self.sync_all()
|
|
self.log.info("Checking timestamp index...")
|
|
hashes = self.nodes[1].getblockhashes(high, low)
|
|
assert_equal(len(hashes), 5)
|
|
assert_equal(sorted(blockhashes), sorted(hashes))
|
|
self.log.info("Passed")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
TimestampIndexTest().main()
|