mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
fb7b4bbdca
72351784b3df21a89f79076f4b814a6e700b6469 lint: Remove travis env var from commit linter (Fabian Jahr) Pull request description: #19439 was recently merged and seemed to work fine but I now noticed strange behavior when it was running in Travis, which I could not reproduce locally. It turns out `TRAVIS_COMMIT_RANGE` which is used in Travis to get the commits for the linter, uses all the commits that were in a push, which includes all rebase commits for example. This means that the linter can fail on a commit that the developer has never even seen before, which can be very confusing. See an example here which caused me to look into this: https://travis-ci.org/github/bitcoin/bitcoin/jobs/714296381 The commit that is reported as failing in my PR is not part of my PR. I think we rather want to use something like `git merge-base` to get the commit range by default and in Travis. I am leaving the env variable functionality in place with a different name but this is not a variable that can be expected to be present in the CI environments so the `merge-base` range should be used there by default. ACKs for top commit: hebasto: ACK 72351784b3df21a89f79076f4b814a6e700b6469, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: afb27bb386855cb8d5cf84fd3a6c11ef1160b25af6175ed0aa146bf04b9a26eb77298df70df0a855f8c46f19f08b3f62c49872c12974fcfa5526a15ee05b3c10
48 lines
1.4 KiB
Bash
Executable File
48 lines
1.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Linter to check that commit messages have a new line before the body
|
|
# or no body at all
|
|
|
|
export LC_ALL=C
|
|
|
|
EXIT_CODE=0
|
|
|
|
while getopts "?" opt; do
|
|
case $opt in
|
|
?)
|
|
echo "Usage: $0 [N]"
|
|
echo " COMMIT_RANGE='<commit range>' $0"
|
|
echo " $0 -?"
|
|
echo "Checks unmerged commits, the previous N commits, or a commit range."
|
|
echo "COMMIT_RANGE='47ba2c3...ee50c9e' $0"
|
|
exit ${EXIT_CODE}
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [ -z "${COMMIT_RANGE}" ]; then
|
|
if [ -n "$1" ]; then
|
|
COMMIT_RANGE="HEAD~$1...HEAD"
|
|
else
|
|
MERGE_BASE=$(git merge-base HEAD master)
|
|
COMMIT_RANGE="$MERGE_BASE..HEAD"
|
|
fi
|
|
fi
|
|
|
|
while IFS= read -r commit_hash || [[ -n "$commit_hash" ]]; do
|
|
n_line=0
|
|
while IFS= read -r line || [[ -n "$line" ]]; do
|
|
n_line=$((n_line+1))
|
|
length=${#line}
|
|
if [ $n_line -eq 2 ] && [ $length -ne 0 ]; then
|
|
echo "The subject line of commit hash ${commit_hash} is followed by a non-empty line. Subject lines should always be followed by a blank line."
|
|
EXIT_CODE=1
|
|
fi
|
|
done < <(git log --format=%B -n 1 "$commit_hash")
|
|
done < <(git log "${COMMIT_RANGE}" --format=%H)
|
|
|
|
exit ${EXIT_CODE}
|