dash/test/functional
John Newbery 6a18bb9a36 [tests] sync_with_ping should assert that ping hasn't timed out
sync_with_ping currently returns false if the timeout expires, and it is
the caller's responsibility to fail the test. However, none of the tests
currently assert on sync_with_ping()'s return code. This commit adds an
assert to sync_with_ping so the test will fail if the timeout expires.

This commit also removes all the duplicate implementations of
sync_with_ping() from the individual tests.
2017-03-30 08:39:12 -04:00
..
test_framework [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
.gitignore Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
abandonconflict.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
assumevalid.py [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
bip9-softforks.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
bip65-cltv-p2p.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
bip65-cltv.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
bip68-112-113-p2p.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
bip68-sequence.py [tests] Remove unused variables 2017-03-22 17:50:03 +01:00
bipdersig-p2p.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
bipdersig.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
blockchain.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
bumpfee.py Remove call to gettransaction(...) where the result is unused 2017-03-28 15:19:52 +02:00
combine_logs.py [qa] combine_logs: Use ordered list for logfiles 2017-03-27 11:26:31 +02:00
combined_log_template.html Introduce combine_logs.py to combine log files from multiple bitcoinds. 2017-03-21 17:30:13 -04:00
config.ini.in Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py 2017-03-20 10:40:31 -04:00
create_cache.py Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py 2017-03-20 10:40:31 -04:00
decodescript.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
disablewallet.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
forknotify.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
fundrawtransaction.py Merge #9294: Use internal HD chain for change outputs (hd split) 2017-03-29 12:51:06 +02:00
getblocktemplate_longpoll.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
getblocktemplate_proposals.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
getchaintips.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
httpbasics.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
import-rescan.py [tests] Remove unused and duplicate imports 2017-03-22 17:49:23 +01:00
importmulti.py Remove accidental trailing semicolons in Python code 2017-03-28 15:19:19 +02:00
importprunedfunds.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
invalidateblock.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
invalidblockrequest.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
invalidtxrequest.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
keypool.py Switch to 100% for the HD internal keypool size 2017-03-24 10:28:39 +01:00
listsinceblock.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
listtransactions.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
maxblocksinflight.py Remove SingleNodeConnCB 2017-03-28 14:16:21 -04:00
maxuploadtarget.py [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
mempool_limit.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
mempool_packages.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
mempool_reorg.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
mempool_resurrect_test.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
mempool_spendcoinbase.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
merkle_blocks.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
multi_rpc.py [tests] Remove unused variables 2017-03-22 17:50:03 +01:00
nodehandling.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
nulldummy.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
p2p-acceptblock.py [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
p2p-compactblocks.py Add send_await_disconnect() method to p2p-compactblocks.py 2017-03-30 08:39:12 -04:00
p2p-feefilter.py Remove SingleNodeConnCB 2017-03-28 14:16:21 -04:00
p2p-fullblocktest.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
p2p-leaktests.py Remove SingleNodeConnCB 2017-03-28 14:16:21 -04:00
p2p-mempool.py [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
p2p-segwit.py [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
p2p-timeouts.py Remove SingleNodeConnCB 2017-03-28 14:16:21 -04:00
p2p-versionbits-warning.py [tests] sync_with_ping should assert that ping hasn't timed out 2017-03-30 08:39:12 -04:00
preciousblock.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
prioritise_transaction.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
proxy_test.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
pruning.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
rawtransactions.py [tests] Remove unused variables 2017-03-22 17:50:03 +01:00
README.md Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
receivedby.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
reindex.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
replace-by-fee.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
rest.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
rpcbind_test.py Skip rpcbind_test if OS/network requirements are not met. 2017-03-24 00:05:30 -04:00
rpcnamedargs.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
segwit.py [tests] Remove unused and duplicate imports 2017-03-22 17:49:23 +01:00
sendheaders.py Remove SingleNodeConnCB 2017-03-28 14:16:21 -04:00
signmessages.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
signrawtransactions.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
smartfees.py [tests] Remove unused and duplicate imports 2017-03-22 17:49:23 +01:00
test_runner.py Merge #10096: Check that all test scripts in test/functional are being run 2017-03-28 11:36:42 +02:00
txn_clone.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
txn_doublespend.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
wallet-accounts.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
wallet-dump.py Switch to 100% for the HD internal keypool size 2017-03-24 10:28:39 +01:00
wallet-hd.py Fix superfluous cast and code style nits in RPC wallet-hd.py test 2017-03-24 10:28:40 +01:00
wallet.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
walletbackup.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
zapwallettxes.py Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
zmq_test.py [tests] Remove unused variables 2017-03-22 17:50:03 +01:00

Regression tests

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for new regression tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support p2p connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, p2p tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

P2P test design notes

Mininode

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • NodeConn is the class used to connect to a bitcoind. If you implement a callback class that derives from NodeConnCB and pass that to the NodeConn object, your code will receive the appropriate callbacks when events of interest arrive.

  • You can pass the same handler to multiple NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test.

  • Call NetworkThread.start() after all NodeConn objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • RPC calls are available in p2p tests.

  • Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples: p2p-accept-block.py, maxblocksinflight.py.

Comptool

  • Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • a list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.