mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 21:42:47 +01:00
ed88ba72af
3f373659d732a5b1e5fdc692a45b2b8179f66bec Refactor: Replace SigningProvider pointers with unique_ptrs (Andrew Chow)
3afe53c4039103670cec5f9cace897ead76e20a8 Cleanup: Drop unused GUI learnRelatedScripts method (Andrew Chow)
e2f02aa59e3402048269362ff692d49a6df35cfd Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan (Andrew Chow)
c729afd0a3b74a3943e4c359270beaf3e6ff8a7b Box the wallet: Add multiple keyman maps and loops (Andrew Chow)
4977c30d59e88a3e5ee248144bcc023debcd895b refactor: define a UINT256_ONE global constant (Andrew Chow)
415afcccd3e5583defdb76e3a280f48e98983301 HD Split: Avoid redundant upgrades (Andrew Chow)
01b4511206e399981a77976deb15785d18db46ae Make UpgradeKeyMetadata work only on LegacyScriptPubKeyMan (Andrew Chow)
4a7e43e8460127a40a7895519587399feff3b682 Store p2sh scripts in AddAndGetDestinationForScript (Andrew Chow)
501acb5538008d98abe79288b92040bc186b93f3 Always try to sign for all pubkeys in multisig (Andrew Chow)
81610eddbc57c46ae243f45d73e715d509f53a6c List output types in an array in order to be iterated over (Andrew Chow)
eb81fc3ee58d3e88af36d8091b9e4017a8603b3c Refactor: Allow LegacyScriptPubKeyMan to be null (Andrew Chow)
fadc08ad944cad42e805228cdd58e0332f4d7184 Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman (Andrew Chow)
f5be479694d4dbaf59eef562d80fbeacb3bb7dc1 wallet: Improve CWallet:MarkDestinationsDirty (João Barbosa)
Pull request description:
Continuation of wallet boxes project.
Actually makes ScriptPubKeyMan an interface which LegacyScriptPubkeyMan. Moves around functions and things from CWallet into LegacyScriptPubKeyMan so that they are actually separate things without circular dependencies.
***
Introducing the `ScriptPubKeyMan` (short for ScriptPubKeyManager) for managing scriptPubKeys and their associated scripts and keys. This functionality is moved over from `CWallet`. Instead, `CWallet` will have a pointer to a `ScriptPubKeyMan` for every possible address type, internal and external. It will fetch the correct `ScriptPubKeyMan` as necessary. When fetching new addresses, it chooses the `ScriptPubKeyMan` based on address type and whether it is change. For signing, it takes the script and asks each `ScriptPubKeyMan` for whether that `ScriptPubKeyMan` considers that script `IsMine`, whether it has that script, or whether it is able to produce a signature for it. If so, the `ScriptPubKeyMan` will provide a `SigningProvider` to the caller which will use that in order to sign.
There is currently one `ScriptPubKeyMan` - the `LegacyScriptPubKeyMan`. Each `CWallet` will have only one `LegacyScriptPubKeyMan` with the pointers for all of the address types and change pointing to this `LegacyScriptPubKeyMan`. It is created when the wallet is loaded and all keys and metadata are loaded into it instead of `CWallet`. The `LegacyScriptPubKeyMan` is primarily made up of all of the key and script management that used to be in `CWallet`. For convenience, `CWallet` has a `GetLegacyScriptPubKeyMan` which will return the `LegacyScriptPubKeyMan` or a `nullptr` if it does not have one (not yet implemented, but callers will check for the `nullptr`). For purposes of signing, `LegacyScriptPubKeyMan`'s `GetSigningProvider` will return itself rather than a separate `SigningProvider`. This will be different for future `ScriptPubKeyMan`s.
The `LegacyScriptPubKeyMan` will also handle the importing and exporting of keys and scripts instead of `CWallet`. As such, a number of RPCs have been limited to work only if a `LegacyScriptPubKeyMan` can be retrieved from the wallet. These RPCs are `sethdseed`, `addmultisigaddress`, `importaddress`, `importprivkey`, `importpubkey`, `importmulti`, `dumpprivkey`, and `dumpwallet`. Other RPCs which relied on the wallet for scripts and keys have been modified in order to take the `SigningProvider` retrieved from the `ScriptPubKeyMan` for a given script.
Overall, these changes should not effect how everything actually works and the user should experience no difference between having this change and not having it. As such, no functional tests were changed, and the only unit tests changed were those that were directly accessing `CWallet` functions that have been removed.
This PR is the last step in the [Wallet Structure Changes](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Class-Structure-Changes).
ACKs for top commit:
instagibbs:
re-utACK 3f373659d7
Sjors:
re-utACK 3f373659d732a5b1e5fdc692a45b2b8179f66bec (it still compiles on macOS after https://github.com/bitcoin/bitcoin/pull/17261#discussion_r370377070)
meshcollider:
Tested re-ACK 3f373659d732a5b1e5fdc692a45b2b8179f66bec
Tree-SHA512: f8e2b8d9efa750b617691e8702d217ec4c33569ec2554a060141d9eb9b9a3a5323e4216938e2485c44625d7a6e0925d40dea1362b3af9857cf08860c2f344716
371 lines
13 KiB
C++
371 lines
13 KiB
C++
// Copyright (c) 2017-2019 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_RPC_UTIL_H
|
|
#define BITCOIN_RPC_UTIL_H
|
|
|
|
#include <node/coinstats.h>
|
|
#include <node/transaction.h>
|
|
#include <protocol.h>
|
|
#include <pubkey.h>
|
|
#include <rpc/protocol.h>
|
|
#include <rpc/request.h>
|
|
#include <script/script.h>
|
|
#include <script/sign.h>
|
|
#include <script/signingprovider.h>
|
|
#include <script/standard.h>
|
|
#include <univalue.h>
|
|
#include <util/check.h>
|
|
#include <util/strencodings.h>
|
|
|
|
#include <string>
|
|
#include <variant>
|
|
#include <vector>
|
|
|
|
/**
|
|
* String used to describe UNIX epoch time in documentation, factored out to a
|
|
* constant for consistency.
|
|
*/
|
|
extern const std::string UNIX_EPOCH_TIME;
|
|
|
|
class FillableSigningProvider;
|
|
class FillableSigningProvider;
|
|
class CPubKey;
|
|
class CScript;
|
|
struct Sections;
|
|
|
|
/** Wrapper for UniValue::VType, which includes typeAny:
|
|
* Used to denote don't care type. */
|
|
struct UniValueType {
|
|
UniValueType(UniValue::VType _type) : typeAny(false), type(_type) {}
|
|
UniValueType() : typeAny(true) {}
|
|
bool typeAny;
|
|
UniValue::VType type;
|
|
};
|
|
|
|
/**
|
|
* Type-check arguments; throws JSONRPCError if wrong type given. Does not check that
|
|
* the right number of arguments are passed, just that any passed are the correct type.
|
|
*/
|
|
void RPCTypeCheck(const UniValue& params,
|
|
const std::list<UniValueType>& typesExpected, bool fAllowNull=false);
|
|
|
|
/**
|
|
* Type-check one argument; throws JSONRPCError if wrong type given.
|
|
*/
|
|
void RPCTypeCheckArgument(const UniValue& value, const UniValueType& typeExpected);
|
|
|
|
/*
|
|
Check for expected keys/value types in an Object.
|
|
*/
|
|
void RPCTypeCheckObj(const UniValue& o,
|
|
const std::map<std::string, UniValueType>& typesExpected,
|
|
bool fAllowNull = false,
|
|
bool fStrict = false);
|
|
|
|
/**
|
|
* Utilities: convert hex-encoded Values
|
|
* (throws error if not hex).
|
|
*/
|
|
extern uint256 ParseHashV(const UniValue& v, std::string strName);
|
|
extern uint256 ParseHashO(const UniValue& o, std::string strKey);
|
|
extern std::vector<unsigned char> ParseHexV(const UniValue& v, std::string strName);
|
|
extern std::vector<unsigned char> ParseHexO(const UniValue& o, std::string strKey);
|
|
|
|
extern int32_t ParseInt32V(const UniValue& v, const std::string &strName);
|
|
extern int64_t ParseInt64V(const UniValue& v, const std::string &strName);
|
|
extern double ParseDoubleV(const UniValue& v, const std::string &strName);
|
|
extern bool ParseBoolV(const UniValue& v, const std::string &strName);
|
|
|
|
extern CAmount AmountFromValue(const UniValue& value);
|
|
extern std::string HelpExampleCli(const std::string& methodname, const std::string& args);
|
|
extern std::string HelpExampleRpc(const std::string& methodname, const std::string& args);
|
|
|
|
CPubKey HexToPubKey(const std::string& hex_in);
|
|
CPubKey AddrToPubKey(const FillableSigningProvider& keystore, const std::string& addr_in);
|
|
CTxDestination AddAndGetMultisigDestination(const int required, const std::vector<CPubKey>& pubkeys, FillableSigningProvider& keystore, CScript& script_out);
|
|
|
|
UniValue DescribeAddress(const CTxDestination& dest);
|
|
|
|
//! Parse a confirm target option and raise an RPC error if it is invalid.
|
|
unsigned int ParseConfirmTarget(const UniValue& value, unsigned int max_target);
|
|
|
|
/** Returns, given services flags, a list of humanly readable (known) network services */
|
|
UniValue GetServicesNames(ServiceFlags services);
|
|
|
|
//! Parse a JSON range specified as int64, or [int64, int64]
|
|
std::pair<int64_t, int64_t> ParseDescriptorRange(const UniValue& value);
|
|
|
|
/**
|
|
* Serializing JSON objects depends on the outer type. Only arrays and
|
|
* dictionaries can be nested in json. The top-level outer type is "NONE".
|
|
*/
|
|
enum class OuterType {
|
|
ARR,
|
|
OBJ,
|
|
NONE, // Only set on first recursion
|
|
};
|
|
/** Evaluate a descriptor given as a string, or as a {"desc":...,"range":...} object, with default range of 1000. */
|
|
std::vector<CScript> EvalDescriptorStringOrObject(const UniValue& scanobject, FlatSigningProvider& provider);
|
|
|
|
struct RPCArg {
|
|
enum class Type {
|
|
OBJ,
|
|
ARR,
|
|
STR,
|
|
NUM,
|
|
BOOL,
|
|
OBJ_USER_KEYS, //!< Special type where the user must set the keys e.g. to define multiple addresses; as opposed to e.g. an options object where the keys are predefined
|
|
AMOUNT, //!< Special type representing a floating point amount (can be either NUM or STR)
|
|
STR_HEX, //!< Special type that is a STR with only hex chars
|
|
RANGE, //!< Special type that is a NUM or [NUM,NUM]
|
|
};
|
|
|
|
enum class Optional {
|
|
/** Required arg */
|
|
NO,
|
|
/**
|
|
* Optional arg that is a named argument and has a default value of
|
|
* `null`. When possible, the default value should be specified.
|
|
*/
|
|
OMITTED_NAMED_ARG,
|
|
/**
|
|
* Optional argument with default value omitted because they are
|
|
* implicitly clear. That is, elements in an array or object may not
|
|
* exist by default.
|
|
* When possible, the default value should be specified.
|
|
*/
|
|
OMITTED,
|
|
};
|
|
using Fallback = std::variant<Optional, /* default value for optional args */ std::string>;
|
|
const std::string m_names; //!< The name of the arg (can be empty for inner args, can contain multiple aliases separated by | for named request arguments)
|
|
const Type m_type;
|
|
const bool m_hidden;
|
|
const std::vector<RPCArg> m_inner; //!< Only used for arrays or dicts
|
|
const Fallback m_fallback;
|
|
const std::string m_description;
|
|
const std::string m_oneline_description; //!< Should be empty unless it is supposed to override the auto-generated summary line
|
|
const std::vector<std::string> m_type_str; //!< Should be empty unless it is supposed to override the auto-generated type strings. Vector length is either 0 or 2, m_type_str.at(0) will override the type of the value in a key-value pair, m_type_str.at(1) will override the type in the argument description.
|
|
|
|
RPCArg(
|
|
const std::string name,
|
|
const Type type,
|
|
const Fallback fallback,
|
|
const std::string description,
|
|
const std::string oneline_description = "",
|
|
const std::vector<std::string> type_str = {},
|
|
const bool hidden = false)
|
|
: m_names{std::move(name)},
|
|
m_type{std::move(type)},
|
|
m_hidden{hidden},
|
|
m_fallback{std::move(fallback)},
|
|
m_description{std::move(description)},
|
|
m_oneline_description{std::move(oneline_description)},
|
|
m_type_str{std::move(type_str)}
|
|
{
|
|
CHECK_NONFATAL(type != Type::ARR && type != Type::OBJ);
|
|
}
|
|
|
|
RPCArg(
|
|
const std::string name,
|
|
const Type type,
|
|
const Fallback fallback,
|
|
const std::string description,
|
|
const std::vector<RPCArg> inner,
|
|
const std::string oneline_description = "",
|
|
const std::vector<std::string> type_str = {})
|
|
: m_names{std::move(name)},
|
|
m_type{std::move(type)},
|
|
m_hidden{false},
|
|
m_inner{std::move(inner)},
|
|
m_fallback{std::move(fallback)},
|
|
m_description{std::move(description)},
|
|
m_oneline_description{std::move(oneline_description)},
|
|
m_type_str{std::move(type_str)}
|
|
{
|
|
CHECK_NONFATAL(type == Type::ARR || type == Type::OBJ);
|
|
}
|
|
|
|
bool IsOptional() const;
|
|
|
|
/** Return the first of all aliases */
|
|
std::string GetFirstName() const;
|
|
|
|
/** Return the name, throws when there are aliases */
|
|
std::string GetName() const;
|
|
|
|
/**
|
|
* Return the type string of the argument.
|
|
* Set oneline to allow it to be overridden by a custom oneline type string (m_oneline_description).
|
|
*/
|
|
std::string ToString(bool oneline) const;
|
|
/**
|
|
* Return the type string of the argument when it is in an object (dict).
|
|
* Set oneline to get the oneline representation (less whitespace)
|
|
*/
|
|
std::string ToStringObj(bool oneline) const;
|
|
/**
|
|
* Return the description string, including the argument type and whether
|
|
* the argument is required.
|
|
*/
|
|
std::string ToDescriptionString() const;
|
|
};
|
|
|
|
struct RPCResult {
|
|
enum class Type {
|
|
OBJ,
|
|
ARR,
|
|
STR,
|
|
NUM,
|
|
BOOL,
|
|
NONE,
|
|
STR_AMOUNT, //!< Special string to represent a floating point amount
|
|
STR_HEX, //!< Special string with only hex chars
|
|
OBJ_DYN, //!< Special dictionary with keys that are not literals
|
|
ARR_FIXED, //!< Special array that has a fixed number of entries
|
|
NUM_TIME, //!< Special numeric to denote unix epoch time
|
|
ELISION, //!< Special type to denote elision (...)
|
|
};
|
|
|
|
const Type m_type;
|
|
const std::string m_key_name; //!< Only used for dicts
|
|
const std::vector<RPCResult> m_inner; //!< Only used for arrays or dicts
|
|
const bool m_optional;
|
|
const std::string m_description;
|
|
const std::string m_cond;
|
|
|
|
RPCResult(
|
|
const std::string cond,
|
|
const Type type,
|
|
const std::string m_key_name,
|
|
const bool optional,
|
|
const std::string description,
|
|
const std::vector<RPCResult> inner = {})
|
|
: m_type{std::move(type)},
|
|
m_key_name{std::move(m_key_name)},
|
|
m_inner{std::move(inner)},
|
|
m_optional{optional},
|
|
m_description{std::move(description)},
|
|
m_cond{std::move(cond)}
|
|
{
|
|
CHECK_NONFATAL(!m_cond.empty());
|
|
const bool inner_needed{type == Type::ARR || type == Type::ARR_FIXED || type == Type::OBJ || type == Type::OBJ_DYN};
|
|
CHECK_NONFATAL(inner_needed != inner.empty());
|
|
}
|
|
|
|
RPCResult(
|
|
const std::string cond,
|
|
const Type type,
|
|
const std::string m_key_name,
|
|
const std::string description,
|
|
const std::vector<RPCResult> inner = {})
|
|
: RPCResult{cond, type, m_key_name, false, description, inner} {}
|
|
|
|
RPCResult(
|
|
const Type type,
|
|
const std::string m_key_name,
|
|
const bool optional,
|
|
const std::string description,
|
|
const std::vector<RPCResult> inner = {})
|
|
: m_type{std::move(type)},
|
|
m_key_name{std::move(m_key_name)},
|
|
m_inner{std::move(inner)},
|
|
m_optional{optional},
|
|
m_description{std::move(description)},
|
|
m_cond{}
|
|
{
|
|
const bool inner_needed{type == Type::ARR || type == Type::ARR_FIXED || type == Type::OBJ || type == Type::OBJ_DYN};
|
|
CHECK_NONFATAL(inner_needed != inner.empty());
|
|
}
|
|
|
|
RPCResult(
|
|
const Type type,
|
|
const std::string m_key_name,
|
|
const std::string description,
|
|
const std::vector<RPCResult> inner = {})
|
|
: RPCResult{type, m_key_name, false, description, inner} {}
|
|
|
|
/** Append the sections of the result. */
|
|
void ToSections(Sections& sections, OuterType outer_type = OuterType::NONE, const int current_indent = 0) const;
|
|
/** Return the type string of the result when it is in an object (dict). */
|
|
std::string ToStringObj() const;
|
|
/** Return the description string, including the result type. */
|
|
std::string ToDescriptionString() const;
|
|
};
|
|
|
|
struct RPCResults {
|
|
const std::vector<RPCResult> m_results;
|
|
|
|
RPCResults(RPCResult result)
|
|
: m_results{{result}}
|
|
{
|
|
}
|
|
|
|
RPCResults(std::initializer_list<RPCResult> results)
|
|
: m_results{results}
|
|
{
|
|
}
|
|
|
|
/**
|
|
* Return the description string.
|
|
*/
|
|
std::string ToDescriptionString() const;
|
|
};
|
|
|
|
struct RPCExamples {
|
|
const std::string m_examples;
|
|
explicit RPCExamples(
|
|
std::string examples)
|
|
: m_examples(std::move(examples))
|
|
{
|
|
}
|
|
std::string ToDescriptionString() const;
|
|
};
|
|
|
|
class RPCHelpMan
|
|
{
|
|
public:
|
|
RPCHelpMan(std::string name, std::string description, std::vector<RPCArg> args, RPCResults results, RPCExamples examples);
|
|
using RPCMethodImpl = std::function<UniValue(const RPCHelpMan&, const JSONRPCRequest&)>;
|
|
RPCHelpMan(std::string name, std::string description, std::vector<RPCArg> args, RPCResults results, RPCExamples examples, RPCMethodImpl fun);
|
|
|
|
std::string ToString() const;
|
|
UniValue HandleRequest(const JSONRPCRequest& request)
|
|
{
|
|
Check(request);
|
|
return m_fun(*this, request);
|
|
}
|
|
/** If the supplied number of args is neither too small nor too high */
|
|
bool IsValidNumArgs(size_t num_args) const;
|
|
/**
|
|
* Check if the given request is valid according to this command or if
|
|
* the user is asking for help information, and throw help when appropriate.
|
|
*/
|
|
inline void Check(const JSONRPCRequest& request) const {
|
|
if (request.fHelp || !IsValidNumArgs(request.params.size())) {
|
|
throw std::runtime_error(ToString());
|
|
}
|
|
}
|
|
|
|
[[ noreturn ]] inline void Throw() const {
|
|
throw std::runtime_error(ToString());
|
|
}
|
|
|
|
std::vector<std::string> GetArgNames() const;
|
|
|
|
const std::string m_name;
|
|
|
|
private:
|
|
const RPCMethodImpl m_fun;
|
|
const std::string m_description;
|
|
const std::vector<RPCArg> m_args;
|
|
const RPCResults m_results;
|
|
const RPCExamples m_examples;
|
|
};
|
|
|
|
RPCErrorCode RPCErrorFromTransactionError(TransactionError terr);
|
|
UniValue JSONRPCTransactionError(TransactionError terr, const std::string& err_string = "");
|
|
|
|
#endif // BITCOIN_RPC_UTIL_H
|