Dash - Reinventing Cryptocurrency
Go to file
UdjinM6 6c57cc26e2
fix: use correct interruption condition in StartCachePopulatorThread (#5732)
## Issue being fixed or feature implemented
https://github.com/dashpay/dash/pull/4788#discussion_r854468664

noticed while working on #5731

## What was done?

## How Has This Been Tested?
run a node, check logs - there is a meaningful time span between `start`
and `done` now and not just zeros all the time.

## Breaking Changes

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
2023-11-27 12:13:06 -06:00
.github fix: pass GITHUB_REPOSITORY into Dockerfile.GitHubActions.Release (#5724) 2023-11-24 11:23:10 -06:00
.tx
build-aux/m4
ci fix: follow-up partial bitcoin/bitcoin#25063 - actually load binaries with x86_64-apple-darwin platform 2023-11-24 11:23:46 -06:00
contrib Merge bitcoin/bitcoin#24603: macdeploy: remove unused detached-sig-apply.sh 2023-11-24 11:23:46 -06:00
depends Merge bitcoin/bitcoin#25817: build: fix cross-arch macOS M1 build reproducibility 2023-11-24 11:23:46 -06:00
doc Merge branch 'master' into merge_master_20.0.1 2023-11-20 20:07:12 +03:00
share
src fix: use correct interruption condition in StartCachePopulatorThread (#5732) 2023-11-27 12:13:06 -06:00
test fix: follow-up partial bitcoin/bitcoin#25063 - actually load binaries with x86_64-apple-darwin platform 2023-11-24 11:23:46 -06:00
.cirrus.yml
.dockerignore
.editorconfig
.fuzzbuzz.yml
.gitattributes
.gitignore
.gitlab-ci.yml feat: cache downloaded releases 2023-09-19 08:54:12 -05:00
.python-version
.style.yapf
.travis.yml
autogen.sh
CMakeLists.txt
configure.ac partial bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0 2023-11-21 07:59:03 -06:00
CONTRIBUTING.md
COPYING
INSTALL.md
libdashconsensus.pc.in
Makefile.am Merge bitcoin/bitcoin#24603: macdeploy: remove unused detached-sig-apply.sh 2023-11-24 11:23:46 -06:00
README.md
SECURITY.md

Dash Core staging tree 18.0

CI master develop
Gitlab Build Status Build Status

https://www.dash.org

For an immediately usable, binary version of the Dash Core software, see https://www.dash.org/downloads/.

Further information about Dash Core is available in the doc folder.

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information read the original Dash whitepaper.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.