mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
56d2bc249b
e2c40a4ed5272d72fea997bd936fba28bb753226 guix-attest: Error out if SHA256SUMS is unexpected (Carl Dong) 4cc35daed557f38b080360a89036b2e97a6f78c2 Rewrite guix-{attest,verify} for new hier (Carl Dong) 28a9c9b83924f585b397f0f3b8e9e73780ac0ad6 Make SHA256SUMS fragment right after build (Carl Dong) Pull request description: Based on: #22075 Code reviewers: I recommend reading the new `guix-{attest,verify}` files instead of trying to read the diff The following changes resolve many usability improvements which were pointed out to me: 1. Some maintainers like to extract their "uncodesigned tarball" inside the `output/` directory, resulting in the older `guix-attest` mistakenly attesting to the extracted contents 2. Maintainers whose GPG keys reside on an external smartcard often need to physically interact with the smartcard as a way to approve the signing operation, having one signature per platform means a lot of fidgeting 3. Maintainers wishing to sign on a separate machine now has the option of transferring only a subtree of `output/`, namely `output/*/SHA256SUMS.part`, in order to perform a signature (you may need to specify an `$OUTDIR_BASE` env var) 4. An `all.SHA256SUMS` file should be usable as the base `SHA256SUMS` in bitcoin core torrents and on the release server. For those who sign on an separate machine than the one you do builds on, the following steps will work: 1. `env GUIX_SIGS_REPO=/home/achow101/guix.sigs SIGNER=achow101 NO_SIGN=1 ./contrib/guix/guix-attest` 2. Copy `/home/achow101/guix.sigs/<tag>/achow101` (which does not yet have signatures) to signing machine 3. Sign the `SHA256SUMS` files: ```bash for i in "<path-to-achow101>/*.SHA256SUMS"; do gpg --detach-sign --local-user "<your-key-here>" --armor --output "$i"{.asc,} done ``` 5. Upload `<path-to-achow101>` (now with signatures) to `guix.sigs` ----- After this change, output directories will now include a `SHA256SUMS.part` fragment, created immediately after a successful build: ``` output └── x86_64-w64-mingw32 ├── bitcoin-4e069f7589da-win64-debug.zip ├── bitcoin-4e069f7589da-win64-setup-unsigned.exe ├── bitcoin-4e069f7589da-win64.zip ├── bitcoin-4e069f7589da-win-unsigned.tar.gz └── SHA256SUMS.part ``` These `SHA256SUMS.part` fragments look something like: ``` 3ebd7262b1a0a5bb757fef1f70e7e14033c70f98c059bc4dbfee5d1992b25825 dist-archive/bitcoin-4e069f7589da.tar.gz def2e7d3de5ab3e3f955344e75151df4f33713f9101f5295bd13c9375bdf633b x86_64-w64-mingw32/bitcoin-4e069f7589da-win64-debug.zip 643049fe3ee4a4e83a1739607e67b11b7c9b1a66208a6f35a9ff634ba795500e x86_64-w64-mingw32/bitcoin-4e069f7589da-win64-setup-unsigned.exe a247a1ccec0ccc2e138c648284bd01f6a761f2d8d6d07d91b5b4a6670ec3f288 x86_64-w64-mingw32/bitcoin-4e069f7589da-win-unsigned.tar.gz fab76a836dcc592e39c04fd2396696633fb6eb56e39ecbf6c909bd173ed4280c x86_64-w64-mingw32/bitcoin-4e069f7589da-win64.zip ``` Meaning that they are valid `SHA256SUMS` files when `sha256sum --check`'d at the `guix-build-*/output` directory level When `guix-attest` is invoked, these `SHA256SUMS.part` files are combined and sorted (by `-k2`, `LC_ALL=C`) to create: 1. `noncodesigned.SHA256SUMS` for a manifest of all non-codesigned outputs, and 3. `all.SHA256SUMS` for a manifest of all outputs including non-codesigned outputs Then both files are signed, resulting in the following `guix.sigs` hierarchy: ``` 4e069f7589da/ └── dongcarl ├── all.SHA256SUMS ├── all.SHA256SUMS.asc ├── noncodesigned.SHA256SUMS └── noncodesigned.SHA256SUMS.asc ``` ACKs for top commit: achow101: ACK e2c40a4ed5272d72fea997bd936fba28bb753226 hebasto: ACK e2c40a4ed5272d72fea997bd936fba28bb753226, tested on Linux Mint 20.1 (x86_64) with and w/o `NO_SIGN=1`. Changes in `contrib/guix/libexec/codesign.sh` and `contrib/guix/guix-verify` are reviewed only. Tree-SHA512: 618aacefb0eb6595735a9ab6a98ea6598fce65f9ccf33fa1e7ef93bf140c0f6cfc16e34870c6aa3e4777dd3f004b92a82a994141879870141742df948ec59c1f
241 lines
6.3 KiB
Bash
Executable File
241 lines
6.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
export LC_ALL=C
|
|
set -e -o pipefail
|
|
|
|
# Source the common prelude, which:
|
|
# 1. Checks if we're at the top directory of the Bitcoin Core repository
|
|
# 2. Defines a few common functions and variables
|
|
#
|
|
# shellcheck source=libexec/prelude.bash
|
|
source "$(dirname "${BASH_SOURCE[0]}")/libexec/prelude.bash"
|
|
|
|
|
|
###################
|
|
## Sanity Checks ##
|
|
###################
|
|
|
|
################
|
|
# Required non-builtin commands should be invokable
|
|
################
|
|
|
|
check_tools cat env basename mkdir xargs find
|
|
if [ -z "$NO_SIGN" ]; then
|
|
check_tools gpg
|
|
fi
|
|
|
|
################
|
|
# Required env vars should be non-empty
|
|
################
|
|
|
|
cmd_usage() {
|
|
cat <<EOF
|
|
Synopsis:
|
|
|
|
env GUIX_SIGS_REPO=<path/to/guix.sigs> \\
|
|
SIGNER=GPG_KEY_NAME[=SIGNER_NAME] \\
|
|
[ NO_SIGN=1 ]
|
|
./contrib/guix/guix-attest
|
|
|
|
Example w/o overriding signing name:
|
|
|
|
env GUIX_SIGS_REPO=/home/achow101/guix.sigs \\
|
|
SIGNER=achow101 \\
|
|
./contrib/guix/guix-attest
|
|
|
|
Example overriding signing name:
|
|
|
|
env GUIX_SIGS_REPO=/home/dongcarl/guix.sigs \\
|
|
SIGNER=0x96AB007F1A7ED999=dongcarl \\
|
|
./contrib/guix/guix-attest
|
|
|
|
Example w/o signing, just creating SHA256SUMS:
|
|
|
|
env GUIX_SIGS_REPO=/home/achow101/guix.sigs \\
|
|
SIGNER=achow101 \\
|
|
NO_SIGN=1 \\
|
|
./contrib/guix/guix-attest
|
|
|
|
EOF
|
|
}
|
|
|
|
if [ -z "$GUIX_SIGS_REPO" ] || [ -z "$SIGNER" ]; then
|
|
cmd_usage
|
|
exit 1
|
|
fi
|
|
|
|
################
|
|
# GUIX_SIGS_REPO should exist as a directory
|
|
################
|
|
|
|
if [ ! -d "$GUIX_SIGS_REPO" ]; then
|
|
cat << EOF
|
|
ERR: The specified GUIX_SIGS_REPO is not an existent directory:
|
|
|
|
'$GUIX_SIGS_REPO'
|
|
|
|
Hint: Please clone the guix.sigs repository and point to it with the
|
|
GUIX_SIGS_REPO environment variable.
|
|
|
|
EOF
|
|
cmd_usage
|
|
exit 1
|
|
fi
|
|
|
|
################
|
|
# The key specified in SIGNER should be usable
|
|
################
|
|
|
|
IFS='=' read -r gpg_key_name signer_name <<< "$SIGNER"
|
|
if [ -z "${signer_name}" ]; then
|
|
signer_name="$gpg_key_name"
|
|
fi
|
|
|
|
if [ -z "$NO_SIGN" ] && ! gpg --dry-run --list-secret-keys "${gpg_key_name}" >/dev/null 2>&1; then
|
|
echo "ERR: GPG can't seem to find any key named '${gpg_key_name}'"
|
|
exit 1
|
|
fi
|
|
|
|
################
|
|
# We should be able to find at least one output
|
|
################
|
|
|
|
echo "Looking for build output SHA256SUMS fragments in ${OUTDIR_BASE}"
|
|
|
|
shopt -s nullglob
|
|
sha256sum_fragments=( "$OUTDIR_BASE"/*/SHA256SUMS.part ) # This expands to an array of directories...
|
|
shopt -u nullglob
|
|
|
|
noncodesigned_fragments=()
|
|
codesigned_fragments=()
|
|
|
|
if (( ${#sha256sum_fragments[@]} )); then
|
|
echo "Found build output SHA256SUMS fragments:"
|
|
for outdir in "${sha256sum_fragments[@]}"; do
|
|
echo " '$outdir'"
|
|
case "$outdir" in
|
|
"$OUTDIR_BASE"/*-codesigned/SHA256SUMS.part)
|
|
codesigned_fragments+=("$outdir")
|
|
;;
|
|
*)
|
|
noncodesigned_fragments+=("$outdir")
|
|
;;
|
|
esac
|
|
done
|
|
echo
|
|
else
|
|
echo "ERR: Could not find any build output SHA256SUMS fragments in ${OUTDIR_BASE}"
|
|
exit 1
|
|
fi
|
|
|
|
##############
|
|
## Attest ##
|
|
##############
|
|
|
|
# Usage: out_name $outdir
|
|
#
|
|
# HOST: The output directory being attested
|
|
#
|
|
out_name() {
|
|
basename "$(dirname "$1")"
|
|
}
|
|
|
|
shasum_already_exists() {
|
|
cat <<EOF
|
|
--
|
|
|
|
ERR: An ${1} file already exists for '${VERSION}' and attests
|
|
differently. You likely previously attested to a partial build (e.g. one
|
|
where you specified the HOST environment variable).
|
|
|
|
See the diff above for more context.
|
|
|
|
Hint: You may wish to remove the existing attestations and their signatures by
|
|
invoking:
|
|
|
|
rm '${PWD}/${1}'{,.asc}
|
|
|
|
Then try running this script again.
|
|
|
|
EOF
|
|
}
|
|
|
|
echo "Attesting to build outputs for version: '${VERSION}'"
|
|
echo ""
|
|
|
|
outsigdir="$GUIX_SIGS_REPO/$VERSION/$signer_name"
|
|
mkdir -p "$outsigdir"
|
|
(
|
|
cd "$outsigdir"
|
|
|
|
temp_noncodesigned="$(mktemp)"
|
|
trap 'rm -rf -- "$temp_noncodesigned"' EXIT
|
|
|
|
if (( ${#noncodesigned_fragments[@]} )); then
|
|
cat "${noncodesigned_fragments[@]}" \
|
|
| sort -u \
|
|
| sort -k2 \
|
|
> "$temp_noncodesigned"
|
|
if [ -e noncodesigned.SHA256SUMS ]; then
|
|
# The SHA256SUMS already exists, make sure it's exactly what we
|
|
# expect, error out if not
|
|
if diff -u noncodesigned.SHA256SUMS "$temp_noncodesigned"; then
|
|
echo "A noncodesigned.SHA256SUMS file already exists for '${VERSION}' and is up-to-date."
|
|
else
|
|
shasum_already_exists noncodesigned.SHA256SUMS
|
|
exit 1
|
|
fi
|
|
else
|
|
mv "$temp_noncodesigned" noncodesigned.SHA256SUMS
|
|
fi
|
|
else
|
|
echo "ERR: No noncodesigned outputs found for '${VERSION}', exiting..."
|
|
exit 1
|
|
fi
|
|
|
|
temp_codesigned="$(mktemp)"
|
|
trap 'rm -rf -- "$temp_codesigned"' EXIT
|
|
|
|
if (( ${#codesigned_fragments[@]} )); then
|
|
# Note: all.SHA256SUMS attests to all of $sha256sum_fragments, but is
|
|
# not needed if there are no $codesigned_fragments
|
|
cat "${sha256sum_fragments[@]}" \
|
|
| sort -u \
|
|
| sort -k2 \
|
|
> "$temp_codesigned"
|
|
if [ -e codesigned.SHA256SUMS ]; then
|
|
# The SHA256SUMS already exists, make sure it's exactly what we
|
|
# expect, error out if not
|
|
if diff -u all.SHA256SUMS "$temp_codesigned"; then
|
|
echo "An all.SHA256SUMS file already exists for '${VERSION}' and is up-to-date."
|
|
else
|
|
shasum_already_exists all.SHA256SUMS
|
|
exit 1
|
|
fi
|
|
else
|
|
mv "$temp_codesigned" codesigned.SHA256SUMS
|
|
fi
|
|
else
|
|
# It is fine to have the codesigned outputs be missing (perhaps the
|
|
# detached codesigs have not been published yet), just print a log
|
|
# message instead of erroring out
|
|
echo "INFO: No codesigned outputs found for '${VERSION}', skipping..."
|
|
fi
|
|
|
|
if [ -z "$NO_SIGN" ]; then
|
|
echo "Signing SHA256SUMS to produce SHA256SUMS.asc"
|
|
for i in *.SHA256SUMS; do
|
|
if [ ! -e "$i".asc ]; then
|
|
gpg --detach-sign \
|
|
--local-user "$gpg_key_name" \
|
|
--armor \
|
|
--output "$i".asc "$i"
|
|
else
|
|
echo "Signature already there"
|
|
fi
|
|
done
|
|
else
|
|
echo "Not signing SHA256SUMS as \$NO_SIGN is not empty"
|
|
fi
|
|
echo ""
|
|
)
|