mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
a8820d894f
fab558612278909df93bdf88f5727b04f13aef0f doc: Use precise permission flags where possible (MarcoFalke)
Pull request description:
Instead of mentioning the all-encompassing `-whitelist*` settings, change the docs to mention the exact permission flag that will influence the behaviour.
This is needed because in the future, the too-broad `-whitelist*` settings (they either include *all* permission flags or apply to *all* peers) might be deprecated to require the permission flags to be enumerated.
Alternatively, in the future there could be an RPC to set the net permission flags on an existing connection, in which case the `-whitelist*` terminology is of no help.
ACKs for top commit:
jnewbery:
reACK fab558612278909df93bdf88f5727b04f13aef0f
fjahr:
Code review ACK fab558612278909df93bdf88f5727b04f13aef0f
jonatack:
ACK fab558612278909df93bdf88f5727b04f13aef0f
Tree-SHA512: c7dea3e577d90103bb2b0ffab7b7c8640b388932a3a880f69e2b70747fc9213dc1f437085671fd54c902ec2a578458b8a2fae6dbe076642fb88efbf9fa9e679c
88 lines
4.2 KiB
Python
Executable File
88 lines
4.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test p2p blocksonly"""
|
|
|
|
from test_framework.messages import msg_tx, CTransaction, FromHex
|
|
from test_framework.mininode import P2PInterface
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
|
|
class P2PBlocksOnly(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = False
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-blocksonly"]]
|
|
|
|
def run_test(self):
|
|
self.nodes[0].add_p2p_connection(P2PInterface())
|
|
|
|
self.log.info('Check that txs from p2p are rejected and result in disconnect')
|
|
prevtx = self.nodes[0].getblock(self.nodes[0].getblockhash(1), 2)['tx'][0]
|
|
rawtx = self.nodes[0].createrawtransaction(
|
|
inputs=[{
|
|
'txid': prevtx['txid'],
|
|
'vout': 0
|
|
}],
|
|
outputs=[{
|
|
self.nodes[0].get_deterministic_priv_key()[0]: 500 - 0.00125
|
|
}],
|
|
)
|
|
sigtx = self.nodes[0].signrawtransactionwithkey(
|
|
hexstring=rawtx,
|
|
privkeys=[self.nodes[0].get_deterministic_priv_key()[1]],
|
|
prevtxs=[{
|
|
'txid': prevtx['txid'],
|
|
'vout': 0,
|
|
'scriptPubKey': prevtx['vout'][0]['scriptPubKey']['hex'],
|
|
}],
|
|
)['hex']
|
|
assert_equal(self.nodes[0].getnetworkinfo()['localrelay'], False)
|
|
with self.nodes[0].assert_debug_log(['tx sent in violation of protocol peer=0']):
|
|
self.nodes[0].p2p.send_message(msg_tx(FromHex(CTransaction(), sigtx)))
|
|
self.nodes[0].p2p.wait_for_disconnect()
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], 0)
|
|
|
|
# Remove the disconnected peer and add a new one.
|
|
del self.nodes[0].p2ps[0]
|
|
self.nodes[0].add_p2p_connection(P2PInterface())
|
|
|
|
self.log.info('Check that txs from rpc are not rejected and relayed to other peers')
|
|
assert_equal(self.nodes[0].getpeerinfo()[0]['relaytxes'], True)
|
|
txid = self.nodes[0].testmempoolaccept([sigtx])[0]['txid']
|
|
with self.nodes[0].assert_debug_log(['received getdata for: tx {} peer=1'.format(txid)]):
|
|
self.nodes[0].sendrawtransaction(sigtx)
|
|
self.bump_mocktime(60)
|
|
self.nodes[0].p2p.wait_for_tx(txid)
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], 1)
|
|
|
|
self.log.info('Check that txs from forcerelay peers are not rejected and relayed to others')
|
|
self.log.info("Restarting node 0 with forcerelay permission and blocksonly")
|
|
self.restart_node(0, ["-persistmempool=0", "-whitelist=127.0.0.1", "-whitelistforcerelay", "-blocksonly"])
|
|
assert_equal(self.nodes[0].getrawmempool(), [])
|
|
first_peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
second_peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
peer_1_info = self.nodes[0].getpeerinfo()[0]
|
|
assert_equal(peer_1_info['whitelisted'], True)
|
|
assert_equal(peer_1_info['permissions'], ['noban', 'forcerelay', 'relay', 'mempool'])
|
|
peer_2_info = self.nodes[0].getpeerinfo()[1]
|
|
assert_equal(peer_2_info['whitelisted'], True)
|
|
assert_equal(peer_2_info['permissions'], ['noban', 'forcerelay', 'relay', 'mempool'])
|
|
assert_equal(self.nodes[0].testmempoolaccept([sigtx])[0]['allowed'], True)
|
|
txid = self.nodes[0].testmempoolaccept([sigtx])[0]['txid']
|
|
|
|
self.log.info('Check that the tx from forcerelay first_peer is relayed to others (ie.second_peer)')
|
|
with self.nodes[0].assert_debug_log(["received getdata"]):
|
|
first_peer.send_message(msg_tx(FromHex(CTransaction(), sigtx)))
|
|
self.log.info('Check that the forcerelay peer is still connected after sending the transaction')
|
|
assert_equal(first_peer.is_connected, True)
|
|
second_peer.wait_for_tx(txid)
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], 1)
|
|
self.log.info("Forcerelay peer's transaction is accepted and relayed")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
P2PBlocksOnly().main()
|