mirror of https://github.com/dashpay/dash.git synced 2024-12-26 04:22:55 +01:00

History

Pieter Wuille 7ff6515c88 Merge #13033 : Build txindex in parallel with validation `9b2704777c` [doc] Include txindex changes in the release notes. (Jim Posen) `ed77dd6b30` [test] Simple unit test for TxIndex. (Jim Posen) `6d772a3d44` [rpc] Public interfaces to GetTransaction block until synced. (Jim Posen) `a03f804f2a` [index] Move disk IO logic from GetTransaction to TxIndex::FindTx. (Jim Posen) `e0a3b80033` [validation] Replace tx index code in validation code with TxIndex. (Jim Posen) `8181db88f6` [init] Initialize and start TxIndex in init code. (Jim Posen) `f90c3a62f5` [index] TxIndex method to wait until caught up. (Jim Posen) `70d510d93c` [index] Allow TxIndex sync thread to be interrupted. (Jim Posen) `94b4f8bbb9` [index] TxIndex initial sync thread. (Jim Posen) `34d68bf3a3` [index] Create new TxIndex class. (Jim Posen) `c88bcec93f` [db] Migration for txindex data to new, separate database. (Jim Posen) `0cb8303241` [db] Create separate database for txindex. (Jim Posen) Pull request description: I'm re-opening #11857 as a new pull request because the last one stopped loading for people ------------------------------- This refactors the tx index code to be in it's own class and get built concurrently with validation code. The main benefit is decoupling and moving the txindex into a separate DB. The primary motivation is to lay the groundwork for other indexers that might be desired (such as the [compact filters](https://github.com/bitcoin/bips/pull/636)). The basic idea is that the TxIndex spins up its own thread, which first syncs the txindex to the current block index, then once in sync the BlockConnected ValidationInterface hook writes new blocks. ### DB changes At the suggestion of some other developers, the txindex has been split out into a separate database. A data migration runs at startup on any nodes with a legacy txindex. Currently the migration blocks node initialization until complete. ### Open questions - Should the migration of txindex data from the old DB to the new DB block in init or should it happen in a background thread? The downside to backgrounding it is that `getrawtransaction` would return an error message saying the txindex is syncing while the migration is running. ### Impact In a sample size n=1 test where I synced nodes from scratch, the average time [Index writing](https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L1903) was 3.36ms in master and 1.72ms in this branch. The average time between `UpdateTip` log lines for sequential blocks between 400,000 and IBD end on mainnet was 0.297204s in master and 0.286134s in this branch. Most likely this is just variance in IBD times, but I can try with some more trials if people want. Tree-SHA512: 451fd7d95df89dfafceaa723cdf0f7b137615b531cf5c5035cfb54e9ccc2026cec5ac85edbcf71b7f4e2f102e36e9202b8b3a667e1504a9e1a9976ab1f0079c4		2021-05-25 13:48:04 +03:00
..
check-doc.py	backport bitcoin#13190: Have gArgs handle printing help	2021-03-19 18:00:24 +03:00
check-rpc-mappings.py	refactor: PrivateSend -> CoinJoin + Move the tab (#4038 )	2021-03-17 18:36:11 -04:00
commit-script-check.sh	Make shellcheck 0.7.2 happy	2021-05-05 14:12:04 +03:00
git-subtree-check.sh
lint-all.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-circular-dependencies.sh	Merge #13033 : Build txindex in parallel with validation	2021-05-25 13:48:04 +03:00
lint-filenames.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-format-strings.py	Merge #13033 : Build txindex in parallel with validation	2021-05-25 13:48:04 +03:00
lint-format-strings.sh
lint-include-guards.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-includes.sh	Merge #13862 : drop boost::interprocess::file_lock	2021-05-20 10:15:17 +05:30
lint-locale-dependence.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-logs.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-python-shebang.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-python-utf8-encoding.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-python.sh	Merge #12284 : Remove assigned but never used local variables. Enable Travis checking for unused local variables.	2020-10-26 20:35:28 -04:00
lint-shell-locale.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-shell.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-tests.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
lint-whitespace.sh	Merge #13510 : Scripts and tools: Obsolete #!/bin/bash shebang	2020-12-18 12:55:45 -06:00
README.md

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.