Dash - Reinventing Cryptocurrency
Go to file
MarcoFalke 701c5db53c
Merge bitcoin/bitcoin#22361: refactor: Make httpserver work queue a unique_ptr
fa92e60f38cb109fe5a3c7acfe1017ffebc388cc refactor: Make httpserver work queue a unique_ptr (MarcoFalke)

Pull request description:

  This simplifies the code a bit because `if (p) { delete p; p = nullptr; }` can be replaced by a call to the `reset()` member.

ACKs for top commit:
  promag:
    Core review ACK fa92e60f38cb109fe5a3c7acfe1017ffebc388cc.
  jonatack:
    ACK fa92e60f38cb109fe5a3c7acfe1017ffebc388cc code review, debug build clean, ran test/functional/interface*.py tests locally as a sanity check
  hebasto:
    ACK fa92e60f38cb109fe5a3c7acfe1017ffebc388cc, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 6b122162317dd4ad6889341745c7ac1903a3ee510f6548f46dc356308442a6eff13eb8dc604c38ba18783e7a66d2b836d641a8594ff980a010c12c97f3856684
2021-09-24 13:32:16 -04:00
.github ci: Add github-action that automatically runs clang-format. Will not fail CI (#4387) 2021-09-02 23:00:07 +03:00
.travis Merge #16438: travis: Print memory and number of cpus 2021-09-12 14:15:12 -04:00
.tx Merge remote-tracking branch 'bitcoin/0.12' into HEAD 2016-02-06 16:48:04 +03:00
build-aux/m4 Merge pull request #4262 from PastaPastaPasta/backport-triv-pr17 2021-07-16 20:30:46 +03:00
ci merge #17361: Lint Gitian descriptors with ShellCheck 2021-09-03 21:35:53 +05:30
contrib Merge pull request #4433 from PastaPastaPasta/backport-trivial-pr19 2021-09-19 10:34:12 +03:00
depends Merge bitcoin/bitcoin#22123: depends: Fix qt.mk for mac arm64 2021-09-24 13:32:15 -04:00
doc Merge #20741: doc: Update 'Secure string handling' 2021-09-18 21:41:46 -04:00
docker Partial Merge #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. 2021-08-15 11:08:08 -04:00
share Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet 2021-09-10 20:54:52 -04:00
src Merge bitcoin/bitcoin#22361: refactor: Make httpserver work queue a unique_ptr 2021-09-24 13:32:16 -04:00
test Merge bitcoin/bitcoin#22201: test: Fix TestShell to allow running in Jupyter Notebook 2021-09-24 13:32:16 -04:00
.cirrus.yml Merge #15520: cirrus: Run extended test feature_pruning 2021-07-12 20:16:37 -05:00
.editorconfig Merge #21123: code style: Add EditorConfig file 2021-07-16 10:04:09 -05:00
.fuzzbuzz.yml Merge #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz config 2021-09-18 21:41:40 -04:00
.gitattributes Separate protocol versioning from clientversion 2014-10-29 00:24:40 -04:00
.gitignore bitcoin#17452: update fuzz directory in .gitignore 2021-08-11 08:50:43 +05:30
.gitlab-ci.yml ci: Exclude some less important binaries to reduce the size of the artifacts (#4441) 2021-09-19 00:30:07 +03:00
.python-version merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
.style.yapf Merge #15533: test: .style.yapf: Set column_limit=160 2021-07-10 12:10:51 -05:00
.travis.yml Merge pull request #4396 from Munkybooty/backports-0.18-pr16 2021-09-14 12:05:37 -04:00
autogen.sh Merge #13454: Make sure LC_ALL=C is set in all shell scripts 2020-07-28 21:35:31 -05:00
CMakeLists.txt merge #20419: set minimum supported macOS to 10.14 2021-09-03 21:35:53 +05:30
configure.ac Merge pull request #4434 from PastaPastaPasta/backport-trivial-pr21 2021-09-19 10:35:20 +03:00
CONTRIBUTING.md Merge #21263: doc: Clarify that squashing should happen before review 2021-07-15 19:39:10 -05:00
COPYING Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00
INSTALL.md Dashify INSTALL.md and build-unix.md 2018-01-12 16:12:54 +01:00
libdashconsensus.pc.in Merge #7192: Unify product name to as few places as possible 2017-12-11 08:30:26 +01:00
Makefile.am Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet 2021-09-10 20:54:52 -04:00
README.md Merge #14684: [doc] conf: Remove deprecated options from docs, Other cleanup 2021-08-03 11:42:08 -04:00
SECURITY.md docs: Adjust SECURITY.md 2021-07-12 20:16:37 -05:00

Dash Core staging tree 0.17

CI master develop
Gitlab Build Status Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.