dash/doc
Samuel Dobson 76d30c9607
Merge #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock manually selected coins
6d1f51343cf11b07cd401fbd0c5bc3603e185a0e [rpc] fundrawtransaction, walletcreatefundedpsbt lock manually selected coins (Sjors Provoost)

Pull request description:

  When using `fundrawtransaction` and `walletcreatefundedpsbt` with `lockUnspents`, it would only lock automatically selected coins, not manually selected coins. That doesn't make much sense to me if the goal is to prevent accidentally double-spending yourself before you broadcast a transaction.

  Note that when  creating a transaction, manually selected coins are automatic "unlocked" (or more accurately: the lock is ignored). Earlier versions of this PR introduced an error when a locked coin is manually selected, but this idea was abandoned after some discussion. An application that uses this RPC should either rely on automatic coin selection (with `lockUnspents`) or handle lock concurrency itself with manual coin selection. In particular it needs to make sure to avoid/pause calls with automatic coin selection between calling `lockunspent` and the subsequent spending RPC.

  See #7518 for historical background.

ACKs for top commit:
  meshcollider:
    Code review ACK 6d1f51343cf11b07cd401fbd0c5bc3603e185a0e
  fjahr:
    Code review ACK 6d1f51343cf11b07cd401fbd0c5bc3603e185a0e

Tree-SHA512: 8773c788d92f2656952e1beac147ba9956b8c5132d474e0880e4c89ff53642928b4cbfcd1cb3d17798b9284f02618a8830c93a9f7a4733e5bded96adff1d5d4d
2024-01-22 19:44:36 -06:00
..
man docs: update man pages (#5672) 2023-11-07 08:04:39 -06:00
release-notes/dash docs: release notes for 20.0.4 and archiving old one 2024-01-12 00:48:31 +07:00
.gitignore
assets-attribution.md
benchmarking.md Merge #17081: doc: fix Makefile target in benchmarking.md 2022-05-17 01:20:21 -04:00
bips.md Merge #19569: Enable fetching of orphan parents from wtxid peers 2024-01-22 19:44:36 -06:00
bitcoin_logo_doxygen.png
build-freebsd.md Merge bitcoin/bitcoin#24646: doc: remove unneeded documentation on basic package management on FreeBSD 2024-01-01 17:48:18 -06:00
build-netbsd.md Merge bitcoin/bitcoin#25166: doc: Add link to NetBSD release 2024-01-14 11:05:37 -06:00
build-openbsd.md Merge #19605: doc: set CC_FOR_BUILD when building on OpenBSD 2024-01-19 10:34:33 -06:00
build-osx.md Merge #20890: doc: Add explicit macdeployqtplus dependencies install step 2024-01-16 07:57:34 -06:00
build-unix.md Merge #21064: refactor: use std::shared_mutex & remove Boost Thread 2024-01-16 09:29:52 -06:00
build-windows.md Merge #21342: doc: Remove outdated comment 2023-08-28 11:24:41 -05:00
dash-conf.md Merge bitcoin/bitcoin#22393: doc: added info to bitcoin.conf doc 2022-03-07 09:42:58 -06:00
dependencies.md Merge bitcoin/bitcoin#28561: build: Update qt package up to 5.15.10 2023-12-07 09:14:57 -06:00
descriptors.md Merge #18032: rpc: Output a descriptor in createmultisig and addmultisigaddress 2023-04-06 20:15:47 +03:00
developer-notes.md Merge bitcoin/bitcoin#24416: doc: Avoid ADL for function calls 2024-01-19 11:02:23 -06:00
dnsseed-policy.md
Doxyfile.in Merge bitcoin/bitcoin#22001: doc: Generate doxygen documentation for test sources 2022-03-13 14:52:10 -05:00
files.md merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
fuzzing.md Merge #20380: doc: Add instructions on how to fuzz the P2P layer using Honggfuzz NetDriver 2024-01-16 09:29:51 -06:00
guix.md Merge #20619: guix: Quality of life improvements 2023-03-26 16:50:26 -05:00
i2p.md docs: update tor and i2p docs (#5673) 2023-11-06 09:23:20 -06:00
init.md Merge #16556: Fix systemd service file configuration directory setup 2023-04-06 20:14:58 +03:00
instantsend.md
JSON-RPC-interface.md merge bitcoin#19762: Allow named and positional arguments to be used together 2023-07-28 00:18:27 -05:00
managing-wallets.md Merge bitcoin/bitcoin#22523: Document about wallet backup and restoration 2023-12-11 15:48:44 -06:00
masternode-budget.md
multiprocess.md Merge #18677: Multiprocess build support 2024-01-16 09:34:26 -06:00
productivity.md Merge #19058: doc: Drop protobuf stuff 2023-04-25 23:41:20 -05:00
psbt.md Merge #16047: doc: analyzepsbt description in doc/psbt.md 2023-02-10 23:34:57 +03:00
README_doxygen.md
README_windows.txt
README.md Merge bitcoin/bitcoin#22739: doc: link to managing-wallets from docs README 2023-12-11 15:48:44 -06:00
reduce-memory.md Merge bitcoin/bitcoin#21709: doc: update reduce-memory.md and bitcoin.conf -maxconnections info 2022-04-05 23:10:05 -05:00
reduce-traffic.md merge bitcoin#19191: Extract download permission from noban 2023-06-05 10:11:03 -05:00
release-notes-5342.md docs: add release notes for 5342 (#5568) 2023-09-09 12:26:36 -05:00
release-notes-5493.md docs: Added release notes for #5493 (#5556) 2023-09-07 12:06:28 -05:00
release-notes-5742.md feat(rpc): gettxchainlocks should return mempool=false when tx not in mempool (#5742) 2023-12-24 11:58:14 -06:00
release-notes-5765.md feat(rpc): submit chainlock signature if needed RPC (#5765) 2023-12-18 22:27:19 -06:00
release-notes-5774.md docs: archive v20.0.2 release notes and create v20.0.3 release notes 2023-12-24 12:04:42 -06:00
release-notes-5775.md chore: do not include dash-qt in the docker images (#5775) 2023-12-21 21:59:01 -06:00
release-notes-5776.md feat(rpc): Asset Unlock status by index (#5776) 2023-12-22 14:27:00 -06:00
release-notes-5839.md feat: new rpc getrawtransactionmulti (#5839) 2024-01-22 19:33:24 -06:00
release-notes-15367.md Merge #15367: feature: Added ability for users to add a startup command 2023-12-06 12:33:15 -06:00
release-notes-16525.md Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv 2023-12-06 12:33:15 -06:00
release-notes-18244.md Merge #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock manually selected coins 2024-01-22 19:44:36 -06:00
release-notes-18309.md Merge #18309: zmq: Add support to listen on multiple interfaces 2023-12-06 12:33:15 -06:00
release-notes-18982.md Merge #18982: wallet: Minimal fix to restore conflicted transaction notifications 2024-01-10 12:07:53 -06:00
release-notes-19725.md (Partial) Merge #19725: [RPC] Add connection type to getpeerinfo, improve logs 2024-01-09 08:15:36 -06:00
release-notes-22407.md Merge bitcoin/bitcoin#22407: rpc: Return block time in getblockchaininfo 2023-12-03 20:13:09 -06:00
release-notes-26896.md Merge bitcoin/bitcoin#26896: build: Remove port-forwarding runtime setting options from configure 2023-12-03 20:01:26 -06:00
release-notes-bitcoin-17219.md Merge bitcoin#19115: doc: Add release notes for 17219 2024-01-09 08:13:05 -06:00
release-notes.md docs: release notes for 20.0.4 and archiving old one 2024-01-12 00:48:31 +07:00
release-process.md feat: Set client version for non-release binaries and version in guix based on git tags (#5653) 2024-01-11 21:43:42 -06:00
REST-interface.md Merge #20944: rpc: Return total fee in getmempoolinfo 2024-01-16 09:29:49 -06:00
shared-libraries.md Merge #20577: doc: libconsensus: add missing error code description, fix NBitcoin link 2024-01-16 07:57:33 -06:00
tor.md docs: update tor and i2p docs (#5673) 2023-11-06 09:23:20 -06:00
translation_process.md
translation_strings_policy.md Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
zmq.md Merge #18309: zmq: Add support to listen on multiple interfaces 2023-12-06 12:33:15 -06:00

Dash Core

This is the official reference wallet for Dash digital currency and comprises the backbone of the Dash peer-to-peer network. You can download Dash Core or build it yourself using the guides below.

Running

The following are some helpful notes on how to run Dash Core on your native platform.

Unix

Unpack the files into a directory and run:

  • bin/dash-qt (GUI) or
  • bin/dashd (headless)

Windows

Unpack the files into a directory, and then run dash-qt.exe.

macOS

Drag Dash Core to your applications folder, and then run Dash Core.

Need Help?

Building

The following are developer notes on how to build Dash Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.

Development

The Dash Core repo's root README contains relevant information on the development process and automated testing.

Resources

Miscellaneous

License

Distributed under the MIT software license.