mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
9b9005e395
d1b622btests: Add check for test suite name uniqueness in lint-tests.sh (practicalswift)dc8067btests: Add note about uniqueness requirement for test suite names (practicalswift)3ebfb2dtests: Avoid test suite name collision in wallet crypto_tests (MarcoFalke) Pull request description: * Add documentation: Add note about test suite name uniqueness requirement in developer notes * Add regression test: Update `lint-tests.sh` to make it check also for test suite name uniqueness Context: #12894 (`tests: Avoid test suite name collision in wallet crypto_tests`) Tree-SHA512: 3c8502db069ef3d753f534976a86a997b12bac539e808a7285193bf81c9dd8c1b06821c3dd1bdf870ab87722b02c8aa9574c62ace70c2a1b8091785cb8c9aace
35 lines
1.1 KiB
Bash
Executable File
35 lines
1.1 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check the test suite naming conventions
|
|
|
|
EXIT_CODE=0
|
|
|
|
NAMING_INCONSISTENCIES=$(git grep -E '^BOOST_FIXTURE_TEST_SUITE\(' -- \
|
|
"src/test/**.cpp" "src/wallet/test/**.cpp" | \
|
|
grep -vE '/(.*?)\.cpp:BOOST_FIXTURE_TEST_SUITE\(\1, .*\)$')
|
|
if [[ ${NAMING_INCONSISTENCIES} != "" ]]; then
|
|
echo "The test suite in file src/test/foo_tests.cpp should be named"
|
|
echo "\"foo_tests\". Please make sure the following test suites follow"
|
|
echo "that convention:"
|
|
echo
|
|
echo "${NAMING_INCONSISTENCIES}"
|
|
EXIT_CODE=1
|
|
fi
|
|
|
|
TEST_SUITE_NAME_COLLISSIONS=$(git grep -E '^BOOST_FIXTURE_TEST_SUITE\(' -- \
|
|
"src/test/**.cpp" "src/wallet/test/**.cpp" | cut -f2 -d'(' | cut -f1 -d, | \
|
|
sort | uniq -d)
|
|
if [[ ${TEST_SUITE_NAME_COLLISSIONS} != "" ]]; then
|
|
echo "Test suite names must be unique. The following test suite names"
|
|
echo "appear to be used more than once:"
|
|
echo
|
|
echo "${TEST_SUITE_NAME_COLLISSIONS}"
|
|
EXIT_CODE=1
|
|
fi
|
|
|
|
exit ${EXIT_CODE}
|