mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
dd26a7a806
0d9fdd329e81cb171d687042290f4e6b1507d7f4 test, doc: refer to the correct variable names in p2p_invalid_tx.py (aitorjs)
Pull request description:
_tx_orphan_no_fee_ and _tx_orphan_invalid_ don't exist as transactions.
Have been replaced by _tx_orphan_2_no_fee_ and _tx_orphan_2_invalid_ respectively.
**Motivation**: Comments are more accurate and easy understandable under the tests context (I think).
ACKs for top commit:
kristapsk:
utACK 0d9fdd329e81cb171d687042290f4e6b1507d7f4
theStack:
ACK 0d9fdd329e81cb171d687042290f4e6b1507d7f4 📃
Tree-SHA512: a4cafd931e51fe2a67085e10e9c61178c864c14982664d112b76327e040af08cd1de04eca4a8ae980fad57ba7078017ce02fc60e7658f38380e8172c2ae28b77
211 lines
9.5 KiB
Python
Executable File
211 lines
9.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test node responses to invalid transactions.
|
|
|
|
In this test we connect to one node over p2p, and test tx requests."""
|
|
|
|
from test_framework.blocktools import create_block, create_coinbase
|
|
from test_framework.messages import (
|
|
COIN,
|
|
COutPoint,
|
|
CTransaction,
|
|
CTxIn,
|
|
CTxOut,
|
|
)
|
|
from test_framework.p2p import P2PDataStore
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
)
|
|
from data import invalid_txs
|
|
|
|
|
|
class InvalidTxRequestTest(BitcoinTestFramework):
|
|
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.extra_args = [[
|
|
"-acceptnonstdtxn=1",
|
|
"-maxorphantxsize=1",
|
|
]]
|
|
self.setup_clean_chain = True
|
|
|
|
def bootstrap_p2p(self, *, num_connections=1):
|
|
"""Add a P2P connection to the node.
|
|
|
|
Helper to connect and wait for version handshake."""
|
|
for _ in range(num_connections):
|
|
self.nodes[0].add_p2p_connection(P2PDataStore())
|
|
|
|
def reconnect_p2p(self, **kwargs):
|
|
"""Tear down and bootstrap the P2P connection to the node.
|
|
|
|
The node gets disconnected several times in this test. This helper
|
|
method reconnects the p2p and restarts the network thread."""
|
|
self.nodes[0].disconnect_p2ps()
|
|
self.bootstrap_p2p(**kwargs)
|
|
|
|
def run_test(self):
|
|
node = self.nodes[0] # convenience reference to the node
|
|
|
|
self.bootstrap_p2p() # Add one p2p connection to the node
|
|
|
|
best_block = self.nodes[0].getbestblockhash()
|
|
tip = int(best_block, 16)
|
|
best_block_time = self.nodes[0].getblock(best_block)['time']
|
|
block_time = best_block_time + 1
|
|
|
|
self.log.info("Create a new block with an anyone-can-spend coinbase.")
|
|
height = 1
|
|
block = create_block(tip, create_coinbase(height), block_time)
|
|
block.solve()
|
|
# Save the coinbase for later
|
|
block1 = block
|
|
tip = block.sha256
|
|
|
|
# Create a second one to test orphan resolution via block receival
|
|
height += 1
|
|
block_time += 1
|
|
block = create_block(tip, create_coinbase(height), block_time)
|
|
block.solve()
|
|
# Save the coinbase for later
|
|
block2 = block
|
|
tip = block.sha256
|
|
node.p2ps[0].send_blocks_and_test([block1, block2], node, success=True)
|
|
|
|
self.log.info("Mature the block.")
|
|
self.nodes[0].generatetoaddress(100, self.nodes[0].get_deterministic_priv_key().address)
|
|
|
|
# Iterate through a list of known invalid transaction types, ensuring each is
|
|
# rejected. Some are consensus invalid and some just violate policy.
|
|
for BadTxTemplate in invalid_txs.iter_all_templates():
|
|
self.log.info("Testing invalid transaction: %s", BadTxTemplate.__name__)
|
|
template = BadTxTemplate(spend_block=block1)
|
|
tx = template.get_tx()
|
|
node.p2ps[0].send_txs_and_test(
|
|
[tx], node, success=False,
|
|
expect_disconnect=template.expect_disconnect,
|
|
reject_reason=template.reject_reason,
|
|
)
|
|
|
|
if template.expect_disconnect:
|
|
self.log.info("Reconnecting to peer")
|
|
self.reconnect_p2p()
|
|
|
|
# Make two p2p connections to provide the node with orphans
|
|
# * p2ps[0] will send valid orphan txs (one with low fee)
|
|
# * p2ps[1] will send an invalid orphan tx (and is later disconnected for that)
|
|
self.reconnect_p2p(num_connections=2)
|
|
|
|
self.log.info('Test orphan transaction handling ... ')
|
|
self.test_orphan_tx_handling(block1.vtx[0].sha256, False)
|
|
|
|
self.log.info('Test orphan transaction handling, resolve via block')
|
|
self.restart_node(0, ["-acceptnonstdtxn=1", '-persistmempool=0', '-maxorphantxsize=1'])
|
|
|
|
self.reconnect_p2p(num_connections=2)
|
|
self.test_orphan_tx_handling(block2.vtx[0].sha256, True)
|
|
|
|
def test_orphan_tx_handling(self, base_tx, resolve_via_block):
|
|
node = self.nodes[0] # convenience reference to the node
|
|
|
|
# Create a root transaction that we withhold until all dependent transactions
|
|
# are sent out and in the orphan cache
|
|
SCRIPT_PUB_KEY_OP_TRUE = b'\x51\x75' * 15 + b'\x51'
|
|
tx_withhold = CTransaction()
|
|
tx_withhold.vin.append(CTxIn(outpoint=COutPoint(base_tx, 0)))
|
|
tx_withhold.vout.append(CTxOut(nValue=50 * COIN - 12000, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE))
|
|
tx_withhold.calc_sha256()
|
|
|
|
# Our first orphan tx with some outputs to create further orphan txs
|
|
tx_orphan_1 = CTransaction()
|
|
tx_orphan_1.vin.append(CTxIn(outpoint=COutPoint(tx_withhold.sha256, 0)))
|
|
tx_orphan_1.vout = [CTxOut(nValue=10 * COIN, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE)] * 3
|
|
tx_orphan_1.calc_sha256()
|
|
|
|
# A valid transaction with low fee
|
|
tx_orphan_2_no_fee = CTransaction()
|
|
tx_orphan_2_no_fee.vin.append(CTxIn(outpoint=COutPoint(tx_orphan_1.sha256, 0)))
|
|
tx_orphan_2_no_fee.vout.append(CTxOut(nValue=10 * COIN, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE))
|
|
|
|
# A valid transaction with sufficient fee
|
|
tx_orphan_2_valid = CTransaction()
|
|
tx_orphan_2_valid.vin.append(CTxIn(outpoint=COutPoint(tx_orphan_1.sha256, 1)))
|
|
tx_orphan_2_valid.vout.append(CTxOut(nValue=10 * COIN - 12000, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE))
|
|
tx_orphan_2_valid.calc_sha256()
|
|
|
|
# An invalid transaction with negative fee
|
|
tx_orphan_2_invalid = CTransaction()
|
|
tx_orphan_2_invalid.vin.append(CTxIn(outpoint=COutPoint(tx_orphan_1.sha256, 2)))
|
|
tx_orphan_2_invalid.vout.append(CTxOut(nValue=11 * COIN, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE))
|
|
tx_orphan_2_invalid.calc_sha256()
|
|
|
|
self.log.info('Send the orphans ... ')
|
|
# Send valid orphan txs from p2ps[0]
|
|
node.p2ps[0].send_txs_and_test([tx_orphan_1, tx_orphan_2_no_fee, tx_orphan_2_valid], node, success=False)
|
|
# Send invalid tx from p2ps[1]
|
|
node.p2ps[1].send_txs_and_test([tx_orphan_2_invalid], node, success=False)
|
|
|
|
assert_equal(0, node.getmempoolinfo()['size']) # Mempool should be empty
|
|
assert_equal(2, len(node.getpeerinfo())) # p2ps[1] is still connected
|
|
|
|
self.log.info('Send the withhold tx ... ')
|
|
if resolve_via_block:
|
|
# Test orphan handling/resolution by publishing the withhold TX via a mined block
|
|
prev_block = node.getblockheader(node.getbestblockhash())
|
|
block = create_block(int(prev_block['hash'], 16), create_coinbase(prev_block['height'] + 1), prev_block["time"] + 1)
|
|
block.vtx.append(tx_withhold)
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
block.solve()
|
|
node.p2ps[0].send_blocks_and_test([block], node, success=True)
|
|
else:
|
|
with node.assert_debug_log(expected_msgs=["bad-txns-in-belowout"]):
|
|
# Test orphan handling/resolution by publishing the withhold TX via the mempool
|
|
node.p2ps[0].send_txs_and_test([tx_withhold], node, success=True)
|
|
|
|
# Transactions that should end up in the mempool
|
|
expected_mempool = {
|
|
t.hash
|
|
for t in [
|
|
tx_withhold, # The transaction that is the root for all orphans
|
|
tx_orphan_1, # The orphan transaction that splits the coins
|
|
tx_orphan_2_valid, # The valid transaction (with sufficient fee)
|
|
]
|
|
}
|
|
# Transactions that do not end up in the mempool:
|
|
# tx_orphan_2_no_fee, because it has too low fee (p2ps[0] is not disconnected for relaying that tx)
|
|
# tx_orphan_2_invalid, because it has negative fee (p2ps[1] is disconnected for relaying that tx)
|
|
if resolve_via_block:
|
|
# This TX has appeared in a block instead of being broadcasted via the mempool
|
|
expected_mempool.remove(tx_withhold.hash)
|
|
|
|
self.wait_until(lambda: 1 == len(node.getpeerinfo()), timeout=12) # p2ps[1] is no longer connected
|
|
assert_equal(expected_mempool, set(node.getrawmempool()))
|
|
|
|
self.log.info('Test orphan pool overflow')
|
|
# this test is different with bitcoin due to dashpay/dash#3121
|
|
# we have a limit based on size in megabytes, not by amount of txes
|
|
# one tx is 91byte; 1Mb / 4451byte = 224; need to send at least 225
|
|
orphan_tx_pool = [CTransaction() for _ in range(225)]
|
|
for i in range(len(orphan_tx_pool)):
|
|
orphan_tx_pool[i].vin.append(CTxIn(outpoint=COutPoint(i, 333)))
|
|
for j in range(110):
|
|
orphan_tx_pool[i].vout.append(CTxOut(nValue=COIN // 10, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE))
|
|
|
|
with node.assert_debug_log(['mapOrphan overflow, removed 1 tx']):
|
|
node.p2ps[0].send_txs_and_test(orphan_tx_pool, node, success=False)
|
|
|
|
rejected_parent = CTransaction()
|
|
rejected_parent.vin.append(CTxIn(outpoint=COutPoint(tx_orphan_2_invalid.sha256, 0)))
|
|
rejected_parent.vout.append(CTxOut(nValue=11 * COIN, scriptPubKey=SCRIPT_PUB_KEY_OP_TRUE))
|
|
rejected_parent.rehash()
|
|
# TODO: somehow it fails on `block` stage without 'not keeping orphan'
|
|
#with node.assert_debug_log(['not keeping orphan with rejected parents {}'.format(rejected_parent.hash)]):
|
|
node.p2ps[0].send_txs_and_test([rejected_parent], node, success=False)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
InvalidTxRequestTest().main()
|