mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
42dcb3ddca
## Issue being fixed or feature implemented Current implementation of MnEhfTx is not matched with DIP-0023, this PR fixes it. It is a prior work for https://github.com/dashpay/dash/pull/5469 ## What was done? - requestID is fixed from `clsig{quorumHeight}` to `mnhf{versionBit}` + fixes for signature validation properly - v20 is minimal height to accept MnEHF special transactions - versionBit is not BLS version - removed unrelated wrong code and validations - TxMempool will accept MnEHF transaction even if inputs/outputs are zeroes and no fee - implemented python's serialization/deserialization of MnEHF transactions for future using in functional tests ## How Has This Been Tested? Run functional/unit tests. Beside that there's new functional test in https://github.com/dashpay/dash/pull/5469 that actually test format of transaction and signature validation - to be merged later. ## Breaking Changes Payload of MnEhf tx is changed, related consensus rules are changed. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone |
||
---|---|---|
.. | ||
__init__.py | ||
address.py | ||
authproxy.py | ||
blocktools.py | ||
coverage.py | ||
descriptors.py | ||
key.py | ||
messages.py | ||
mininode.py | ||
muhash.py | ||
netutil.py | ||
ripemd160.py | ||
script_util.py | ||
script.py | ||
siphash.py | ||
socks5.py | ||
test_framework.py | ||
test_node.py | ||
test_shell.py | ||
util.py | ||
wallet_util.py |