dash/test/functional
pasta 7aa8f54c0f
Merge #5976: backport: bitcoin#17934, #21338, #21390, #21445, #21602, #21606, #21609, #21676, bitcoin-core/gui#260,
21ad71c578 Merge #21676: test: Use mocktime to avoid intermittent failure in rpc_tests (MarcoFalke)
76a41eb245 Merge #21602: rpc: add additional ban time fields to listbanned (MarcoFalke)
adea52a5fe Merge bitcoin-core/gui#260: Handle exceptions instead of crash (W. J. van der Laan)
7e023c394f Merge #17934: doc: Use CONFIG_SITE variable instead of --prefix option (fanquake)
bc6e3ed6e4 Merge #21606: fuzz: Extend psbt fuzz target a bit (MarcoFalke)
233fb245f7 Merge #21445: cirrus: Use SSD cluster for speedup (fanquake)
a224b800e4 Merge #21609: ci: increase CPU count of sanitizer job to increase memory limit (MarcoFalke)
ad947099a0 test: remove exception for util::Ref which doesn't exist more (Konstantin Akimov)
6674ee85ab Merge #21390: test: Test improvements for UTXO set hash tests (MarcoFalke)
e10eec249b Merge #21338: test: add functional test for anchors.dat (MarcoFalke)
d9c31d6817 Merge #21411: test: add logging, reduce blocks, move sync_all in wallet_ groups (MarcoFalke)

Pull request description:

  ## Issue being fixed or feature implemented
  Regular backports from bitcoin v22

  ## Note for reviewers:
  PRs bitcoin#17934 and bitcoin#21606 have been backported partially in past.

  ## What was done?
  Removed unused sanitizer rules (see bitcoin#21366 and dashpay/dash#5055)
   - bitcoin/bitcoin#21338
   - bitcoin/bitcoin#21390
   - bitcoin/bitcoin#21609
   - bitcoin/bitcoin#21445
   - bitcoin/bitcoin#21606
   - bitcoin/bitcoin#17934
   - bitcoin-core/gui#260
   - bitcoin/bitcoin#21602
   - bitcoin/bitcoin#21676

  ## How Has This Been Tested?
  Run unit/functional tests

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  PastaPastaPasta:
    utACK 21ad71c578

Tree-SHA512: 94276d56255300d7d8c056d15b468720ba028d83cc585b16396e8bad90157e9e010490be239e09cccd4362f575f8df2d56dde3fb505745376c7790d70e3635cd
2024-04-12 10:30:27 -05:00
..
data Merge #16551: test: Test that low difficulty chain fork is rejected 2024-04-03 14:16:43 +07:00
test_framework Merge #5976: backport: bitcoin#17934, #21338, #21390, #21445, #21602, #21606, #21609, #21676, bitcoin-core/gui#260, 2024-04-12 10:30:27 -05:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_abortnode.py Merge #19752: test: Update wait_until usage in tests not to use the one from utils 2024-01-20 00:07:11 +07:00
feature_addressindex.py
feature_anchors.py Merge #21338: test: add functional test for anchors.dat 2024-04-11 02:26:01 +07:00
feature_asmap.py
feature_asset_locks.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_assumevalid.py Merge #19752: test: Update wait_until usage in tests not to use the one from utils 2024-01-20 00:07:11 +07:00
feature_backwards_compatibility.py Merge #18788: tests: Update more tests to work with descriptor wallets 2024-03-09 03:01:24 +07:00
feature_bip68_sequence.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_block.py merge bitcoin#20167: Add test for -blockversion 2024-02-06 08:44:05 -06:00
feature_blockfilterindex_prune.py Merge #19752: test: Update wait_until usage in tests not to use the one from utils 2024-01-20 00:07:11 +07:00
feature_blocksdir.py
feature_cltv.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_coinstatsindex.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_config_args.py merge bitcoin#21254: Avoid connecting to real network when running tests 2024-03-25 11:55:07 +00:00
feature_csv_activation.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_dbcrash.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_dersig.py Merge #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property 2024-01-27 22:55:29 -06:00
feature_dip3_deterministicmns.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_dip3_v19.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_dip4_coinbasemerkleroots.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_dip0020_activation.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_fee_estimation.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_filelock.py fix: skip functional tests which requires BDB if no bdb (see 20267) 2024-03-07 01:23:23 +07:00
feature_governance_objects.py
feature_governance.py Merge #19816: test: Rename wait until helper to wait_until_helper 2024-03-06 02:00:39 +07:00
feature_help.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_includeconf.py
feature_llmq_chainlocks.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_llmq_connections.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_llmq_data_recovery.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_llmq_dkgerrors.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_llmq_evo.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_llmq_is_cl_conflicts.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_llmq_is_retroactive.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_llmq_rotation.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_llmq_signing.py Merge #19816: test: Rename wait until helper to wait_until_helper 2024-03-06 02:00:39 +07:00
feature_llmq_simplepose.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_loadblock.py
feature_logging.py
feature_maxuploadtarget.py partial Merge #18638: net: Use mockable time for ping/pong, add tests 2024-03-06 02:00:30 +07:00
feature_minchainwork.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_mnehf.py Merge #19674: refactor: test: use throwaway _ variable for unused loop counters 2024-01-20 00:07:09 +07:00
feature_multikeysporks.py Merge #19816: test: Rename wait until helper to wait_until_helper 2024-03-06 02:00:39 +07:00
feature_new_quorum_type_activation.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
feature_notifications.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_nulldummy.py Merge #18788: tests: Update more tests to work with descriptor wallets 2024-03-09 03:01:24 +07:00
feature_proxy.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_pruning.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
feature_reindex.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_settings.py
feature_shutdown.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_spentindex.py
feature_sporks.py Merge #19816: test: Rename wait until helper to wait_until_helper 2024-03-06 02:00:39 +07:00
feature_timestampindex.py
feature_txindex.py
feature_uacomment.py
feature_utxo_set_hash.py Merge #21390: test: Test improvements for UTXO set hash tests 2024-04-11 02:26:01 +07:00
feature_versionbits_warning.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
interface_bitcoin_cli.py Merge bitcoin/bitcoin#21056: rpc: Add a -rpcwaittimeout parameter to limit time spent waiting 2024-03-22 10:29:15 -05:00
interface_http.py
interface_rest.py Merge bitcoin/bitcoin#25121: test: compare /mempool/info response with getmempoolinfo RPC 2024-01-14 11:05:36 -06:00
interface_rpc.py
interface_zmq_dash.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
interface_zmq.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
mempool_accept.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
mempool_compatibility.py Merge #20688: test: run mempool_compatibility.py even with wallet disabled 2024-01-26 12:50:30 -06:00
mempool_expiry.py Merge #20276: test: run mempool_expiry.py even with wallet disabled 2024-01-26 12:50:31 -06:00
mempool_limit.py
mempool_package_onemore.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
mempool_packages.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
mempool_persist.py Merge #19752: test: Update wait_until usage in tests not to use the one from utils 2024-01-20 00:07:11 +07:00
mempool_reorg.py
mempool_resurrect.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
mempool_spend_coinbase.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
mempool_unbroadcast.py Merge #19760: test: Remove confusing mininode terminology 2024-01-20 00:07:10 +07:00
mempool_updatefromblock.py Merge #19674: refactor: test: use throwaway _ variable for unused loop counters 2024-01-20 00:07:09 +07:00
mining_basic.py Merge #16551: test: Test that low difficulty chain fork is rejected 2024-04-03 14:16:43 +07:00
mining_getblocktemplate_longpoll.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
mining_prioritisetransaction.py
p2p_add_connections.py merge bitcoin#19315: Allow outbound & block-relay-only connections in functional tests 2024-04-03 16:06:40 +00:00
p2p_addr_relay.py merge bitcoin#21785: Fix intermittent issue in p2p_addr_relay.py 2024-04-03 16:10:16 +00:00
p2p_addrv2_relay.py Merge #19752: test: Update wait_until usage in tests not to use the one from utils 2024-01-20 00:07:11 +07:00
p2p_blockfilters.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_blocksonly.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_compactblocks.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_connect_to_devnet.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
p2p_disconnect_ban.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_dos_header_tree.py Merge #16551: test: Test that low difficulty chain fork is rejected 2024-04-03 14:16:43 +07:00
p2p_eviction.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_filter.py merge bitcoin#21785: Fix intermittent issue in p2p_addr_relay.py 2024-04-03 16:10:16 +00:00
p2p_fingerprint.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_getaddr_caching.py Merge bitcoin/bitcoin#25312: test: Fix port collisions caused by p2p_getaddr_caching.py 2024-02-22 20:58:44 -06:00
p2p_getdata.py Merge #20022: test: use explicit p2p objects where available 2024-01-27 22:55:29 -06:00
p2p_i2p_ports.py
p2p_instantsend.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
p2p_invalid_block.py Merge #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property 2024-01-27 22:55:29 -06:00
p2p_invalid_locator.py Merge #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property 2024-01-27 22:55:29 -06:00
p2p_invalid_messages.py Merge #20028: test: Check that invalid peer traffic is accounted for 2024-02-14 14:57:34 -06:00
p2p_invalid_tx.py Merge #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property 2024-01-27 22:55:29 -06:00
p2p_leak_tx.py Merge #20126: test: p2p_leak_tx.py improvements (use MiniWallet, add p2p_lock acquires) 2024-01-26 12:50:31 -06:00
p2p_leak.py Merge #19512: p2p: banscore updates to gui, tests, release notes 2024-03-22 11:08:11 -05:00
p2p_message_capture.py Merge bitcoin/bitcoin#25117: test: Check msg type in msg capture is followed by zeros 2024-02-14 10:34:11 -06:00
p2p_nobloomfilter_messages.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_node_network_limited.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_permissions.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
p2p_ping.py Merge #19489: test: Fail wait_until early if connection is lost 2024-03-06 02:00:37 +07:00
p2p_quorum_data.py Merge #20993: test: store subversion (user agent) as string in msg_version 2024-04-11 02:25:08 +07:00
p2p_sendheaders_compressed.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
p2p_sendheaders.py Merge #19752: test: Update wait_until usage in tests not to use the one from utils 2024-01-20 00:07:11 +07:00
p2p_timeouts.py merge bitcoin#20724: Cleanup of -debug=net log messages 2024-03-25 11:55:05 +00:00
p2p_tx_download.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
p2p_unrequested_blocks.py Merge #19760: test: Remove confusing mininode terminology 2024-01-20 00:07:10 +07:00
README.md Merge #20691: ci, doc: Travis CI features and mentions cleanup 2024-03-27 00:48:26 +07:00
rpc_bind.py
rpc_blockchain.py Merge #18772: rpc: calculate fees in getblock using BlockUndo data 2024-04-09 22:34:38 +07:00
rpc_coinjoin.py
rpc_createmultisig.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_decodescript.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
rpc_deprecated.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_deriveaddresses.py
rpc_dumptxoutset.py
rpc_estimatefee.py
rpc_fundrawtransaction.py Merge #18788: tests: Update more tests to work with descriptor wallets 2024-03-09 03:01:24 +07:00
rpc_generate.py Merge #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) 2024-03-17 13:02:58 -05:00
rpc_generateblock.py Merge #19674: refactor: test: use throwaway _ variable for unused loop counters 2024-01-20 00:07:09 +07:00
rpc_getblockfilter.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_getblockstats.py
rpc_getchaintips.py
rpc_getdescriptorinfo.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_getpeerinfo_banscore_deprecation.py Merge #19469: rpc: deprecate banscore field in getpeerinfo 2024-03-22 11:08:10 -05:00
rpc_help.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_invalid_address_message.py Merge #20832: rpc: Better error messages for invalid addresses 2024-02-01 11:09:04 -06:00
rpc_invalidateblock.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_masternode.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
rpc_misc.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_mnauth.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
rpc_named_arguments.py
rpc_net.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_packages.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
rpc_platform_filter.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
rpc_preciousblock.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_psbt.py merge bitcoin#16378: The ultimate send RPC 2024-03-07 09:29:09 +00:00
rpc_quorum.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
rpc_rawtransaction.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_scantxoutset.py
rpc_setban.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_signmessage.py
rpc_signrawtransaction.py
rpc_txoutproof.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_uptime.py
rpc_users.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_verifychainlock.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
rpc_verifyislock.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
rpc_whitelist.py
rpc_wipewallettxes.py
test_runner.py Merge #21338: test: add functional test for anchors.dat 2024-04-11 02:26:01 +07:00
test-shell.md
tool_wallet.py feat: add option -usehd to wallettool to let create non-hd wallets 2024-04-10 01:59:00 +07:00
wallet_abandonconflict.py
wallet_avoidreuse.py Merge #16528: Native Descriptor Wallets using DescriptorScriptPubKeyMan 2024-03-07 01:23:15 +07:00
wallet_backup.py Merge #19077: wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets 2024-03-07 01:23:21 +07:00
wallet_balance.py Merge #18788: tests: Update more tests to work with descriptor wallets 2024-03-09 03:01:24 +07:00
wallet_basic.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_change_address.py partial Merge bitcoin/bitcoin#27053: wallet: reuse change dest when re-creating TX with avoidpartialspends 2024-03-18 16:30:45 +07:00
wallet_coinbase_category.py Merge bitcoin/bitcoin#25589: test: speedup wallet_coinbase_category.py 2024-02-27 10:02:44 -06:00
wallet_create_tx.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_createwallet.py Merge #18788: tests: Update more tests to work with descriptor wallets 2024-03-09 03:01:24 +07:00
wallet_descriptor.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_disable.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_dump.py Merge #19674: refactor: test: use throwaway _ variable for unused loop counters 2024-01-20 00:07:09 +07:00
wallet_encryption.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_fallbackfee.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_groups.py Merge #21411: test: add logging, reduce blocks, move sync_all in wallet_ groups 2024-04-11 02:26:01 +07:00
wallet_hd.py Merge #16528: Native Descriptor Wallets using DescriptorScriptPubKeyMan 2024-03-07 01:23:15 +07:00
wallet_import_rescan.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_import_with_label.py
wallet_importdescriptors.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_importmulti.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_importprunedfunds.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_keypool_hd.py Merge bitcoin/bitcoin#29510: wallet: getrawchangeaddress and getnewaddress failures should not affect keypools for descriptor wallets 2024-03-07 01:23:24 +07:00
wallet_keypool_topup.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_keypool.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_labels.py Merge #18788: tests: Update more tests to work with descriptor wallets 2024-03-09 03:01:24 +07:00
wallet_listdescriptors.py Merge bitcoin/bitcoin#22446: test: Fix wallet_listdescriptors.py if bdb is not compiled 2024-03-09 03:01:27 +07:00
wallet_listreceivedby.py
wallet_listsinceblock.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_listtransactions.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_mnemonicbits.py
wallet_multiwallet.py Merge #20540: test: Fix wallet_multiwallet issue on windows 2024-03-22 11:20:57 -05:00
wallet_orphanedreward.py
wallet_reorgsrestore.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_resendwallettransactions.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
wallet_send.py merge bitcoin#19969: Send RPC bug fix and touch-ups 2024-03-07 09:29:09 +00:00
wallet_startup.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_txn_clone.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_txn_doublespend.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_upgradetohd.py partial Merge bitcoin/bitcoin#27053: wallet: reuse change dest when re-creating TX with avoidpartialspends 2024-03-18 16:30:45 +07:00
wallet_upgradewallet.py Merge #20282: wallet: change upgradewallet return type to be an object 2024-03-07 02:06:28 +07:00
wallet_watchonly.py

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x500=12500 DASH) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the dashd(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a dashd. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a dashd node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: