sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-28 05:23:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
7b0ff6ce10
dash/src
History
fanquake 7b0ff6ce10 Merge #17857: scripts: fix symbol-check & security-check argument passing 
71af793512100ee7d508c3fb815af47925fe80ba scripts: fix check-symbols & check-security argument passing (fanquake)

Pull request description:

  The first argument in `bin_PROGRAMS` (`bitcoind`) was being silently consumed and never passed into the [`security-check.py`](https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/security-check.py) or [`symbol-check.py`](https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/symbol-check.py) scripts.

  This seems to have been the case since the scripts were added to the makefile in f3d3eaf78e.

  Example of the behavior:

  ```python
  # touch a, touch b, touch c
  # python3 args.py < a b c

  import sys
  if __name__ == '__main__':
      print(sys.argv)
      # ['args.py', 'b', 'c']

      # if you add some lines to "a",
      # you'll see them here..
      for line in sys.stdin:
          print(line)
  ```

ACKs for top commit:
  laanwj:
    ACK 71af793512100ee7d508c3fb815af47925fe80ba

Tree-SHA512: 9d0b975a11f66fd87a76654d210808000a629c9cce4c760f71e8a2bcb4e99b9109419f2306db67cf9b12c28e40b96ae722b7c9b4569b2b8bacd469fb99db30c3
2022-06-17 04:06:49 +07:00
..
bench Merge #17511: Add bounds checks before base58 decoding 2022-06-08 12:33:00 +07:00
bls chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
coinjoin tests: basic functional tests for CoinJoin (#4730) 2022-06-10 23:05:48 -05:00
compat merge bitcoin#17270: Feed environment data into RNG initializers 2022-04-25 15:29:51 +05:30
config
consensus refactor: add superblock trigger maturity window to DashCore (#4865) 2022-06-08 00:10:05 +03:00
crc32c Merge bitcoin/bitcoin#23133: Update crc32c subtree 2022-03-13 14:52:24 -05:00
crypto Merge bitcoin/bitcoin#23761: build: use __SIZEOF_INT128__ for checking __int128 availability 2022-04-28 10:59:05 -05:00
evo chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
governance fix(gov): do not allow empty proposal names (#4883) 2022-06-14 12:04:56 +03:00
index Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
interfaces Merge #13756: wallet: "avoid_reuse" wallet flag for improved privacy 2022-06-17 04:06:49 +07:00
leveldb
llmq docs(llmq): Improved documentation for keepOldConnections (#4876) 2022-06-10 23:26:02 -05:00
logging
masternode chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
node merge bitcoin#18571: Disable debug log file 2022-06-03 18:25:38 +05:30
policy Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
primitives Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
qt Merge #15886: qt, wallet: Revamp SendConfirmationDialog 2022-06-17 04:06:49 +07:00
rpc Merge #13756: wallet: "avoid_reuse" wallet flag for improved privacy 2022-06-17 04:06:49 +07:00
script Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
secp256k1
support chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
test Merge #17750: util: change GetWarnings parameter to bool 2022-06-14 16:48:15 +07:00
univalue merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
util chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
wallet Merge #13756: wallet: "avoid_reuse" wallet flag for improved privacy 2022-06-17 04:06:49 +07:00
zmq refactor(rpc): Mechanical/Manual RPC backports (#4734) 2022-05-12 15:29:17 -05:00
.clang-format Merge #17134: doc: Add switch on enum example to developer notes 2022-04-02 09:19:20 +05:30
addrdb.cpp
addrdb.h Merge #17297: refactor: Remove addrdb.h dependency from node.h 2022-03-07 09:36:17 -06:00
addressindex.h
addrman.cpp merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
addrman.h Merge bitcoin/bitcoin#22455: addrman: detect on-disk corrupted nNew and nTried during unserialization 2022-03-07 09:42:58 -06:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp merge bitcoin#16362: Add bilingual_str type 2022-04-06 00:08:01 +05:30
banman.h merge bitcoin#16839: Replace Connman and BanMan globals with NodeContext local 2022-04-20 00:22:35 +05:30
base58.cpp Merge #17511: Add bounds checks before base58 decoding 2022-06-08 12:33:00 +07:00
base58.h Merge #17511: Add bounds checks before base58 decoding 2022-06-08 12:33:00 +07:00
batchedlogger.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
batchedlogger.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp
bip39.h
blockencodings.cpp Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp
bloom.h
cachemap.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
cachemultimap.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
chain.cpp
chain.h
chainparams.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
chainparams.h Merge #17285: doc: Bip70 removal follow-up 2022-04-27 21:08:36 +03:00
chainparamsbase.cpp merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
chainparamsbase.h merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
chainparamsseeds.h
checkqueue.h Merge bitcoin/bitcoin#23397: Avoid excessive lock contention in CCheckQueue::Add 2022-04-11 09:41:11 -07:00
clientversion.cpp Merge bitcoin/bitcoin#22685: clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE 2022-05-11 11:03:39 -05:00
clientversion.h Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
coins.cpp Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
coins.h merge bitcoin#18637: allow cache resize after init 2022-05-23 10:39:43 +05:30
compat.h
compressor.cpp
compressor.h Merge #17917: tests: Add amount compression/decompression fuzzing to existing fuzzing harness 2022-03-07 09:40:31 -06:00
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
ctpl_stl.h
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-cli.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
dash-tx-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-tx.cpp merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
dash-wallet-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dash-wallet.cpp merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
dashd-res.rc Merge #20223: build: Drop the leading 0 from the version number 2022-04-28 13:47:53 +03:00
dashd.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
dbwrapper.cpp
dbwrapper.h Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
dsnotificationinterface.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
dsnotificationinterface.h Pass CConnman to function in place for global pointer access 2022-04-20 00:21:04 +05:30
dummywallet.cpp merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
flat-database.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
flatfile.cpp
flatfile.h
fs.cpp Merge pull request #4735 from kittywhiskers/translation 2022-04-07 13:18:29 +03:00
fs.h
hash.cpp merge bitcoin#19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 2022-04-27 19:58:39 +05:30
hash.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
hdchain.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
hdchain.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
httprpc.cpp Merge #12763: Add RPC Whitelist Feature from #12248 2022-06-08 12:36:51 +07:00
httprpc.h merge bitcoin#18740: Remove g_rpc_node global 2022-05-18 20:50:50 +05:30
httpserver.cpp Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
httpserver.h
indirectmap.h merge bitcoin#17996: Add fuzzing harness for serialization/deserialization of floating-points and integrals 2022-03-25 00:58:20 +05:30
init.cpp Merge #12763: Add RPC Whitelist Feature from #12248 2022-06-08 12:36:51 +07:00
init.h merge bitcoin#19779: Remove gArgs global from init 2022-06-07 09:21:29 +05:30
key_io.cpp Merge #17511: Add bounds checks before base58 decoding 2022-06-08 12:33:00 +07:00
key_io.h
key.cpp Merge bitcoin/bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization 2022-03-13 14:52:53 -05:00
key.h Merge bitcoin/bitcoin#22995: doc: Remove stale comment for CPrivKey 2022-03-13 14:52:24 -05:00
keystore.cpp
keystore.h
limitedmap.h
logging.cpp
logging.h merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
Makefile.am Merge #17857: scripts: fix symbol-check & security-check argument passing 2022-06-17 04:06:49 +07:00
Makefile.bench.include Merge #14212: build: Remove libssl from LDADD unless gui 2022-05-23 02:15:41 -04:00
Makefile.crc32c.include
Makefile.leveldb.include Merge bitcoin/bitcoin#23282: build: remove build stubs for external leveldb 2022-04-03 18:46:47 -05:00
Makefile.qt_locale.include
Makefile.qt.include partial bitcoin#21694: Use XLIFF file to provide more context to Transifex translators 2022-04-26 20:36:54 +05:30
Makefile.qttest.include merge bitcoin#17265: Remove OpenSSL 2022-04-25 15:29:52 +05:30
Makefile.test_util.include
Makefile.test.include merge bitcoin#15934: Merge settings one place instead of five places 2022-06-03 18:25:21 +05:30
Makefile.univalue.include merge bitcoin#22646: tighter Univalue integration, remove --with-system-univalue (#4823) 2022-05-02 10:31:46 -05:00
mapport.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
mapport.h
memusage.h merge bitcoin#17996: Add fuzzing harness for serialization/deserialization of floating-points and integrals 2022-03-25 00:58:20 +05:30
merkleblock.cpp
merkleblock.h
messagesigner.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
messagesigner.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
miner.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
miner.h merge bitcoin#17781: Remove mempool global from miner 2022-04-20 00:25:14 +05:30
net_permissions.cpp Merge bitcoin/bitcoin#21996: p2p: pass strings to NetPermissions::TryParse functions by const ref 2022-04-16 10:47:42 -06:00
net_permissions.h Merge bitcoin/bitcoin#21996: p2p: pass strings to NetPermissions::TryParse functions by const ref 2022-04-16 10:47:42 -06:00
net_processing.cpp dashification: Introduce ADDRV2_PROTO_VERSION and bump PROTOCOL_VERSION to avoid conflicts with previous v18.x rcs 2022-06-08 02:53:55 +03:00
net_processing.h merge bitcoin#18698: Make g_chainman internal to validation 2022-05-18 20:53:41 +05:30
net_types.h Merge #17297: refactor: Remove addrdb.h dependency from node.h 2022-03-07 09:36:17 -06:00
net.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
net.h Merge #20661: Only select from addrv2-capable peers for torv3 address relay 2022-06-08 02:41:31 +03:00
netaddress.cpp merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
netaddress.h merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
netbase.cpp
netbase.h
netfulfilledman.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
netfulfilledman.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
netmessagemaker.h
noui.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
noui.h Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
optional.h
pow.cpp
pow.h
prevector.h
protocol.cpp feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
protocol.h feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
psbt.cpp
psbt.h Merge #17349: Remove redundant copy constructors 2022-05-31 12:06:32 -04:00
pubkey.cpp Merge bitcoin/bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization 2022-03-13 14:52:53 -05:00
pubkey.h
random.cpp Merge #17699: Make env data logging optional 2022-05-30 19:09:39 +07:00
random.h Merge #17670: Move events_hasher into RNGState() 2022-05-30 19:09:39 +07:00
randomenv.cpp Merge #20358: src/randomenv.cpp: fix build on uclibc 2022-04-25 14:02:48 -05:00
randomenv.h merge bitcoin#17270: Feed environment data into RNG initializers 2022-04-25 15:29:51 +05:30
rest.cpp merge bitcoin#19589: Avoid useless mempool query in gettxoutproof 2022-05-23 10:40:35 +05:30
reverse_iterator.h
saltedhasher.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
saltedhasher.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
scheduler.cpp merge bitcoin#17270: Feed environment data into RNG initializers 2022-04-25 15:29:51 +05:30
scheduler.h merge bitcoin#18037: Allow scheduler to be mocked 2022-04-20 00:23:32 +05:30
serialize.h Merge #13558: Drop unused GetType() from CSizeComputer 2022-05-30 01:11:03 -04:00
shutdown.cpp
shutdown.h
span.h Merge #19367: doc: Span pitfalls 2022-04-03 18:09:07 -05:00
spentindex.h
spork.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
spork.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
stacktraces.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
stacktraces.h
statsd_client.cpp
statsd_client.h
streams.h
sync.cpp merge bitcoin#17279: Remove redundant c_str() calls in formatting 2022-04-06 13:51:39 +05:30
sync.h Merge #16034: refactoring: Rename LockAnnotation to LockAssertion and add run-time check to it 2022-05-17 12:57:47 -04:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h Merge #16034: refactoring: Rename LockAnnotation to LockAssertion and add run-time check to it 2022-05-17 12:57:47 -04:00
timedata.cpp Merge #16224: gui: Bilingual GUI error messages 2022-04-07 10:41:24 -05:00
timedata.h
tinyformat.h
torcontrol.cpp
torcontrol.h
txdb.cpp merge bitcoin#18637: allow cache resize after init 2022-05-23 10:39:43 +05:30
txdb.h merge bitcoin#18637: allow cache resize after init 2022-05-23 10:39:43 +05:30
txmempool.cpp merge bitcoin#14193: Add missing mempool locks 2022-05-18 20:49:34 +05:30
txmempool.h merge bitcoin#14193: Add missing mempool locks 2022-05-18 20:49:34 +05:30
ui_interface.cpp merge bitcoin#16963: Fix unique_ptr usage in boost::signals2 2022-05-13 18:06:06 +05:30
ui_interface.h merge bitcoin#16963: Fix unique_ptr usage in boost::signals2 2022-05-13 18:06:06 +05:30
uint256.cpp
uint256.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
undo.h
unordered_lru_cache.h
validation.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
validation.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
validationinterface.cpp merge bitcoin#18338: Fix wallet unload race condition 2022-06-03 18:25:34 +05:30
validationinterface.h merge bitcoin#18338: Fix wallet unload race condition 2022-06-03 18:25:34 +05:30
version.h Merge pull request #4874 from UdjinM6/addrv2_followups 2022-06-08 13:01:44 +03:00
versionbits.cpp
versionbits.h
versionbitsinfo.cpp feat: implement quorum rotation and updated LLMQ parameters (#4752) 2022-04-16 17:46:04 +03:00
versionbitsinfo.h
walletinitinterface.h merge bitcoin#19561: Pass ArgsManager into functions that register args 2022-06-07 09:21:29 +05:30
warnings.cpp Merge #17750: util: change GetWarnings parameter to bool 2022-06-14 16:48:15 +07:00
warnings.h Merge #17750: util: change GetWarnings parameter to bool 2022-06-14 16:48:15 +07:00