mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
7be2b2456a
fa3c910bfeab00703c947c5200a64c21225b50ef test: Move linters to test/lint, add readme (MarcoFalke) Pull request description: This moves the checks and linters from `devtools` to a subfolder in `test`. (Motivated by my opinion that the dev tools are mostly for generating code and updating the repo whereas the linters are read-only checks.) Also, adds a readme to clarify that checks and linters are only meant to prevent bugs and user facing issues, not merely stylistic preference or inconsistencies. (This is motivated by the diversity in developers and work flows as well as existing code styles. It would be too disruptive to change all existing code to a single style or too burdensome to force all developers to adhere to a single style. Also note that our style guide is changing, so locking in at the wrong style "too early" would only waste resources.) Tree-SHA512: 9b10e89f2aeaf0c8a9ae248aa891d74e0abf0569f8e5dfd266446efa8bfaf19f0ea0980abf0b0b22f0d8416ee90d7435d21a9f9285b66df43f370b7979173406
28 lines
825 B
Bash
Executable File
28 lines
825 B
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check that all logs are terminated with '\n'
|
|
#
|
|
# Some logs are continued over multiple lines. They should be explicitly
|
|
# commented with /* Continued */
|
|
#
|
|
# There are some instances of LogPrintf() in comments. Those can be
|
|
# ignored
|
|
|
|
export LC_ALL=C
|
|
|
|
UNTERMINATED_LOGS=$(git grep --extended-regexp "LogPrintf?\(" -- "*.cpp" | \
|
|
grep -v '\\n"' | \
|
|
grep -v "/\* Continued \*/" | \
|
|
grep -v "LogPrint()" | \
|
|
grep -v "LogPrintf()")
|
|
if [[ ${UNTERMINATED_LOGS} != "" ]]; then
|
|
echo "All calls to LogPrintf() and LogPrint() should be terminated with \\n"
|
|
echo
|
|
echo "${UNTERMINATED_LOGS}"
|
|
exit 1
|
|
fi
|