mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
ffe950bbc7
1ac454a3844b9b8389de0f660fa9455c0efa7140 Enable ShellCheck rules (Hennadii Stepanov) Pull request description: Enable some simple ShellCheck rules. Note for reviewers: `bash` and `shellcheck` on macOS are different from ones on Ubuntu. For local tests the latest `shellcheck` version 0.6.0 should be used (see #15166). ACKs for top commit: practicalswift: utACK 1ac454a3844b9b8389de0f660fa9455c0efa7140 dongcarl: utACK 1ac454a fanquake: ACK 1ac454a3844b9b8389de0f660fa9455c0efa7140 Tree-SHA512: 8d0a3a5c09fe1a0c22120178f5e6b80f81f746f8c3356b7701ff301c117acb2edea8fe08f08fb54ed73f94b1617515fb239fa28e7ab4121f74872e6494b6f20e
29 lines
865 B
Bash
Executable File
29 lines
865 B
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check that all logs are terminated with '\n'
|
|
#
|
|
# Some logs are continued over multiple lines. They should be explicitly
|
|
# commented with /* Continued */
|
|
#
|
|
# There are some instances of LogPrintf() in comments. Those can be
|
|
# ignored
|
|
|
|
export LC_ALL=C
|
|
|
|
UNTERMINATED_LOGS=$(git grep --extended-regexp "LogPrintf?\(" -- "*.cpp" | \
|
|
grep -v '\\n"' | \
|
|
grep -v "/\* Continued \*/" | \
|
|
grep -v "LogPrint()" | \
|
|
grep -v "LogPrintf()")
|
|
if [[ ${UNTERMINATED_LOGS} != "" ]]; then
|
|
# shellcheck disable=SC2028
|
|
echo "All calls to LogPrintf() and LogPrint() should be terminated with \\n"
|
|
echo
|
|
echo "${UNTERMINATED_LOGS}"
|
|
exit 1
|
|
fi
|