sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-29 13:59:06 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
7d9c572648
dash/src/llmq
History
Konstantin Akimov 7d9c572648
refactor: trivial fixes for dead, useless code and minor fixes for dash specific code (#5793) 
## Issue being fixed or feature implemented
Dead-code, useless conditions can be potential source of bug.

## What was done?
See each particular commit.
This particular commit "fix: check ptr in assert before usage" fixes
potential UB - `assert` is better than UB.
All other commits are not fixing any real issue, just to tidy-up code a
bit or to shut a potential warning.


## How Has This Been Tested?
Run unit/functional tests.

## Breaking Changes
N/A

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone
2024-01-01 21:21:51 -06:00
..
blockprocessor.cpp refactor: use DeploymentActiveAfter in llmq/blockprocessor 2023-12-21 23:02:31 -06:00
blockprocessor.h cleanup: remove TODO so far as it is not clear what exactly to do 'cleanup' 2023-11-18 02:43:47 +07:00
chainlocks.cpp fix: Avoid using GetAdjustedTime() where adjusted time is not really needed or can be harmful (#5631) 2023-10-23 10:39:39 -05:00
chainlocks.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
clsig.cpp chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
clsig.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
commitment.cpp refactor: use CFinalCommitment::GetVersion in llmq/{commitment,dkgsession} 2023-12-21 23:02:31 -06:00
commitment.h refactor: add gsl::not_null to get compile time / run time pointer guarantees (#5595) 2023-10-22 09:14:30 -05:00
context.cpp refactor: drop llmq_versionbitscache in favor of g_versionbitscache 2023-12-21 23:02:31 -06:00
context.h feat: auto generation EHF and spork+EHF activation for MN_RR (#5597) 2023-10-17 22:31:40 -05:00
debug.cpp merge bitcoin#20749: Prune g_chainman usage related to ::LookupBlockIndex 2023-04-04 12:41:45 -05:00
debug.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
dkgsession.cpp refactor: use CFinalCommitment::GetVersion in llmq/{commitment,dkgsession} 2023-12-21 23:02:31 -06:00
dkgsession.h refactor: a new struct CDKGJustification::Contribution instead std::pair 2023-11-18 02:43:47 +07:00
dkgsessionhandler.cpp refactor: move out helper IsDIP3Enforced from deterministicmns 2023-12-21 23:02:31 -06:00
dkgsessionhandler.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
dkgsessionmgr.cpp refactor: move out helper IsDIP3Enforced from deterministicmns 2023-12-21 23:02:31 -06:00
dkgsessionmgr.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
ehf_signals.cpp refactor: use DeploymentActiveAfter in ehf_signals 2023-12-21 23:02:31 -06:00
ehf_signals.h feat: auto generation EHF and spork+EHF activation for MN_RR (#5597) 2023-10-17 22:31:40 -05:00
instantsend.cpp refactor: deprecate non-deterministic IS support (#5553) 2023-11-20 10:17:04 -06:00
instantsend.h refactor: deprecate non-deterministic IS support (#5553) 2023-11-20 10:17:04 -06:00
params.h fix: Redefine keepOldKeys and align quorum and dkgsession key storage depths (#5748) 2023-12-04 13:38:32 +03:00
quorums.cpp fix: ScanQuorums should not start cache population for outdated quorums (#5784) 2023-12-22 13:56:43 -06:00
quorums.h fix: ScanQuorums should not start cache population for outdated quorums (#5784) 2023-12-22 13:56:43 -06:00
signing_shares.cpp fix: Avoid using GetAdjustedTime() where adjusted time is not really needed or can be harmful (#5631) 2023-10-23 10:39:39 -05:00
signing_shares.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
signing.cpp refactor: trivial fixes for dead, useless code and minor fixes for dash specific code (#5793) 2024-01-01 21:21:51 -06:00
signing.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
snapshot.cpp refactor: deprecate non-deterministic IS support (#5553) 2023-11-20 10:17:04 -06:00
snapshot.h refactor: further spanification of Dash code (#5586) 2023-10-03 09:52:33 -05:00
utils.cpp refactor: drop llmq_versionbitscache in favor of g_versionbitscache 2023-12-21 23:02:31 -06:00
utils.h chore: remaining TODO goes to other PRs 2023-12-21 23:02:31 -06:00