mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
9f4f52ae4e
68400d8b96 tests: Use explicit imports (practicalswift) Pull request description: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools. An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports. Before this commit: ``` $ contrib/devtools/lint-python.sh | head -10 ./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util $ ``` After this commit: ``` $ contrib/devtools/lint-python.sh | head -10 $ ``` Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
128 lines
5.3 KiB
Python
Executable File
128 lines
5.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018-2020 The Dash Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
from test_framework.test_framework import DashTestFramework
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error, bytes_to_hex_str, hash256, hex_str_to_bytes, isolate_node, reconnect_isolated_node
|
|
|
|
'''
|
|
p2p_instantsend.py
|
|
|
|
Tests InstantSend functionality (prevent doublespend for unconfirmed transactions)
|
|
'''
|
|
|
|
class InstantSendTest(DashTestFramework):
|
|
def set_test_params(self):
|
|
self.set_dash_test_params(7, 3, fast_dip3_enforcement=True)
|
|
# set sender, receiver, isolated nodes
|
|
self.isolated_idx = 1
|
|
self.receiver_idx = 2
|
|
self.sender_idx = 3
|
|
|
|
def run_test(self):
|
|
self.nodes[0].spork("SPORK_17_QUORUM_DKG_ENABLED", 0)
|
|
self.wait_for_sporks_same()
|
|
self.mine_quorum()
|
|
|
|
self.test_mempool_doublespend()
|
|
self.test_block_doublespend()
|
|
|
|
def test_block_doublespend(self):
|
|
sender = self.nodes[self.sender_idx]
|
|
receiver = self.nodes[self.receiver_idx]
|
|
isolated = self.nodes[self.isolated_idx]
|
|
|
|
# feed the sender with some balance
|
|
sender_addr = sender.getnewaddress()
|
|
self.nodes[0].sendtoaddress(sender_addr, 1)
|
|
self.bump_mocktime(1)
|
|
self.nodes[0].generate(2)
|
|
self.sync_all()
|
|
|
|
# create doublespending transaction, but don't relay it
|
|
dblspnd_tx = self.create_raw_tx(sender, isolated, 0.5, 1, 100)
|
|
# isolate one node from network
|
|
isolate_node(isolated)
|
|
# instantsend to receiver
|
|
receiver_addr = receiver.getnewaddress()
|
|
is_id = sender.sendtoaddress(receiver_addr, 0.9)
|
|
# wait for the transaction to propagate
|
|
connected_nodes = self.nodes.copy()
|
|
del connected_nodes[self.isolated_idx]
|
|
self.sync_mempools(connected_nodes)
|
|
for node in connected_nodes:
|
|
self.wait_for_instantlock(is_id, node)
|
|
# send doublespend transaction to isolated node
|
|
isolated.sendrawtransaction(dblspnd_tx['hex'])
|
|
# generate block on isolated node with doublespend transaction
|
|
self.bump_mocktime(1)
|
|
isolated.generate(1)
|
|
wrong_block = isolated.getbestblockhash()
|
|
# connect isolated block to network
|
|
reconnect_isolated_node(isolated, 0)
|
|
# check doublespend block is rejected by other nodes
|
|
timeout = 10
|
|
for i in range(0, self.num_nodes):
|
|
if i == self.isolated_idx:
|
|
continue
|
|
res = self.nodes[i].waitforblock(wrong_block, timeout)
|
|
assert (res['hash'] != wrong_block)
|
|
# wait for long time only for first node
|
|
timeout = 1
|
|
# send coins back to the controller node without waiting for confirmations
|
|
receiver.sendtoaddress(self.nodes[0].getnewaddress(), 0.9, "", "", True)
|
|
assert_equal(receiver.getwalletinfo()["balance"], 0)
|
|
# mine more blocks
|
|
# TODO: mine these blocks on an isolated node
|
|
self.bump_mocktime(1)
|
|
# make sure the above TX is on node0
|
|
self.sync_mempools([n for n in self.nodes if n is not isolated])
|
|
self.nodes[0].generate(2)
|
|
self.sync_all()
|
|
|
|
def test_mempool_doublespend(self):
|
|
sender = self.nodes[self.sender_idx]
|
|
receiver = self.nodes[self.receiver_idx]
|
|
isolated = self.nodes[self.isolated_idx]
|
|
|
|
# feed the sender with some balance
|
|
sender_addr = sender.getnewaddress()
|
|
self.nodes[0].sendtoaddress(sender_addr, 1)
|
|
self.bump_mocktime(1)
|
|
self.nodes[0].generate(2)
|
|
self.sync_all()
|
|
|
|
# create doublespending transaction, but don't relay it
|
|
dblspnd_tx = self.create_raw_tx(sender, isolated, 0.5, 1, 100)
|
|
dblspnd_txid = bytes_to_hex_str(hash256(hex_str_to_bytes(dblspnd_tx['hex']))[::-1])
|
|
# isolate one node from network
|
|
isolate_node(isolated)
|
|
# send doublespend transaction to isolated node
|
|
isolated.sendrawtransaction(dblspnd_tx['hex'])
|
|
# let isolated node rejoin the network
|
|
# The previously isolated node should NOT relay the doublespending TX
|
|
reconnect_isolated_node(isolated, 0)
|
|
for node in self.nodes:
|
|
if node is not isolated:
|
|
assert_raises_rpc_error(-5, "No such mempool or blockchain transaction", node.getrawtransaction, dblspnd_txid)
|
|
# instantsend to receiver. The previously isolated node should prune the doublespend TX and request the correct
|
|
# TX from other nodes.
|
|
receiver_addr = receiver.getnewaddress()
|
|
is_id = sender.sendtoaddress(receiver_addr, 0.9)
|
|
# wait for the transaction to propagate
|
|
self.sync_mempools()
|
|
for node in self.nodes:
|
|
self.wait_for_instantlock(is_id, node)
|
|
assert_raises_rpc_error(-5, "No such mempool or blockchain transaction", isolated.getrawtransaction, dblspnd_txid)
|
|
# send coins back to the controller node without waiting for confirmations
|
|
receiver.sendtoaddress(self.nodes[0].getnewaddress(), 0.9, "", "", True)
|
|
assert_equal(receiver.getwalletinfo()["balance"], 0)
|
|
# mine more blocks
|
|
self.bump_mocktime(1)
|
|
self.nodes[0].generate(2)
|
|
self.sync_all()
|
|
|
|
if __name__ == '__main__':
|
|
InstantSendTest().main()
|